leandrof/u-boot
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

env: superfluous check before free()

Browse Source 
Free() checks if its argument in NULL. There is no need for the caller to
do the same.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
This commit is contained in:
Heinrich Schuchardt
2021-10-26 00:41:59 +02:00
committed by Tom Rini
parent 73d18e352d
commit 28ab12ad14
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
env/flash.c vendored
View File

@@ -210,8 +210,7 @@ static int env_flash_save(void)
perror: perror:
flash_perror(rc); flash_perror(rc);
done: done:
if (saved_data) free(saved_data);
free(saved_data);
/* try to re-protect */ /* try to re-protect */
flash_sect_protect(1, (ulong)flash_addr, end_addr); flash_sect_protect(1, (ulong)flash_addr, end_addr);
flash_sect_protect(1, (ulong)flash_addr_new, end_addr_new); flash_sect_protect(1, (ulong)flash_addr_new, end_addr_new);
@@ -298,8 +297,7 @@ static int env_flash_save(void)
perror: perror:
flash_perror(rc); flash_perror(rc);
done: done:
if (saved_data) free(saved_data);
free(saved_data);
/* try to re-protect */ /* try to re-protect */
flash_sect_protect(1, (long)flash_addr, end_addr); flash_sect_protect(1, (long)flash_addr, end_addr);
return rc; return rc;