leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bootstd: Fix listing boot devices

Browse Source 
bootdev_list() uses uclass_*_device_err() to iterate devices.
However, the only value _err adds is returning an error when the device
pointer is null, and that's checked anyway.

Also there is some intent to report errors, and that's what
uclass_*_device_check() is for, use it.

Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Michal Suchanek 2022-10-12 21:57:53 +02:00 committed by Simon Glass
parent 5afe93a18c
commit 28a22cd9a4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
boot/bootdev-uclass.c
View File

@ -195,7 +195,7 @@ void bootdev_list(bool probe)
printf("Seq Probed Status Uclass Name\n"); printf("Seq Probed Status Uclass Name\n");
printf("--- ------ ------ -------- ------------------\n"); printf("--- ------ ------ -------- ------------------\n");
if (probe) if (probe)
ret = uclass_first_device_err(UCLASS_BOOTDEV, &dev); ret = uclass_first_device_check(UCLASS_BOOTDEV, &dev);
else else
ret = uclass_find_first_device(UCLASS_BOOTDEV, &dev); ret = uclass_find_first_device(UCLASS_BOOTDEV, &dev);
for (i = 0; dev; i++) { for (i = 0; dev; i++) {
@ -204,7 +204,7 @@ void bootdev_list(bool probe)
ret ? simple_itoa(ret) : "OK", ret ? simple_itoa(ret) : "OK",
dev_get_uclass_name(dev_get_parent(dev)), dev->name); dev_get_uclass_name(dev_get_parent(dev)), dev->name);
if (probe) if (probe)
ret = uclass_next_device_err(&dev); ret = uclass_next_device_check(&dev);
else else
ret = uclass_find_next_device(&dev); ret = uclass_find_next_device(&dev);
} }