leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test: Avoid random numbers in dm_test_devm_regmap()

Browse Source 
There is no good reason to use a sequence from rand() here. We may as well
invent our own sequence.

This should molify Coverity which does not use rand() being used.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reported-by: Coverity (CID: 312949)
This commit is contained in:
Simon Glass 2021-05-13 19:39:23 -06:00 committed by Tom Rini
parent a2cfad8ecc
commit 2177f924bf
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/dm/regmap.c
View File

@ -306,9 +306,8 @@ static int dm_test_devm_regmap(struct unit_test_state *uts)
&dev));
priv = dev_get_priv(dev);
srand(get_ticks() + rand());
for (i = 0; i < REGMAP_TEST_BUF_SZ; i++) {
pattern[i] = rand();
pattern[i] = i * 0x87654321;
ut_assertok(regmap_write(priv->cfg_regmap, i, pattern[i]));
}
for (i = 0; i < REGMAP_TEST_BUF_SZ; i++) {