leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cmd: ubifs: Do not show usage when command fails

Browse Source 
Return value -1 cause U-Boot to print usage message. Return value
1 (CMD_RET_FAILURE) indicates failure. So fix return value when ubifs
command starts it execution and fails.

Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Dhruva Gole <d-gole@ti.com>
This commit is contained in:
Pali Rohár 2022-08-07 21:58:56 +02:00 committed by Tom Rini
parent 6b752c729e
commit 1853811287
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cmd/ubifs.c
View File

@ -33,7 +33,7 @@ int cmd_ubifs_mount(char *vol_name)
ret = uboot_ubifs_mount(vol_name); ret = uboot_ubifs_mount(vol_name);
if (ret) if (ret)
return -1; return CMD_RET_FAILURE;
ubifs_mounted = 1; ubifs_mounted = 1;
@ -62,7 +62,7 @@ int cmd_ubifs_umount(void)
{ {
if (ubifs_initialized == 0) { if (ubifs_initialized == 0) {
printf("No UBIFS volume mounted!\n"); printf("No UBIFS volume mounted!\n");
return -1; return CMD_RET_FAILURE;
} }
uboot_ubifs_umount(); uboot_ubifs_umount();
@ -89,7 +89,7 @@ static int do_ubifs_ls(struct cmd_tbl *cmdtp, int flag, int argc,
if (!ubifs_mounted) { if (!ubifs_mounted) {
printf("UBIFS not mounted, use ubifsmount to mount volume first!\n"); printf("UBIFS not mounted, use ubifsmount to mount volume first!\n");
return -1; return CMD_RET_FAILURE;
} }
if (argc == 2) if (argc == 2)
@ -116,7 +116,7 @@ static int do_ubifs_load(struct cmd_tbl *cmdtp, int flag, int argc,
if (!ubifs_mounted) { if (!ubifs_mounted) {
printf("UBIFS not mounted, use ubifs mount to mount volume first!\n"); printf("UBIFS not mounted, use ubifs mount to mount volume first!\n");
return -1; return CMD_RET_FAILURE;
} }
if (argc < 3) if (argc < 3)