leandrof/u-boot
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test: Detect when expect_str is too small

Browse Source 
If a line of more than 256 bytes is generated, the test will fail but the
reason is not clear. Add a check for this condition and print a helpful
message.

Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Simon Glass
2021-05-08 06:59:57 -06:00
committed by Tom Rini
parent c1a2bb4f83
commit 090d664eac
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
test/ut.c
View File

@@ -68,11 +68,17 @@ static int readline_check(struct unit_test_state *uts)
int ut_check_console_line(struct unit_test_state *uts, const char *fmt, ...) int ut_check_console_line(struct unit_test_state *uts, const char *fmt, ...)
{ {
va_list args; va_list args;
int len;
int ret; int ret;
va_start(args, fmt); va_start(args, fmt);
vsnprintf(uts->expect_str, sizeof(uts->expect_str), fmt, args); len = vsnprintf(uts->expect_str, sizeof(uts->expect_str), fmt, args);
va_end(args); va_end(args);
if (len >= sizeof(uts->expect_str)) {
ut_fail(uts, __FILE__, __LINE__, __func__,
"unit_test_state->expect_str too small");
return -EOVERFLOW;
}
ret = readline_check(uts); ret = readline_check(uts);
if (ret < 0) if (ret < 0)
return ret; return ret;
@@ -83,11 +89,17 @@ int ut_check_console_line(struct unit_test_state *uts, const char *fmt, ...)
int ut_check_console_linen(struct unit_test_state *uts, const char *fmt, ...) int ut_check_console_linen(struct unit_test_state *uts, const char *fmt, ...)
{ {
va_list args; va_list args;
int len;
int ret; int ret;
va_start(args, fmt); va_start(args, fmt);
vsnprintf(uts->expect_str, sizeof(uts->expect_str), fmt, args); len = vsnprintf(uts->expect_str, sizeof(uts->expect_str), fmt, args);
va_end(args); va_end(args);
if (len >= sizeof(uts->expect_str)) {
ut_fail(uts, __FILE__, __LINE__, __func__,
"unit_test_state->expect_str too small");
return -EOVERFLOW;
}
ret = readline_check(uts); ret = readline_check(uts);
if (ret < 0) if (ret < 0)
return ret; return ret;