leandrof/u-boot
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: dc2114x: Use standard I/O accessors

Browse Source 
The current dc21x4x driver accesses its memory mapped registers directly
instead of using the standard I/O accessors. This can cause problems on
some systems as the accesses can get out of order. So convert the direct
volatile dereferences to use the normal in/out macros.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Joe Hershberger <joe.hershberger@ni.com>
Cc: Ramon Fried <rfried.dev@gmail.com>
This commit is contained in:
Marek Vasut
2020-07-08 06:31:54 +02:00
parent 9b98f20494
commit 02b95a4b41
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/dc2114x.c
View File

@@ -1,6 +1,7 @@
// SPDX-License-Identifier: GPL-2.0+ // SPDX-License-Identifier: GPL-2.0+
#include <common.h> #include <common.h>
#include <asm/io.h>
#include <env.h> #include <env.h>
#include <malloc.h> #include <malloc.h>
#include <net.h> #include <net.h>
@@ -104,12 +105,12 @@ static char tx_ring_size;
static u32 dc2114x_inl(struct eth_device *dev, u32 addr) static u32 dc2114x_inl(struct eth_device *dev, u32 addr)
{ {
return le32_to_cpu(*(volatile u32 *)(addr + dev->iobase)); return le32_to_cpu(readl(dev->iobase + addr));
} }
static void dc2114x_outl(struct eth_device *dev, u32 command, u32 addr) static void dc2114x_outl(struct eth_device *dev, u32 command, u32 addr)
{ {
*(volatile u32 *)(addr + dev->iobase) = cpu_to_le32(command); writel(cpu_to_le32(command), dev->iobase + addr);
} }
static void reset_de4x5(struct eth_device *dev) static void reset_de4x5(struct eth_device *dev)