Vladimir Oltean 46baae56e1 net: dsa: hellcreek: be compatible with masters which unregister on shutdown ... Since commit 2f1e8ea726 ("net: dsa: link interfaces with the DSA master to get rid of lockdep warnings"), DSA gained a requirement which it did not fulfill, which is to unlink itself from the DSA master at shutdown time. Since the hellcreek driver was introduced after the bad commit, it has never worked with DSA masters which decide to unregister their net_device on shutdown, effectively hanging the reboot process. Hellcreek is a platform device driver, so we probably cannot have the oddities of ->shutdown and ->remove getting both called for the exact same struct device. But to be in line with the pattern from the other device drivers which are on slow buses, implement the same "if this then not that" pattern of either running the ->shutdown or the ->remove hook. The driver's current ->remove implementation makes that very easy because it already zeroes out its device_drvdata on ->remove. Fixes: e4b27ebc78 ("net: dsa: Add DSA driver for Hirschmann Hellcreek switches") Link: https://lore.kernel.org/netdev/20210909095324.12978-1-LinoSanfilippo@gmx.de/ Reported-by: Lino Sanfilippo <LinoSanfilippo@gmx.de> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Acked-by: Kurt Kanzenbach <kurt@linutronix.de> Signed-off-by: David S. Miller <davem@davemloft.net>		2021-09-19 12:08:37 +01:00
..
hellcreek_hwtstamp.c	net: dsa: no longer clone skb in core driver	2021-04-27 14:10:15 -07:00
hellcreek_hwtstamp.h	net: dsa: no longer clone skb in core driver	2021-04-27 14:10:15 -07:00
hellcreek_ptp.c	net: dsa: hellcreek: Add PTP status LEDs	2020-11-05 14:04:50 -08:00
hellcreek_ptp.h	net: dsa: hellcreek: Add PTP status LEDs	2020-11-05 14:04:50 -08:00
hellcreek.c	net: dsa: hellcreek: be compatible with masters which unregister on shutdown	2021-09-19 12:08:37 +01:00
hellcreek.h	net: dsa: hellcreek: Add devlink FDB region	2021-03-13 14:30:48 -08:00
Kconfig	net: dsa: hellcreek: Add missing TAPRIO dependency	2021-01-29 21:02:31 -08:00
Makefile	net: dsa: hellcreek: Add support for hardware timestamping	2020-11-05 14:04:49 -08:00