Thomas Zimmermann
fb84efa28a
drm/aperture: Run fbdev removal before internal helpers
Always run fbdev removal first to remove simpledrm via
sysfb_disable(). This clears the internal state. The later call
to drm_aperture_detach_drivers() then does nothing. Otherwise,
with drm_aperture_detach_drivers() running first, the call to
sysfb_disable() uses inconsistent state.
Example backtrace show below:
[ 11.663422] ==================================================================
[ 11.663426] BUG: KASAN: use-after-free in device_del+0x79/0x5f0
[ 11.663435] Read of size 8 at addr ffff888108185050 by task systemd-udevd/311
[ 11.663440] CPU: 0 PID: 311 Comm: systemd-udevd Tainted: G E 5
.19.0-rc2-1-default+ #1689
[ 11.663445] Hardware name: HP ProLiant DL120 G7, BIOS J01 04/21/2011
[ 11.663447] Call Trace:
[ 11.663449] <TASK>
[ 11.663451] ? device_del+0x79/0x5f0
[ 11.663456] dump_stack_lvl+0x5b/0x73
[ 11.663462] print_address_description.constprop.0+0x1f/0x1b0
[ 11.663468] ? device_del+0x79/0x5f0
[ 11.663471] ? device_del+0x79/0x5f0
[ 11.663475] print_report.cold+0x3c/0x21c
[ 11.663481] ? lock_acquired+0x87/0x1e0
[ 11.663484] ? lock_acquired+0x87/0x1e0
[ 11.663489] ? device_del+0x79/0x5f0
[ 11.663492] kasan_report+0xbf/0xf0
[ 11.663498] ? device_del+0x79/0x5f0
[ 11.663503] device_del+0x79/0x5f0
[ 11.663509] ? device_remove_attrs+0x170/0x170
[ 11.663514] ? lock_is_held_type+0xe8/0x140
[ 11.663523] platform_device_del.part.0+0x19/0xe0
[ 11.663530] platform_device_unregister+0x1c/0x30
[ 11.663535] sysfb_disable+0x2d/0x70
[ 11.663540] remove_conflicting_framebuffers+0x1c/0xf0
[ 11.663546] remove_conflicting_pci_framebuffers+0x130/0x1a0
[ 11.663554] drm_aperture_remove_conflicting_pci_framebuffers+0x86/0xb0
[ 11.663561] ? mgag200_pci_remove+0x30/0x30 [mgag200]
[ 11.663578] mgag200_pci_probe+0x2d/0x140 [mgag200]
Reported-by: Zack Rusin <zackr@vmware.com>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Zack Rusin <zackr@vmware.com>
Fixes: 873eb3b118 ("fbdev: Disable sysfb device registration when removing conflicting FBs")
Cc: Javier Martinez Canillas <javierm@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Helge Deller <deller@gmx.de>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Changcheng Deng <deng.changcheng@zte.com.cn>
Link: https://patchwork.freedesktop.org/patch/msgid/20220617121027.30273-1-tzimmermann@suse.de
2022-06-21 12:54:34 +02:00
..
2022-06-20 18:18:49 -04:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-05-17 12:20:04 +10:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-15 19:12:17 +02:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-02-23 10:44:43 +01:00
2022-04-07 12:53:53 +02:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-15 19:12:17 +02:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-05-21 18:02:47 +02:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-05-17 10:06:41 -04:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-15 19:12:17 +02:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-12 22:10:50 -01:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-04-07 12:53:53 +02:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-21 11:23:52 +03:00
2022-06-21 12:54:34 +02:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-03-16 09:36:13 +01:00
2022-03-04 19:34:24 +00:00
2022-06-02 15:15:10 -07:00
2022-04-11 15:35:47 +02:00
2022-03-24 16:19:43 -07:00
2022-06-20 23:53:55 +03:00
2022-02-07 16:35:35 -08:00
2022-05-04 14:09:34 +02:00
2022-04-25 11:19:36 +02:00
2022-01-17 11:25:44 +01:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-05-23 11:27:36 +03:00
2022-05-13 18:55:13 +03:00
2022-06-13 12:30:54 +03:00
2022-05-25 17:39:49 +02:00
2022-06-20 23:53:55 +03:00
2022-05-05 08:54:09 +02:00
2022-01-31 21:45:23 +01:00
2022-06-20 23:53:55 +03:00
2022-06-08 17:36:15 +02:00
2022-05-19 19:25:23 +02:00
2022-02-25 05:50:18 +10:00
2022-02-07 16:35:35 -08:00
2022-05-19 19:25:19 +02:00
2022-04-07 12:53:53 +02:00
2022-02-07 16:35:35 -08:00
2022-01-31 21:45:23 +01:00
2022-06-20 23:53:55 +03:00
2022-05-05 09:04:10 +02:00
2022-06-20 23:53:55 +03:00
2022-04-25 11:19:36 +02:00
2022-01-22 08:33:37 +02:00
2022-06-20 23:53:55 +03:00
2022-02-25 17:55:42 +01:00
2022-06-20 23:53:55 +03:00
2022-06-20 23:53:55 +03:00
2022-01-22 08:33:37 +02:00
2022-06-12 12:22:22 +02:00
2022-01-31 13:19:33 -05:00
2022-04-28 16:13:04 +01:00
2022-02-07 16:35:35 -08:00
2022-02-01 19:02:41 +10:00
2022-02-25 05:50:18 +10:00
2022-06-13 12:31:27 +03:00
2022-06-13 08:54:16 +02:00
2022-04-12 09:27:20 +03:00
2022-06-03 20:09:27 +08:00
2022-06-20 23:53:55 +03:00
2022-06-09 16:49:56 +02:00
2022-06-09 16:49:56 +02:00