leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity
fb6c83cab3
linux/sound/soc/amd
History
Pierre-Louis Bossart fb6c83cab3
ASoC: AMD: fix depend/select mistake on SND_AMD_ACP_CONFIG 
on i386 or x86_64:

when # CONFIG_ACPI is not set,
so SND_SOC_ACPI is not set:

WARNING: unmet direct dependencies detected for SND_AMD_ACP_CONFIG
  Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] &&
  SND_SOC_ACPI [=n]
  Selected by [y]:
  - SND_SOC_AMD_ACP_COMMON [=y] && SOUND [=y] && !UML && SND [=y] &&
  SND_SOC [=y] && X86 [=y] && PCI [=y]

This problem is due to the unconditional selection of
SND_AMD_ACP_CONFIG in other options. Using 'depends on' solved an
initial problem but exposed another, let's use select instead.

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Fixes: d9b994cd76 ('ASoC: AMD: acp-config: fix missing dependency on SND_SOC_ACPI')
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@intel.com>
Reviewed-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
Link: https://lore.kernel.org/r/20211215163511.151286-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-12-15 22:16:51 +00:00
..
acp ASoC: amd: acp: select CONFIG_SND_SOC_ACPI 2021-10-29 14:57:16 +01:00
include
raven Merge some cs42l42 patches into asoc-5.15 2021-08-06 01:46:24 +01:00
renoir Merge some cs42l42 patches into asoc-5.15 2021-08-06 01:46:24 +01:00
vangogh ASoC: amd: enable vangogh platform machine driver build 2021-10-15 16:10:55 +01:00
yc ASoC: amd: acp6x-pdm-dma: Constify static snd_soc_dai_ops 2021-12-06 13:49:31 +00:00
acp3x-rt5682-max9836.c ASoC: amd: Convert to new style DAI format definitions 2021-12-08 16:47:31 +00:00
acp-config.c ASoC: amd: acp-config: Remove legacy acpi based machine struct 2021-11-17 17:35:53 +00:00
acp-da7219-max98357a.c ASoC: amd: Convert to new style DAI format definitions 2021-12-08 16:47:31 +00:00
acp-pcm-dma.c ASoC: amd: acp-pcm-dma: add .delay support 2021-11-29 12:19:42 +00:00
acp-rt5645.c ASoC: amd: Convert to new style DAI format definitions 2021-12-08 16:47:31 +00:00
acp.h ASoC: amd: acp-pcm-dma: add .delay support 2021-11-29 12:19:42 +00:00
Kconfig ASoC: AMD: fix depend/select mistake on SND_AMD_ACP_CONFIG 2021-12-15 22:16:51 +00:00
mach-config.h ASoC: amd: acp-config: Remove legacy acpi based machine struct 2021-11-17 17:35:53 +00:00
Makefile ASoC: amd: Add module to determine ACP configuration 2021-11-17 17:35:50 +00:00