forked from Minki/linux
75b1a8f9d6
strlcpy is deprecated. see: Documentation/process/deprecated.rst Change the calls that do not use the strlcpy return value to the preferred strscpy. Done with cocci script: @@ expression e1, e2, e3; @@ - strlcpy( + strscpy( e1, e2, e3); This cocci script leaves the instances where the return value is used unchanged. After this patch, sound/ has 3 uses of strlcpy() that need to be manually inspected for conversion and changed one day. $ git grep -w strlcpy sound/ sound/usb/card.c: len = strlcpy(card->longname, s, sizeof(card->longname)); sound/usb/mixer.c: return strlcpy(buf, p->name, buflen); sound/usb/mixer.c: return strlcpy(buf, p->names[index], buflen); Miscellenea: o Remove trailing whitespace in conversion of sound/core/hwdep.c Link: https://lore.kernel.org/lkml/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ Signed-off-by: Joe Perches <joe@perches.com> Acked-by: Mark Brown <broonie@kernel.org> Link: https://lore.kernel.org/r/22b393d1790bb268769d0bab7bacf0866dcb0c14.camel@perches.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
55 lines
1.4 KiB
C
55 lines
1.4 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include <linux/kernel.h>
|
|
#include <linux/of.h>
|
|
#include <linux/stat.h>
|
|
/* FIX UP */
|
|
#include "soundbus.h"
|
|
|
|
static ssize_t modalias_show(struct device *dev, struct device_attribute *attr,
|
|
char *buf)
|
|
{
|
|
struct soundbus_dev *sdev = to_soundbus_device(dev);
|
|
struct platform_device *of = &sdev->ofdev;
|
|
int length;
|
|
|
|
if (*sdev->modalias) {
|
|
strscpy(buf, sdev->modalias, sizeof(sdev->modalias) + 1);
|
|
strcat(buf, "\n");
|
|
length = strlen(buf);
|
|
} else {
|
|
length = sprintf(buf, "of:N%pOFn%c%s\n",
|
|
of->dev.of_node, 'T',
|
|
of_node_get_device_type(of->dev.of_node));
|
|
}
|
|
|
|
return length;
|
|
}
|
|
static DEVICE_ATTR_RO(modalias);
|
|
|
|
static ssize_t name_show(struct device *dev,
|
|
struct device_attribute *attr, char *buf)
|
|
{
|
|
struct soundbus_dev *sdev = to_soundbus_device(dev);
|
|
struct platform_device *of = &sdev->ofdev;
|
|
|
|
return sprintf(buf, "%pOFn\n", of->dev.of_node);
|
|
}
|
|
static DEVICE_ATTR_RO(name);
|
|
|
|
static ssize_t type_show(struct device *dev,
|
|
struct device_attribute *attr, char *buf)
|
|
{
|
|
struct soundbus_dev *sdev = to_soundbus_device(dev);
|
|
struct platform_device *of = &sdev->ofdev;
|
|
|
|
return sprintf(buf, "%s\n", of_node_get_device_type(of->dev.of_node));
|
|
}
|
|
static DEVICE_ATTR_RO(type);
|
|
|
|
struct attribute *soundbus_dev_attrs[] = {
|
|
&dev_attr_name.attr,
|
|
&dev_attr_type.attr,
|
|
&dev_attr_modalias.attr,
|
|
NULL,
|
|
};
|