forked from Minki/linux
e4563f6ba7
Instead of receiving the num_crts as a parameter, we can read it directly from the mode_config structure. I audited the drivers that invoke this helper and I believe all of them initialize the mode_config struct accordingly, prior to calling the fb_helper. I used the following coccinelle hack to make this transformation, except for the function headers and comment updates. The first and second rules are split because I couldn't find a way to remove the unused temporary variables at the same time I removed the parameter. // <smpl> @r@ expression A,B,D,E; identifier C; @@ ( - drm_fb_helper_init(A,B,C,D) + drm_fb_helper_init(A,B,D) | - drm_fbdev_cma_init_with_funcs(A,B,C,D,E) + drm_fbdev_cma_init_with_funcs(A,B,D,E) | - drm_fbdev_cma_init(A,B,C,D) + drm_fbdev_cma_init(A,B,D) ) @@ expression A,B,C,D,E; @@ ( - drm_fb_helper_init(A,B,C,D) + drm_fb_helper_init(A,B,D) | - drm_fbdev_cma_init_with_funcs(A,B,C,D,E) + drm_fbdev_cma_init_with_funcs(A,B,D,E) | - drm_fbdev_cma_init(A,B,C,D) + drm_fbdev_cma_init(A,B,D) ) @@ identifier r.C; type T; expression V; @@ - T C; <... when != C - C = V; ...> // </smpl> Changes since v1: - Rebased on top of the tip of drm-misc-next. - Remove mention to sti since a proper fix got merged. Suggested-by: Daniel Vetter <daniel.vetter@intel.com> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk> Reviewed-by: Eric Anholt <eric@anholt.net> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: http://patchwork.freedesktop.org/patch/msgid/20170202162640.27261-1-krisman@collabora.co.uk |
||
---|---|---|
.. | ||
Kconfig | ||
Makefile | ||
NOTES | ||
sti_awg_utils.c | ||
sti_awg_utils.h | ||
sti_compositor.c | ||
sti_compositor.h | ||
sti_crtc.c | ||
sti_crtc.h | ||
sti_cursor.c | ||
sti_cursor.h | ||
sti_drv.c | ||
sti_drv.h | ||
sti_dvo.c | ||
sti_gdp.c | ||
sti_gdp.h | ||
sti_hda.c | ||
sti_hdmi_tx3g4c28phy.c | ||
sti_hdmi_tx3g4c28phy.h | ||
sti_hdmi.c | ||
sti_hdmi.h | ||
sti_hqvdp_lut.h | ||
sti_hqvdp.c | ||
sti_mixer.c | ||
sti_mixer.h | ||
sti_plane.c | ||
sti_plane.h | ||
sti_tvout.c | ||
sti_vid.c | ||
sti_vid.h | ||
sti_vtg.c | ||
sti_vtg.h |