forked from Minki/linux
f4ec9e9531
Under most circumstances, the bitmap allocator does not allocate the same full 24-bit QP number immediately after a QP is destroyed. This works by using the upper bits of a 24-bit QP number, beyond the number of QPs that are actually available in the low level driver. For example, say that the HCA is willing to allocate a maximum of 64K qps. We use the bits 23..16 as a "counter" which is incremented by 1 at each allocation so that even if the same physical QP is re-allocated, it will not receive the same 24-bit QP number. However, we have seen the following scenario: 1. Allocate, say, 255 QPs in succession. This will cause a wrap of the "counter". 2. Destroy the first QP allocated, then allocate a new QP. The new QP, because of the counter wraparound, will get the same FULL QP number as the QP just destroyed! This is a problem because packets in transit can be erroneously delivered to the new QP when they were meant for the old (destroyed) QP, because the full QP number of the new QP is identical to the destroyed QP. (The "counter" mechanism is meant to prevent this by having the full 24-bit QP numbers differ even if the physical QP on the HCA is the same. As we see above, however, this mechanism does not always work). The best fix for this problem is to allocate QPs in round-robin mode, so that the physical QP numbers are not immediately re-used. Found-by: Matthew Finlay <matt@mellanox.com> Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il> Signed-off-by: Roland Dreier <roland@purestorage.com> |
||
|---|---|---|
| .. | ||
| alloc.c | ||
| catas.c | ||
| cmd.c | ||
| cq.c | ||
| en_cq.c | ||
| en_ethtool.c | ||
| en_main.c | ||
| en_netdev.c | ||
| en_port.c | ||
| en_port.h | ||
| en_resources.c | ||
| en_rx.c | ||
| en_selftest.c | ||
| en_tx.c | ||
| eq.c | ||
| fw.c | ||
| fw.h | ||
| icm.c | ||
| icm.h | ||
| intf.c | ||
| Kconfig | ||
| main.c | ||
| Makefile | ||
| mcg.c | ||
| mlx4_en.h | ||
| mlx4.h | ||
| mr.c | ||
| pd.c | ||
| port.c | ||
| profile.c | ||
| qp.c | ||
| reset.c | ||
| resource_tracker.c | ||
| sense.c | ||
| srq.c | ||