linux/drivers/ieee1394
Stefan Richter f412bf440b ieee1394: sbp2: remove unnecessary alignments of struct members
The members "dma_addr_t command_orb_dma" and "dma_addr_t sge_dma" of
sbp2.h::sbp2_command_info do not have to be aligned themselves --- only
the memory which they point to has to be.

The member "struct sbp2_command_orb command_orb" has to be aligned on
4 bytes boundary which is guaranteed because it contains u32 members.

The member "struct sbp2_unrestricted_page_table scatter_gather_element",
i.e. the SBP-2 s/g table, has to be aligned on 8 bytes boundary
according to the SBP-2 spec.  This is not a requirement for FireWire
controllers but could be expected by SBP-2 targets.

I see no need to align the members command_orb and
scatter_gather_element on CPU cacheline boundaries.  It could have
performance benefits, but on the other hand sbp2 has a somewhat wasteful
allocation scheme which should be optimized first before further tweaks
like cacheline alignments.  (E.g. don't always allocate SG_ALL s/g table
elements.)

Note, before as well as after the patch, the code relies on the
assumption that memory alignment in the virtual address space is
preserved in the physical address space after DMA mapping.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
2007-04-30 00:00:27 +02:00
..
config_roms.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
config_roms.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
csr1212.c ieee1394: nodemgr: check info_length in ROM header earlier 2007-02-08 20:59:03 +01:00
csr1212.h ieee1394: add preprocessor constant for invalid csr address 2006-06-12 18:15:31 -04:00
csr.c ieee1394: usecs_to_jiffies takes unsigned int argument 2006-12-07 21:29:08 +01:00
csr.h [PATCH] ieee1394: clean up declarations of hpsb_*_config_rom 2006-07-03 12:02:31 -04:00
dma.c [PATCH] ieee1394: update #include directives in midlayer header files 2006-07-03 12:02:29 -04:00
dma.h [PATCH] ieee1394: update #include directives in midlayer header files 2006-07-03 12:02:29 -04:00
dv1394-private.h [PATCH] ieee1394: dv1394: sem2mutex conversion 2006-07-03 12:02:32 -04:00
dv1394.c ieee1394: change deprecation status of dv1394 2007-04-09 18:52:27 +02:00
dv1394.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
eth1394.c [SK_BUFF]: Introduce ip_hdr(), remove skb->nh.iph 2007-04-25 22:25:10 -07:00
eth1394.h [SK_BUFF]: Introduce skb_mac_header() 2007-04-25 22:24:41 -07:00
highlevel.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
highlevel.h ieee1394: remove unused struct member from highlevel API 2006-12-07 21:20:30 +01:00
hosts.c ieee1394: restore config ROM when resuming 2007-02-08 20:59:19 +01:00
hosts.h ieee1394: save one word in struct hpsb_host 2007-02-08 20:59:27 +01:00
ieee1394_core.c ieee1394: cycle timer read extension for raw1394 2007-02-17 14:39:33 +01:00
ieee1394_core.h ieee1394: cycle timer read extension for raw1394 2007-02-17 14:39:33 +01:00
ieee1394_hotplug.h [PATCH] ieee1394: remove redundant code from ieee1394_hotplug.h 2006-07-03 12:02:30 -04:00
ieee1394_transactions.c ieee1394: shrink tlabel pools, remove tpool semaphores 2006-09-17 19:17:13 +02:00
ieee1394_transactions.h ieee1394: shrink tlabel pools, remove tpool semaphores 2006-09-17 19:17:13 +02:00
ieee1394_types.h ieee1394: safer definition of empty macros 2006-09-17 19:31:20 +02:00
ieee1394-ioctl.h ieee1394: cycle timer read extension for raw1394 2007-02-17 14:39:33 +01:00
ieee1394.h [PATCH] ieee1394: coding style and comment fixes in midlayer header files 2006-07-03 12:02:28 -04:00
iso.c [PATCH] remove many unneeded #includes of sched.h 2007-02-14 08:09:54 -08:00
iso.h [PATCH] ieee1394: update #include directives in midlayer header files 2006-07-03 12:02:29 -04:00
Kconfig ieee1394: change deprecation status of dv1394 2007-04-09 18:52:27 +02:00
Makefile the scheduled IEEE1394_OUI_DB removal 2007-02-08 20:57:43 +01:00
nodemgr.c IEEE1394: remove rwsem use from ieee1394 core 2007-04-27 10:57:30 -07:00
nodemgr.h the scheduled IEEE1394_OUI_DB removal 2007-02-08 20:57:43 +01:00
ohci1394.c Storage class should be before const qualifier 2007-02-17 20:11:19 +01:00
ohci1394.h ohci1394: set address range properties 2006-06-12 18:13:32 -04:00
pcilynx.c i2c: Declare more i2c_adapter parent devices 2007-02-13 22:09:03 +01:00
pcilynx.h Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
raw1394-private.h ieee1394: raw1394: add comments on lock usage 2006-12-07 21:28:06 +01:00
raw1394.c Merge branch 'for-linus' of ssh://master.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6 2007-02-19 13:07:19 -08:00
raw1394.h ieee1394: cycle timer read extension for raw1394 2007-02-17 14:39:33 +01:00
sbp2.c ieee1394: sbp2: lower block queue alignment requirement 2007-02-08 20:59:54 +01:00
sbp2.h ieee1394: sbp2: remove unnecessary alignments of struct members 2007-04-30 00:00:27 +02:00
video1394.c [PATCH] mark struct file_operations const 3 2007-02-12 09:48:45 -08:00
video1394.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00