Eric Snowberg
a37f4958f7
debugfs: Return -EPERM when locked down
When lockdown is enabled, debugfs_is_locked_down returns 1. It will then
trigger the following:
WARNING: CPU: 48 PID: 3747
CPU: 48 PID: 3743 Comm: bash Not tainted 5.4.0-1946.x86_64 #1
Hardware name: Oracle Corporation ORACLE SERVER X7-2/ASM, MB, X7-2, BIOS 41060400 05/20/2019
RIP: 0010:do_dentry_open+0x343/0x3a0
Code: 00 40 08 00 45 31 ff 48 c7 43 28 40 5b e7 89 e9 02 ff ff ff 48 8b 53 28 4c 8b 72 70 4d 85 f6 0f 84 10 fe ff ff e9 f5 fd ff ff <0f> 0b 41 bf ea ff ff ff e9 3b ff ff ff 41 bf e6 ff ff ff e9 b4 fe
RSP: 0018:ffffb8740dde7ca0 EFLAGS: 00010202
RAX: ffffffff89e88a40 RBX: ffff928c8e6b6f00 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffff928dbfd97778 RDI: ffff9285cff685c0
RBP: ffffb8740dde7cc8 R08: 0000000000000821 R09: 0000000000000030
R10: 0000000000000057 R11: ffffb8740dde7a98 R12: ffff926ec781c900
R13: ffff928c8e6b6f10 R14: ffffffff8936e190 R15: 0000000000000001
FS: 00007f45f6777740(0000) GS:ffff928dbfd80000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fff95e0d5d8 CR3: 0000001ece562006 CR4: 00000000007606e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
PKRU: 55555554
Call Trace:
vfs_open+0x2d/0x30
path_openat+0x2d4/0x1680
? tty_mode_ioctl+0x298/0x4c0
do_filp_open+0x93/0x100
? strncpy_from_user+0x57/0x1b0
? __alloc_fd+0x46/0x150
do_sys_open+0x182/0x230
__x64_sys_openat+0x20/0x30
do_syscall_64+0x60/0x1b0
entry_SYSCALL_64_after_hwframe+0x170/0x1d5
RIP: 0033:0x7f45f5e5ce02
Code: 25 00 00 41 00 3d 00 00 41 00 74 4c 48 8d 05 25 59 2d 00 8b 00 85 c0 75 6d 89 f2 b8 01 01 00 00 48 89 fe bf 9c ff ff ff 0f 05 <48> 3d 00 f0 ff ff 0f 87 a2 00 00 00 48 8b 4c 24 28 64 48 33 0c 25
RSP: 002b:00007fff95e0d2e0 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: ffffffffffffffda RBX: 0000561178c069b0 RCX: 00007f45f5e5ce02
RDX: 0000000000000241 RSI: 0000561178c08800 RDI: 00000000ffffff9c
RBP: 00007fff95e0d3e0 R08: 0000000000000020 R09: 0000000000000005
R10: 00000000000001b6 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000003 R14: 0000000000000001 R15: 0000561178c08800
Change the return type to int and return -EPERM when lockdown is enabled
to remove the warning above. Also rename debugfs_is_locked_down to
debugfs_locked_down to make it sound less like it returns a boolean.
Fixes: 5496197f9b ("debugfs: Restrict debugfs when the kernel is locked down")
Signed-off-by: Eric Snowberg <eric.snowberg@oracle.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: stable <stable@vger.kernel.org>
Acked-by: James Morris <jamorris@linux.microsoft.com>
Link: https://lore.kernel.org/r/20191207161603.35907-1-eric.snowberg@oracle.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-01-14 16:14:48 +01:00
..
2019-09-27 15:10:34 -07:00
2019-07-19 11:33:22 -07:00
2019-11-18 14:26:43 +01:00
2019-12-11 17:48:20 +00:00
2019-12-05 17:11:48 -08:00
2019-08-30 07:27:17 -07:00
2019-08-30 07:27:17 -07:00
2019-12-09 17:56:06 +01:00
2019-05-24 17:27:11 +02:00
2019-12-09 20:55:10 +01:00
2019-12-13 00:49:57 -06:00
2019-09-19 09:42:37 -07:00
2019-11-06 18:36:01 +01:00
2019-11-23 21:44:49 -05:00
2019-12-09 10:36:44 -08:00
2020-01-14 16:14:48 +01:00
2019-09-03 09:30:56 -04:00
2019-07-12 17:37:53 -07:00
2019-12-01 13:46:15 -08:00
2019-07-19 10:42:02 -07:00
2019-08-30 07:27:17 -07:00
2019-12-11 12:25:32 -08:00
2019-11-11 09:21:59 -05:00
2019-11-30 11:16:07 -08:00
2019-12-01 13:46:15 -08:00
2019-12-01 13:46:15 -08:00
2019-10-23 17:23:43 +02:00
2019-08-30 07:27:17 -07:00
2019-07-10 18:43:43 -07:00
2019-12-06 13:57:04 -08:00
2019-12-05 13:20:11 -08:00
2019-05-21 10:50:46 +02:00
2019-07-16 19:23:23 -07:00
2019-05-12 17:52:13 -04:00
2019-10-23 17:23:46 +02:00
2019-12-01 12:59:08 -08:00
2019-12-05 07:41:16 -08:00
2019-09-19 09:42:37 -07:00
2019-11-30 10:53:02 -08:00
2019-11-29 11:29:58 +01:00
2019-09-19 09:42:37 -07:00
2020-01-14 16:14:47 +01:00
2019-11-03 21:28:45 -05:00
2019-08-30 07:27:17 -07:00
2019-11-18 11:04:32 +01:00
2019-05-21 10:50:46 +02:00
2019-12-07 16:56:00 -08:00
2019-10-23 17:23:46 +02:00
2019-05-21 10:50:46 +02:00
2019-12-01 13:46:15 -08:00
2019-09-26 10:10:44 -07:00
2019-12-01 20:36:41 -08:00
2019-08-30 08:11:25 -07:00
2019-07-19 10:42:02 -07:00
2019-12-04 08:52:55 -05:00
2019-12-14 11:13:54 -08:00
2019-12-04 19:44:11 -08:00
2019-10-29 09:43:03 -07:00
2019-08-30 07:27:17 -07:00
2019-08-30 07:27:17 -07:00
2019-12-06 09:06:58 -08:00
2019-09-12 21:05:34 -04:00
2019-11-05 12:25:22 +01:00
2019-09-19 10:06:57 -07:00
2019-09-19 10:06:57 -07:00
2019-07-19 10:42:02 -07:00
2019-08-30 07:27:18 -07:00
2019-10-12 20:49:07 -04:00
2019-11-17 22:22:54 +01:00
2019-09-04 18:19:43 +02:00
2019-09-19 09:42:37 -07:00
2019-09-17 11:48:24 -04:00
2019-12-09 10:36:44 -08:00
2019-12-07 17:05:33 -08:00
2019-12-01 14:00:59 -08:00
2019-07-19 10:42:02 -07:00
2019-08-30 07:27:17 -07:00
2019-05-21 10:50:45 +02:00
2019-11-15 14:38:29 +01:00
2019-12-04 19:44:13 -08:00
2019-05-21 10:50:45 +02:00
2019-07-16 19:23:22 -07:00
2019-07-19 10:42:02 -07:00
2019-05-21 10:50:45 +02:00
2019-12-02 18:49:30 -07:00
2019-12-01 06:29:17 -08:00
2019-05-24 20:50:36 +02:00
2019-11-15 14:38:29 +01:00
2019-12-02 14:46:22 -08:00
2019-06-19 17:09:55 +02:00
2019-08-03 07:02:01 -07:00
2019-08-30 19:31:09 -04:00
2019-11-30 10:44:49 -08:00
2019-12-08 11:08:28 -08:00
2019-05-21 10:50:45 +02:00
2019-12-01 06:29:18 -08:00
2019-02-01 15:46:24 -08:00
2019-05-21 10:50:45 +02:00
2019-12-04 19:44:13 -08:00
2019-12-03 12:20:25 -08:00
2019-12-08 11:08:28 -08:00
2019-08-07 21:51:47 -04:00
2019-08-19 11:00:39 -04:00
2019-12-12 19:00:36 +01:00
2019-02-28 03:29:26 -05:00
2019-09-06 21:28:49 +02:00
2019-09-12 21:06:14 -04:00
2019-07-16 22:52:37 -04:00
2019-05-21 10:50:45 +02:00
2019-01-21 17:48:13 +01:00
2019-11-08 13:37:24 -07:00
2019-07-19 10:42:02 -07:00
2019-09-24 15:54:11 -07:00
2019-10-25 14:08:24 -04:00
2019-12-11 16:02:32 -07:00
2019-12-10 16:33:22 -07:00
2019-12-10 16:33:22 -07:00
2019-12-02 14:46:22 -08:00
2019-10-29 12:43:00 -06:00
2019-06-24 09:16:47 +10:00
2019-10-14 15:04:01 -07:00
2019-09-27 17:00:27 -07:00
2019-10-29 12:43:00 -06:00
2019-05-21 10:50:45 +02:00
2019-07-16 22:52:37 -04:00
2019-07-10 09:00:57 -06:00
2019-12-06 09:06:58 -08:00
2019-12-12 14:50:05 +01:00
2019-05-30 11:26:32 -07:00
2019-05-25 18:00:06 -04:00
2019-11-26 11:34:06 -08:00
2019-12-11 11:46:19 -08:00
2019-06-17 17:36:09 -04:00
2019-05-30 11:29:53 -07:00
2019-05-21 10:50:45 +02:00
2019-09-06 21:28:49 +02:00
2019-08-16 18:43:24 -07:00
2019-10-18 18:41:16 -04:00
2019-11-15 14:38:29 +01:00
2019-08-13 16:06:52 -07:00
2019-04-08 18:21:02 -05:00
2019-12-07 13:21:01 -08:00
2019-05-21 10:50:45 +02:00
2019-02-01 01:55:45 -05:00
2019-10-03 14:21:35 -07:00
2019-10-10 08:16:44 -07:00
2019-05-14 09:47:50 -07:00
2019-11-15 14:38:30 +01:00
2019-12-01 20:36:41 -08:00
2019-11-15 14:38:29 +01:00
2019-05-21 10:50:45 +02:00