linux/drivers/staging/ft1000
Kelley Nielsen f3802bdb15 staging: ft1000: flatten nesting in handle_misc_portid
The newly extracted function handle_misc_portid still has several
unnecessary levels of nesting, having inherited its logic from the
original extracted lines. Move handling for failed memory allocation
(of *pdpram_blk) to the top of the function, and return -1 from within
it. This eliminates the if statement around the body of the function.
Change two levels of nested if/else to an if/else-if/else. Create a
label, exit_failure, at the end of the function with the cleanup code,
and goto it at all points of failure. Also, goto it if the call to
ft1000_receive_cmd() fails, instead of descending into an if block if
it succeeds. Pull all lines from inside the former if blocks to the
left, and rejoin lines to take advantage of reclaimed horizontal space.

Signed-off-by: Kelley Nielsen <kelleynnn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10 07:55:00 -08:00
..
ft1000-pcmcia Staging: ft1000: Fix assignment of bool to 0/1 in ft1000_dnld.c 2013-10-28 15:00:35 -07:00
ft1000-usb staging: ft1000: flatten nesting in handle_misc_portid 2013-11-10 07:55:00 -08:00
ft1000.h staging: ft1000: unify struct ft1000_info between USB and PCMCIA drivers 2013-01-07 12:33:45 -08:00
Kconfig
Makefile
TODO