Jani Nikula f212bf9abe drm/i915/bios: filter out invalid DDC pins from VBT child devices ... The VBT contains the DDC pin to use for specific ports. Alas, sometimes the field appears to contain bogus data, and while we check for it later on in intel_gmbus_get_adapter() we fail to check the returned NULL on errors. Oops results. The simplest approach seems to be to catch and ignore the bogus DDC pins already at the VBT parsing phase, reverting to fixed per port default pins. This doesn't guarantee display working, but at least it prevents the oops. And we continue to be fuzzed by VBT. One affected machine is Dell Latitude 5590 where a BIOS upgrade added invalid DDC pins. Typical backtrace: [ 35.461411] WARN_ON(!intel_gmbus_is_valid_pin(dev_priv, pin)) [ 35.461432] WARNING: CPU: 6 PID: 411 at drivers/gpu/drm/i915/intel_i2c.c:844 intel_gmbus_get_adapter+0x32/0x37 [i915] [ 35.461437] Modules linked in: i915 ahci libahci dm_snapshot dm_bufio dm_raid raid456 async_raid6_recov async_pq raid6_pq async_xor xor async_memcpy async_tx [ 35.461445] CPU: 6 PID: 411 Comm: kworker/u16:2 Not tainted 4.16.0-rc7.x64-g1cda370ffded #1 [ 35.461447] Hardware name: Dell Inc. Latitude 5590/0MM81M, BIOS 1.1.9 03/13/2018 [ 35.461450] Workqueue: events_unbound async_run_entry_fn [ 35.461465] RIP: 0010:intel_gmbus_get_adapter+0x32/0x37 [i915] [ 35.461467] RSP: 0018:ffff9b4e43d47c40 EFLAGS: 00010286 [ 35.461469] RAX: 0000000000000000 RBX: ffff98f90639f800 RCX: ffffffffae051960 [ 35.461471] RDX: 0000000000000001 RSI: 0000000000000092 RDI: 0000000000000246 [ 35.461472] RBP: ffff98f905410000 R08: 0000004d062a83f6 R09: 00000000000003bd [ 35.461474] R10: 0000000000000031 R11: ffffffffad4eda58 R12: ffff98f905410000 [ 35.461475] R13: ffff98f9064c1000 R14: ffff9b4e43d47cf0 R15: ffff98f905410000 [ 35.461477] FS: 0000000000000000(0000) GS:ffff98f92e580000(0000) knlGS:0000000000000000 [ 35.461479] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 35.461481] CR2: 00007f5682359008 CR3: 00000001b700c005 CR4: 00000000003606e0 [ 35.461483] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 35.461484] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 35.461486] Call Trace: [ 35.461501] intel_hdmi_set_edid+0x37/0x27f [i915] [ 35.461515] intel_hdmi_detect+0x7c/0x97 [i915] [ 35.461518] drm_helper_probe_single_connector_modes+0xe1/0x6c0 [ 35.461521] drm_setup_crtcs+0x129/0xa6a [ 35.461523] ? __switch_to_asm+0x34/0x70 [ 35.461525] ? __switch_to_asm+0x34/0x70 [ 35.461527] ? __switch_to_asm+0x40/0x70 [ 35.461528] ? __switch_to_asm+0x34/0x70 [ 35.461529] ? __switch_to_asm+0x40/0x70 [ 35.461531] ? __switch_to_asm+0x34/0x70 [ 35.461532] ? __switch_to_asm+0x40/0x70 [ 35.461534] ? __switch_to_asm+0x34/0x70 [ 35.461536] __drm_fb_helper_initial_config_and_unlock+0x34/0x46f [ 35.461538] ? __switch_to_asm+0x40/0x70 [ 35.461541] ? _cond_resched+0x10/0x33 [ 35.461557] intel_fbdev_initial_config+0xf/0x1c [i915] [ 35.461560] async_run_entry_fn+0x2e/0xf5 [ 35.461563] process_one_work+0x15b/0x364 [ 35.461565] worker_thread+0x2c/0x3a0 [ 35.461567] ? process_one_work+0x364/0x364 [ 35.461568] kthread+0x10c/0x122 [ 35.461570] ? _kthread_create_on_node+0x5d/0x5d [ 35.461572] ret_from_fork+0x35/0x40 [ 35.461574] Code: 74 16 89 f6 48 8d 04 b6 48 c1 e0 05 48 29 f0 48 8d 84 c7 e8 11 00 00 c3 48 c7 c6 b0 19 1e c0 48 c7 c7 64 8a 1c c0 e8 47 88 ed ec <0f> 0b 31 c0 c3 8b 87 a4 04 00 00 80 e4 fc 09 c6 89 b7 a4 04 00 [ 35.461604] WARNING: CPU: 6 PID: 411 at drivers/gpu/drm/i915/intel_i2c.c:844 intel_gmbus_get_adapter+0x32/0x37 [i915] [ 35.461606] ---[ end trace 4fe1e63e2dd93373 ]--- [ 35.461609] BUG: unable to handle kernel NULL pointer dereference at 0000000000000010 [ 35.461613] IP: i2c_transfer+0x4/0x86 [ 35.461614] PGD 0 P4D 0 [ 35.461616] Oops: 0000 [#1] SMP PTI [ 35.461618] Modules linked in: i915 ahci libahci dm_snapshot dm_bufio dm_raid raid456 async_raid6_recov async_pq raid6_pq async_xor xor async_memcpy async_tx [ 35.461624] CPU: 6 PID: 411 Comm: kworker/u16:2 Tainted: G W 4.16.0-rc7.x64-g1cda370ffded #1 [ 35.461625] Hardware name: Dell Inc. Latitude 5590/0MM81M, BIOS 1.1.9 03/13/2018 [ 35.461628] Workqueue: events_unbound async_run_entry_fn [ 35.461630] RIP: 0010:i2c_transfer+0x4/0x86 [ 35.461631] RSP: 0018:ffff9b4e43d47b30 EFLAGS: 00010246 [ 35.461633] RAX: ffff9b4e43d47b6e RBX: 0000000000000005 RCX: 0000000000000001 [ 35.461635] RDX: 0000000000000002 RSI: ffff9b4e43d47b80 RDI: 0000000000000000 [ 35.461636] RBP: ffff9b4e43d47bd8 R08: 0000004d062a83f6 R09: 00000000000003bd [ 35.461638] R10: 0000000000000031 R11: ffffffffad4eda58 R12: 0000000000000002 [ 35.461639] R13: 0000000000000001 R14: ffff9b4e43d47b6f R15: ffff9b4e43d47c07 [ 35.461641] FS: 0000000000000000(0000) GS:ffff98f92e580000(0000) knlGS:0000000000000000 [ 35.461643] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 35.461645] CR2: 0000000000000010 CR3: 00000001b700c005 CR4: 00000000003606e0 [ 35.461646] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 35.461647] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 35.461649] Call Trace: [ 35.461652] drm_do_probe_ddc_edid+0xb3/0x128 [ 35.461654] drm_get_edid+0xe5/0x38d [ 35.461669] intel_hdmi_set_edid+0x45/0x27f [i915] [ 35.461684] intel_hdmi_detect+0x7c/0x97 [i915] [ 35.461687] drm_helper_probe_single_connector_modes+0xe1/0x6c0 [ 35.461689] drm_setup_crtcs+0x129/0xa6a [ 35.461691] ? __switch_to_asm+0x34/0x70 [ 35.461693] ? __switch_to_asm+0x34/0x70 [ 35.461694] ? __switch_to_asm+0x40/0x70 [ 35.461696] ? __switch_to_asm+0x34/0x70 [ 35.461697] ? __switch_to_asm+0x40/0x70 [ 35.461698] ? __switch_to_asm+0x34/0x70 [ 35.461700] ? __switch_to_asm+0x40/0x70 [ 35.461701] ? __switch_to_asm+0x34/0x70 [ 35.461703] __drm_fb_helper_initial_config_and_unlock+0x34/0x46f [ 35.461705] ? __switch_to_asm+0x40/0x70 [ 35.461707] ? _cond_resched+0x10/0x33 [ 35.461724] intel_fbdev_initial_config+0xf/0x1c [i915] [ 35.461727] async_run_entry_fn+0x2e/0xf5 [ 35.461729] process_one_work+0x15b/0x364 [ 35.461731] worker_thread+0x2c/0x3a0 [ 35.461733] ? process_one_work+0x364/0x364 [ 35.461734] kthread+0x10c/0x122 [ 35.461736] ? _kthread_create_on_node+0x5d/0x5d [ 35.461738] ret_from_fork+0x35/0x40 [ 35.461739] Code: 5c fa e1 ad 48 89 df e8 ea fb ff ff e9 2a ff ff ff 0f 1f 44 00 00 31 c0 e9 43 fd ff ff 31 c0 45 31 e4 e9 c5 fd ff ff 41 54 55 53 <48> 8b 47 10 48 83 78 10 00 74 70 41 89 d4 48 89 f5 48 89 fb 65 [ 35.461756] RIP: i2c_transfer+0x4/0x86 RSP: ffff9b4e43d47b30 [ 35.461757] CR2: 0000000000000010 [ 35.461759] ---[ end trace 4fe1e63e2dd93374 ]--- Based on a patch by Fei Li. v2: s/reverting/sticking/ (Chris) Cc: stable@vger.kernel.org Cc: Fei Li <fei.li@intel.com> Co-developed-by: Fei Li <fei.li@intel.com> Reported-by: Pavel Nakonechnyi <zorg1331@gmail.com> Reported-and-tested-by: Seweryn Kokot <sewkokot@gmail.com> Reported-and-tested-by: Laszlo Valko <valko@linux.karinthy.hu> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105549 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105961 Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Jani Nikula <jani.nikula@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20180411131519.9091-1-jani.nikula@intel.com		2018-04-12 11:22:07 +03:00
..
accessibility
acpi	Merge branch 'libnvdimm-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm	2018-03-22 18:37:49 -07:00
amba
android	ANDROID: binder: synchronize_rcu() when using POLLFREE.	2018-02-16 11:16:38 +01:00
ata	libata: Modify quirks for MX100 to limit NCQ_TRIM quirk to MU01 version	2018-03-19 08:36:38 -07:00
atm	atm: he: use 64-bit arithmetic instead of 32-bit	2018-02-08 15:05:16 -05:00
auxdisplay	auxdisplay: img-ascii-lcd: Silence 2 uninitialized warnings	2018-03-13 18:16:38 +01:00
base	ACPI updates for v4.16-rc2	2018-02-15 14:50:32 -08:00
bcma
block	loop: Fix lost writes caused by missing flag	2018-03-09 08:36:36 -07:00
bluetooth	Bluetooth: hci_bcm: Set pulsed_host_wake flag in sleep parameters	2018-03-15 19:39:37 +01:00
bus	bus: ti-sysc: Fix checking of no-reset-on-init quirk	2018-02-15 09:18:55 -08:00
cdrom
char	tpm: fix potential buffer overruns caused by bit glitches on the bus	2018-02-26 15:43:46 -08:00
clk	clk: bcm2835: Protect sections updating shared registers	2018-03-19 09:27:37 -07:00
clocksource	clocksource/atmel-st: Add 'depends on HAS_IOMEM' to fix unmet dependency	2018-03-09 11:11:58 +01:00
connector
cpufreq	Merge branch 'cpufreq-scpi'	2018-03-02 10:44:44 +01:00
cpuidle	powerpc updates for 4.16	2018-02-02 10:01:04 -08:00
crypto	s390:	2018-02-26 09:28:35 -08:00
dax	dax: ->direct_access does not sleep anymore	2018-02-26 12:32:29 -08:00
dca
devfreq
dio
dma	dmaengine: stm32-dmamux: fix a potential buffer overflow	2018-03-22 10:51:35 +05:30
dma-buf	dma-buf/sw_sync: Fix kerneldoc warnings	2018-02-19 10:50:49 +01:00
edac	EDAC, sb_edac: Fix out of bound writes during DIMM configuration on KNL	2018-02-23 12:05:37 +01:00
eisa
extcon	extcon: int3496: process id-pin first so that we start with the right status	2018-02-14 06:37:33 +09:00
firewire	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
firmware	Merge branch 'efi-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-03-18 11:56:53 -07:00
fmc
fpga
fsi
gpio	gpio: rcar: Use wakeup_path i.s.o. explicit clock handling	2018-03-05 09:01:21 +01:00
gpu	drm/i915/bios: filter out invalid DDC pins from VBT child devices	2018-04-12 11:22:07 +03:00
hid	usb: ldusb: add PIDs for new CASSY devices supported by this driver	2018-02-15 18:44:03 +01:00
hsi	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
hv	Drivers: hv: vmbus: Fix ring buffer signaling	2018-03-06 09:52:59 -08:00
hwmon	Fix bad temperature display on Ryzen/Threadripper	2018-02-15 14:31:28 -08:00
hwspinlock
hwtracing	Char/Misc driver patches for 4.16-rc1	2018-02-01 10:31:17 -08:00
i2c	i2c: octeon: Prevent error message on bus error	2018-03-02 11:11:15 +01:00
ide	genhd: Rename get_disk() to get_disk_and_module()	2018-02-26 09:48:42 -07:00
idle
iio	iio: st_pressure: st_accel: pass correct platform data to init	2018-03-10 16:28:05 +00:00
infiniband	Fourth pull request for 4.16-rc	2018-03-20 17:39:07 -07:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2018-03-07 17:37:32 -08:00
iommu	treewide/trivial: Remove ';;$' typo noise	2018-02-22 10:59:33 +01:00
ipack
irqchip	irqchip/irq-imx-gpcv2: Remove unused function	2018-03-11 13:27:12 +00:00
isdn	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
leds	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
lightnvm
macintosh	powerpc/macio: set a proper dma_coherent_mask	2018-02-13 08:58:53 -08:00
mailbox	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
mcb
md	dm mpath: fix passing integrity data	2018-03-14 15:39:33 -04:00
media	media: dvb: fix a Kconfig typo	2018-03-05 07:57:41 -05:00
memory	memory: brcmstb: dpfe: support new way of passing data from the DCPU	2018-02-23 10:56:59 -08:00
memstick
message	scsi: mptfusion: Add bounds check in mptctl_hp_targetinfo()	2018-01-30 21:32:06 -05:00
mfd	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
misc	powerpc fixes for 4.16 #5	2018-03-09 09:33:48 -08:00
mmc	mmc: sdhci-acpi: Fix IRQ 0	2018-03-21 11:10:20 +01:00
mtd	mtd: nand: fsl_ifc: Read ECCSTAT0 and ECCSTAT1 registers for IFC 2.0	2018-03-21 10:22:28 +01:00
mux	Char/Misc driver patches for 4.16-rc1	2018-02-01 10:31:17 -08:00
net	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-03-22 14:10:29 -07:00
nfc
ntb	NTB: ntb_perf: fix cast to restricted __le32	2018-01-28 22:17:24 -05:00
nubus
nvdimm	libnvdimm, nfit: fix persistence domain reporting	2018-03-21 15:12:07 -07:00
nvme	nvme_fc: rework sqsize handling	2018-03-08 10:39:58 -07:00
nvmem
of	Linux 4.16-rc7	2018-03-28 14:30:41 +10:00
opp	opp: cpu: Replace GFP_ATOMIC with GFP_KERNEL in dev_pm_opp_init_cpufreq_table	2018-02-12 15:07:46 +05:30
oprofile
parisc
parport
pci	Linux 4.16-rc7	2018-03-28 14:30:41 +10:00
pcmcia	Merge branch 'pcmcia' of git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia	2018-02-08 11:48:49 -08:00
perf	arm_pmu: Use disable_irq_nosync when disabling SPI in CPU teardown hook	2018-02-28 14:59:47 +00:00
phy	phy: qcom-ufs: add MODULE_LICENSE tag	2018-03-12 15:11:59 +05:30
pinctrl	pinctrl: samsung: Validate alias coming from DT	2018-03-08 13:02:26 +01:00
platform	platform-drivers-x86 for v4.16-7	2018-03-14 13:01:14 -07:00
pnp
power	power supply and reset changes for the v4.16 series	2018-01-31 12:55:31 -08:00
powercap
pps	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
ps3
ptp	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
pwm
rapidio	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
ras
regulator	Merge remote-tracking branches 'regulator/fix/resume' and 'regulator/fix/stm32-vfrefbuf' into regulator-linus	2018-03-07 14:39:07 +00:00
remoteproc	remoteproc updates for v4.16	2018-02-05 10:07:40 -08:00
reset
rpmsg	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
rtc	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
s390	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-03-22 14:10:29 -07:00
sbus	pci-v4.16-changes	2018-02-06 09:59:40 -08:00
scsi	SCSI fixes on 20180320	2018-03-20 16:59:01 -07:00
sfi
sh	cpufreq: Add and use cpufreq_for_each_{valid_,}entry_idx()	2018-02-08 10:21:39 +01:00
siox
slimbus
sn
soc	soc/fsl/qbman: fix issue in qman_delete_cgr_safe()	2018-03-14 13:16:23 -04:00
soundwire
spi	Merge remote-tracking branch 'spi/topic/xilinx' into spi-next	2018-01-26 17:57:34 +00:00
spmi
ssb	Merge git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git	2018-02-01 10:37:39 +02:00
staging	Linux 4.16-rc7	2018-03-28 14:30:41 +10:00
target	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending	2018-02-09 14:49:46 -08:00
tc
tee
thermal	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux	2018-02-06 15:04:58 -08:00
thunderbolt
tty	tty: vt: fix up tabstops properly	2018-03-25 07:04:00 -10:00
uio	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
usb	usb: musb: Fix external abort in musb_remove on omap2430	2018-03-13 16:36:59 +01:00
uwb
vfio	Revert: "vfio-pci: Mask INTx if a device is not capabable of enabling it"	2018-03-21 22:50:19 -06:00
vhost	vhost_net: examine pointer types during un-producing	2018-03-09 12:02:59 -05:00
video	Linux 4.16-rc7	2018-03-28 14:30:41 +10:00
virt	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
virtio	virtio_ring: fix num_free handling in error case	2018-03-01 18:53:38 +02:00
visorbus
vlynq
vme
w1	Documentation updates for 4.16. New stuff includes refcount_t	2018-01-31 19:25:25 -08:00
watchdog	ACPI / watchdog: Fix off-by-one error at resource assignment	2018-03-19 23:17:07 +01:00
xen	xen: fix for V4.16-rc5	2018-03-09 16:54:18 -08:00
zorro
Kconfig	Char/Misc driver patches for 4.16-rc1	2018-02-01 10:31:17 -08:00
Makefile	pci-v4.16-changes	2018-02-06 09:59:40 -08:00