linux/drivers/net/wireless
Julia Lawall f201a8a451 drivers/net/usb: use USB API functions rather than constants
This set of patches introduces calls to the following set of functions:

usb_endpoint_dir_in(epd)
usb_endpoint_dir_out(epd)
usb_endpoint_is_bulk_in(epd)
usb_endpoint_is_bulk_out(epd)
usb_endpoint_is_int_in(epd)
usb_endpoint_is_int_out(epd)
usb_endpoint_num(epd)
usb_endpoint_type(epd)
usb_endpoint_xfer_bulk(epd)
usb_endpoint_xfer_control(epd)
usb_endpoint_xfer_int(epd)
usb_endpoint_xfer_isoc(epd)

In some cases, introducing one of these functions is not possible, and it
just replaces an explicit integer value by one of the following constants:

USB_ENDPOINT_XFER_BULK
USB_ENDPOINT_XFER_CONTROL
USB_ENDPOINT_XFER_INT
USB_ENDPOINT_XFER_ISOC

In drivers/net/wireless/zd1211rw/zd_usb.c the code:

(endpoint->bEndpointAddress & USB_TYPE_MASK) == USB_DIR_OUT

is suspicious.  If it is intended to use USB_ENDPOINT_DIR_MASK rather than
USB_TYPE_MASK, then the whole conditional test could be converted to a call
to usb_endpoint_is_bulk_in.

An extract of the semantic patch that makes these changes is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r1@ struct usb_endpoint_descriptor *epd; @@

- ((epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) ==
- \(USB_ENDPOINT_XFER_CONTROL\|0\))
+ usb_endpoint_xfer_control(epd)

@r5@ struct usb_endpoint_descriptor *epd; @@

- ((epd->bEndpointAddress & \(USB_ENDPOINT_DIR_MASK\|0x80\)) ==
-  \(USB_DIR_IN\|0x80\))
+ usb_endpoint_dir_in(epd)

@inc@
@@

#include <linux/usb.h>

@depends on !inc && (r1||r5)@
@@

+ #include <linux/usb.h>
  #include <linux/usb/...>
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-12-29 19:40:47 -08:00
..
ath5k ath5k: correct packet length in tx descriptors 2008-12-19 15:24:02 -05:00
ath9k drivers/net/wireless/ath9k: fix sparse warnings: make symbols static 2008-12-26 00:13:29 -08:00
b43 drivers/net/wireless/b43: fix sparse warnings: make symbols static 2008-12-26 00:13:46 -08:00
b43legacy b43legacy: Fix sparse warnings 2008-12-12 14:02:08 -05:00
hostap hostap: select required crypto bits in Kconfig 2008-12-05 09:32:10 -05:00
ipw2x00 drivers/net/wireless/ipw2x00: fix sparse warnings: make symbols static 2008-12-26 00:14:41 -08:00
iwlwifi iwlwifi: iwl-tx.c cleanup (remove unused parameter and unused local variable). 2008-12-19 15:23:54 -05:00
libertas libertas: use roundup instead of opencoding 2008-12-19 15:23:14 -05:00
libertas_tf libertas_tf: fix skb tail pointer 2008-11-18 17:26:26 -05:00
orinoco spectrum_cs: Fix function names used in debug strings 2008-12-12 14:02:02 -05:00
p54 p54usb: bring first generation devices back to life 2008-12-19 15:23:47 -05:00
prism54 drivers/net/wireless/prism54: fix sparse warnings: make symbols static 2008-12-26 00:15:03 -08:00
rt2x00 rt2x00: Correctly initialize AID during set_key() 2008-12-05 09:35:57 -05:00
rtl818x rtl8187: Fix crash on unload when using SLUB debug 2008-12-19 15:23:20 -05:00
zd1211rw drivers/net/usb: use USB API functions rather than constants 2008-12-29 19:40:47 -08:00
adm8211.c adm8211: remove SSID code 2008-11-10 15:11:56 -05:00
adm8211.h adm8211: remove SSID code 2008-11-10 15:11:56 -05:00
airo_cs.c
airo.c drivers/net/wireless: fix sparse warnings: make symbols static 2008-12-26 00:12:59 -08:00
airo.h
arlan-main.c drivers/net: Kill now superfluous ->last_rx stores. 2008-11-03 21:11:17 -08:00
arlan-proc.c
arlan.h
atmel_cs.c
atmel_pci.c
atmel.c drivers/net/wireless: fix sparse warnings: make symbols static 2008-12-26 00:12:59 -08:00
atmel.h
i82586.h
i82593.h
Kconfig orinoco: Provide option to avoid unnecessary fw caching 2008-11-26 09:47:47 -05:00
mac80211_hwsim.c mac80211: Fix HT channel selection 2008-12-19 15:22:54 -05:00
Makefile ipw2x00: relocate ipw2100/ipw2200 to common directory 2008-11-21 11:08:17 -05:00
netwave_cs.c drivers/net: Kill now superfluous ->last_rx stores. 2008-11-03 21:11:17 -08:00
ray_cs.c drivers/net/wireless: fix sparse warnings: make symbols static 2008-12-26 00:12:59 -08:00
ray_cs.h
rayctl.h
rndis_wlan.c netdevice: safe convert to netdev_priv() #part-4 2008-11-12 23:39:10 -08:00
strip.c netdevice: Kill netdev->priv 2008-12-08 01:14:16 -08:00
wavelan_cs.c drivers/net: Kill now superfluous ->last_rx stores. 2008-11-03 21:11:17 -08:00
wavelan_cs.h
wavelan_cs.p.h
wavelan.c netdevice: safe convert to netdev_priv() #part-4 2008-11-12 23:39:10 -08:00
wavelan.h
wavelan.p.h net: Rationalise email address: Network Specific Parts 2008-10-13 19:01:08 -07:00
wl3501_cs.c drivers/net: Kill now superfluous ->last_rx stores. 2008-11-03 21:11:17 -08:00
wl3501.h don't use net/ieee80211.h 2008-11-10 15:11:56 -05:00
zd1201.c netdevice zd1201: Use after free 2008-12-18 22:27:38 -08:00
zd1201.h