forked from Minki/linux
97d9d23dda
If a struct contains 64-bit fields, it is aligned on 64-bit boundaries within containing structs in 64-bit compilations. This is the case with struct v4l2_window, which contains pointers and is embedded into struct v4l2_format, and that one is embedded into struct v4l2_create_buffers. Unlike some other structs, used as a part of the kernel ABI as ioctl() arguments, that are packed, these structs aren't packed. This isn't a problem per se, but the ioctl-compat code for VIDIOC_CREATE_BUFS contains a bug, that triggers in such 64-bit builds. That code wrongly assumes, that in struct v4l2_create_buffers, struct v4l2_format immediately follows the __u32 memory field, which in fact isn't the case. This bug wasn't visible until now, because until recently hardly any applications used this ioctl() and mostly embedded 32-bit only drivers implemented it. This is changing now with addition of this ioctl() to some USB drivers, e.g. UVC. This patch fixes the bug by copying parts of struct v4l2_create_buffers separately. Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com> Cc: stable@vger.kernel.org |
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| tuner-core.c | ||
| v4l2-async.c | ||
| v4l2-clk.c | ||
| v4l2-common.c | ||
| v4l2-compat-ioctl32.c | ||
| v4l2-ctrls.c | ||
| v4l2-dev.c | ||
| v4l2-device.c | ||
| v4l2-dv-timings.c | ||
| v4l2-event.c | ||
| v4l2-fh.c | ||
| v4l2-ioctl.c | ||
| v4l2-mem2mem.c | ||
| v4l2-of.c | ||
| v4l2-subdev.c | ||
| videobuf2-core.c | ||
| videobuf2-dma-contig.c | ||
| videobuf2-dma-sg.c | ||
| videobuf2-memops.c | ||
| videobuf2-vmalloc.c | ||
| videobuf-core.c | ||
| videobuf-dma-contig.c | ||
| videobuf-dma-sg.c | ||
| videobuf-dvb.c | ||
| videobuf-vmalloc.c | ||