forked from Minki/linux
5045ea3737
__kernel_get_syscall_map() and __kernel_clock_getres() use cmpli to
check if the passed in pointer is non zero. cmpli maps to a 32 bit
compare on binutils, so we ignore the top 32 bits.
A simple test case can be created by passing in a bogus pointer with
the bottom 32 bits clear. Using a clk_id that is handled by the VDSO,
then one that is handled by the kernel shows the problem:
printf("%d\n", clock_getres(CLOCK_REALTIME, (void *)0x100000000));
printf("%d\n", clock_getres(CLOCK_BOOTTIME, (void *)0x100000000));
And we get:
0
-1
The bigger issue is if we pass a valid pointer with the bottom 32 bits
clear, in this case we will return success but won't write any data
to the pointer.
I stumbled across this issue because the LLVM integrated assembler
doesn't accept cmpli with 3 arguments. Fix this by converting them to
cmpldi.
Fixes: a7f290dad3 ("[PATCH] powerpc: Merge vdso's and add vdso support to 32 bits kernel")
Cc: stable@vger.kernel.org # v2.6.15+
Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
88 lines
2.0 KiB
ArmAsm
88 lines
2.0 KiB
ArmAsm
/*
|
|
* Access to the shared data page by the vDSO & syscall map
|
|
*
|
|
* Copyright (C) 2004 Benjamin Herrenschmuidt (benh@kernel.crashing.org), IBM Corp.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version
|
|
* 2 of the License, or (at your option) any later version.
|
|
*/
|
|
|
|
#include <asm/processor.h>
|
|
#include <asm/ppc_asm.h>
|
|
#include <asm/asm-offsets.h>
|
|
#include <asm/unistd.h>
|
|
#include <asm/vdso.h>
|
|
|
|
.text
|
|
.global __kernel_datapage_offset;
|
|
__kernel_datapage_offset:
|
|
.long 0
|
|
|
|
V_FUNCTION_BEGIN(__get_datapage)
|
|
.cfi_startproc
|
|
/* We don't want that exposed or overridable as we want other objects
|
|
* to be able to bl directly to here
|
|
*/
|
|
.protected __get_datapage
|
|
.hidden __get_datapage
|
|
|
|
mflr r0
|
|
.cfi_register lr,r0
|
|
|
|
bcl 20,31,data_page_branch
|
|
data_page_branch:
|
|
mflr r3
|
|
mtlr r0
|
|
addi r3, r3, __kernel_datapage_offset-data_page_branch
|
|
lwz r0,0(r3)
|
|
add r3,r0,r3
|
|
blr
|
|
.cfi_endproc
|
|
V_FUNCTION_END(__get_datapage)
|
|
|
|
/*
|
|
* void *__kernel_get_syscall_map(unsigned int *syscall_count) ;
|
|
*
|
|
* returns a pointer to the syscall map. the map is agnostic to the
|
|
* size of "long", unlike kernel bitops, it stores bits from top to
|
|
* bottom so that memory actually contains a linear bitmap
|
|
* check for syscall N by testing bit (0x80000000 >> (N & 0x1f)) of
|
|
* 32 bits int at N >> 5.
|
|
*/
|
|
V_FUNCTION_BEGIN(__kernel_get_syscall_map)
|
|
.cfi_startproc
|
|
mflr r12
|
|
.cfi_register lr,r12
|
|
mr r4,r3
|
|
bl V_LOCAL_FUNC(__get_datapage)
|
|
mtlr r12
|
|
addi r3,r3,CFG_SYSCALL_MAP64
|
|
cmpldi cr0,r4,0
|
|
crclr cr0*4+so
|
|
beqlr
|
|
li r0,NR_syscalls
|
|
stw r0,0(r4)
|
|
blr
|
|
.cfi_endproc
|
|
V_FUNCTION_END(__kernel_get_syscall_map)
|
|
|
|
|
|
/*
|
|
* void unsigned long __kernel_get_tbfreq(void);
|
|
*
|
|
* returns the timebase frequency in HZ
|
|
*/
|
|
V_FUNCTION_BEGIN(__kernel_get_tbfreq)
|
|
.cfi_startproc
|
|
mflr r12
|
|
.cfi_register lr,r12
|
|
bl V_LOCAL_FUNC(__get_datapage)
|
|
ld r3,CFG_TB_TICKS_PER_SEC(r3)
|
|
mtlr r12
|
|
crclr cr0*4+so
|
|
blr
|
|
.cfi_endproc
|
|
V_FUNCTION_END(__kernel_get_tbfreq)
|