leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity
ebde6f8acb
linux/drivers/net/vmxnet3
History
Thomas Jarosch ebde6f8acb vmxnet3: Fix inconsistent LRO state after initialization 
During initialization of vmxnet3, the state of LRO
gets out of sync with netdev->features.

This leads to very poor TCP performance in a IP forwarding
setup and is hitting many VMware users.

Simplified call sequence:
1. vmxnet3_declare_features() initializes "adapter->lro" to true.

2. The kernel automatically disables LRO if IP forwarding is enabled,
so vmxnet3_set_flags() gets called. This also updates netdev->features.

3. Now vmxnet3_setup_driver_shared() is called. "adapter->lro" is still
set to true and LRO gets enabled again, even though
netdev->features shows it's disabled.

Fix it by updating "adapter->lro", too.

The private vmxnet3 adapter flags are scheduled for removal
in net-next, see commit a0d2730c95
"net: vmxnet3: convert to hw_features".

Patch applies to 2.6.37 / 2.6.38 and 2.6.39-rc6.

Please CC: comments.

Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2011-05-16 15:05:23 -04:00
..
Makefile
upt1_defs.h vmxnet3: remove set_flag_le{16,64} helpers 2010-10-24 15:52:31 -07:00
vmxnet3_defs.h vmxnet3: remove set_flag_le{16,64} helpers 2010-10-24 15:52:31 -07:00
vmxnet3_drv.c vmxnet3: Consistently disable irqs when taking adapter->cmd_lock 2011-05-06 13:11:57 -07:00
vmxnet3_ethtool.c vmxnet3: Fix inconsistent LRO state after initialization 2011-05-16 15:05:23 -04:00
vmxnet3_int.h vmxnet3: Dont allocate extra MSI-x vectors 2011-01-15 21:21:14 -08:00