forked from Minki/linux
fd45e47841
When we search for and find a busy extent during allocation we force the log out to ensure the extent free transaction is on disk before the allocation transaction. The current implementation has a subtle bug in it--it does not handle multiple overlapping ranges. That is, if we free lots of little extents into a single contiguous extent, then allocate the contiguous extent, the busy search code stops searching at the first extent it finds that overlaps the allocated range. It then uses the commit LSN of the transaction to force the log out to. Unfortunately, the other busy ranges might have more recent commit LSNs than the first busy extent that is found, and this results in xfs_alloc_search_busy() returning before all the extent free transactions are on disk for the range being allocated. This can lead to potential metadata corruption or stale data exposure after a crash because log replay won't replay all the extent free transactions that cover the allocation range. Modified-by: Alex Elder <aelder@sgi.com> (Dropped the "found" argument from the xfs_alloc_busysearch trace event.) Signed-off-by: Dave Chinner <david@fromorbit.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Alex Elder <aelder@sgi.com> |
||
|---|---|---|
| .. | ||
| kmem.c | ||
| kmem.h | ||
| mrlock.h | ||
| sv.h | ||
| time.h | ||
| xfs_acl.c | ||
| xfs_aops.c | ||
| xfs_aops.h | ||
| xfs_buf.c | ||
| xfs_buf.h | ||
| xfs_cred.h | ||
| xfs_dmapi_priv.h | ||
| xfs_export.c | ||
| xfs_export.h | ||
| xfs_file.c | ||
| xfs_fs_subr.c | ||
| xfs_fs_subr.h | ||
| xfs_globals.c | ||
| xfs_globals.h | ||
| xfs_ioctl32.c | ||
| xfs_ioctl32.h | ||
| xfs_ioctl.c | ||
| xfs_ioctl.h | ||
| xfs_iops.c | ||
| xfs_iops.h | ||
| xfs_linux.h | ||
| xfs_lrw.c | ||
| xfs_lrw.h | ||
| xfs_quotaops.c | ||
| xfs_stats.c | ||
| xfs_stats.h | ||
| xfs_super.c | ||
| xfs_super.h | ||
| xfs_sync.c | ||
| xfs_sync.h | ||
| xfs_sysctl.c | ||
| xfs_sysctl.h | ||
| xfs_trace.c | ||
| xfs_trace.h | ||
| xfs_version.h | ||
| xfs_vnode.h | ||
| xfs_xattr.c | ||