2da185d6fe
The addition of MT8183 support added a dependency on the SCP remoteproc
module. However the initial patch used the "select" Kconfig directive,
which may result in the SCP module to not be compiled if remoteproc was
disabled. In such a case, mtk-vcodec would try to link against
non-existent SCP symbols. "select" was clearly misused here as explained
in kconfig-language.txt.
Replace this by a "depends" directive on at least one of the VPU and
SCP modules, to allow the driver to be compiled as long as one of these
is enabled, and adapt the code to support this new scenario.
Also adapt the Kconfig text to explain the extra requirements for MT8173
and MT8183.
Reported-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Fixes: bf1d556ad4 ("media: mtk-vcodec: abstract firmware interface")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
53 lines
1.5 KiB
C
53 lines
1.5 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
|
|
#ifndef _MTK_VCODEC_FW_PRIV_H_
|
|
#define _MTK_VCODEC_FW_PRIV_H_
|
|
|
|
#include "mtk_vcodec_fw.h"
|
|
|
|
struct mtk_vcodec_dev;
|
|
|
|
struct mtk_vcodec_fw {
|
|
enum mtk_vcodec_fw_type type;
|
|
const struct mtk_vcodec_fw_ops *ops;
|
|
struct platform_device *pdev;
|
|
struct mtk_scp *scp;
|
|
};
|
|
|
|
struct mtk_vcodec_fw_ops {
|
|
int (*load_firmware)(struct mtk_vcodec_fw *fw);
|
|
unsigned int (*get_vdec_capa)(struct mtk_vcodec_fw *fw);
|
|
unsigned int (*get_venc_capa)(struct mtk_vcodec_fw *fw);
|
|
void *(*map_dm_addr)(struct mtk_vcodec_fw *fw, u32 dtcm_dmem_addr);
|
|
int (*ipi_register)(struct mtk_vcodec_fw *fw, int id,
|
|
mtk_vcodec_ipi_handler handler, const char *name,
|
|
void *priv);
|
|
int (*ipi_send)(struct mtk_vcodec_fw *fw, int id, void *buf,
|
|
unsigned int len, unsigned int wait);
|
|
void (*release)(struct mtk_vcodec_fw *fw);
|
|
};
|
|
|
|
#if IS_ENABLED(CONFIG_VIDEO_MEDIATEK_VCODEC_VPU)
|
|
struct mtk_vcodec_fw *mtk_vcodec_fw_vpu_init(struct mtk_vcodec_dev *dev,
|
|
enum mtk_vcodec_fw_use fw_use);
|
|
#else
|
|
static inline struct mtk_vcodec_fw *
|
|
mtk_vcodec_fw_vpu_init(struct mtk_vcodec_dev *dev,
|
|
enum mtk_vcodec_fw_use fw_use)
|
|
{
|
|
return ERR_PTR(-ENODEV);
|
|
}
|
|
#endif /* CONFIG_VIDEO_MEDIATEK_VCODEC_VPU */
|
|
|
|
#if IS_ENABLED(CONFIG_VIDEO_MEDIATEK_VCODEC_SCP)
|
|
struct mtk_vcodec_fw *mtk_vcodec_fw_scp_init(struct mtk_vcodec_dev *dev);
|
|
#else
|
|
static inline struct mtk_vcodec_fw *
|
|
mtk_vcodec_fw_scp_init(struct mtk_vcodec_dev *dev)
|
|
{
|
|
return ERR_PTR(-ENODEV);
|
|
}
|
|
#endif /* CONFIG_VIDEO_MEDIATEK_VCODEC_SCP */
|
|
|
|
#endif /* _MTK_VCODEC_FW_PRIV_H_ */
|