Josh Poimboeuf e6f393bc93 objtool: Fix function fallthrough detection ... When a function falls through to the next function due to a compiler bug, objtool prints some obscure warnings. For example: drivers/regulator/core.o: warning: objtool: regulator_count_voltages()+0x95: return with modified stack frame drivers/regulator/core.o: warning: objtool: regulator_count_voltages()+0x0: stack state mismatch: cfa1=7+32 cfa2=7+8 Instead it should be printing: drivers/regulator/core.o: warning: objtool: regulator_supply_is_couple() falls through to next function regulator_count_voltages() This used to work, but was broken by the following commit: 13810435b9 ("objtool: Support GCC 8's cold subfunctions") The padding nops at the end of a function aren't actually part of the function, as defined by the symbol table. So the 'func' variable in validate_branch() is getting cleared to NULL when a padding nop is encountered, breaking the fallthrough detection. If the current instruction doesn't have a function associated with it, just consider it to be part of the previously detected function by not overwriting the previous value of 'func'. Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: <stable@vger.kernel.org> Fixes: 13810435b9 ("objtool: Support GCC 8's cold subfunctions") Link: http://lkml.kernel.org/r/546d143820cd08a46624ae8440d093dd6c902cae.1557766718.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar <mingo@kernel.org>		2019-05-13 20:31:17 +02:00
..
accounting
arch	tools arch uapi: Copy missing unistd.h headers for arc, hexagon and riscv	2019-05-02 16:00:20 -04:00
bpf	tools: bpftool: fix infinite loop in map create	2019-04-25 17:20:06 -07:00
build	tools build: Implement libzstd feature check, LIBZSTD_DIR and NO_LIBZSTD defines	2019-04-01 15:18:10 -03:00
cgroup
crypto
debugging
firewire
firmware
gpio
hv
iio
include	tools include uapi: Sync sound/asound.h copy	2019-04-16 12:36:20 -03:00
io_uring	tools/io_uring: remove IOCQE_FLAG_CACHEHIT	2019-04-08 10:48:50 -06:00
kvm/kvm_stat
laptop
leds
lib	Merge branch 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-05-06 14:16:36 -07:00
memory-model	tools/memory-model: Add support for synchronize_srcu_expedited()	2019-04-04 13:48:34 -07:00
nfsd
objtool	objtool: Fix function fallthrough detection	2019-05-13 20:31:17 +02:00
pci
pcmcia
perf	Merge branch 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-05-06 14:16:36 -07:00
power	ACPICA: Rename nameseg length macro/define for clarity	2019-04-09 11:24:48 +02:00
scripts
spi
testing	s390 updates for the 5.2 merge window	2019-05-06 16:42:54 -07:00
thermal/tmon
time
usb
virtio
vm
wmi
Makefile