forked from Minki/linux
e1dfda9ced
Some users of xchg() don't bother using the return value, which results in a compiler warning like the following (from kgdb): In file included from linux/arch/arm64/include/asm/atomic.h:27:0, from include/linux/atomic.h:4, from include/linux/spinlock.h:402, from include/linux/seqlock.h:35, from include/linux/time.h:5, from include/uapi/linux/timex.h:56, from include/linux/timex.h:56, from include/linux/sched.h:19, from include/linux/pid_namespace.h:4, from kernel/debug/debug_core.c:30: kernel/debug/debug_core.c: In function ‘kgdb_cpu_enter’: linux/arch/arm64/include/asm/cmpxchg.h:75:3: warning: value computed is not used [-Wunused-value] ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr)))) ^ linux/arch/arm64/include/asm/atomic.h:132:30: note: in expansion of macro ‘xchg’ #define atomic_xchg(v, new) (xchg(&((v)->counter), new)) kernel/debug/debug_core.c:504:4: note: in expansion of macro ‘atomic_xchg’ atomic_xchg(&kgdb_active, cpu); ^ This patch makes use of the same trick as we do for cmpxchg, by assigning the return value to a dummy variable in the xchg() macro itself. Signed-off-by: Will Deacon <will.deacon@arm.com> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
191 lines
4.0 KiB
C
191 lines
4.0 KiB
C
/*
|
|
* Based on arch/arm/include/asm/cmpxchg.h
|
|
*
|
|
* Copyright (C) 2012 ARM Ltd.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
#ifndef __ASM_CMPXCHG_H
|
|
#define __ASM_CMPXCHG_H
|
|
|
|
#include <linux/bug.h>
|
|
|
|
#include <asm/barrier.h>
|
|
|
|
static inline unsigned long __xchg(unsigned long x, volatile void *ptr, int size)
|
|
{
|
|
unsigned long ret, tmp;
|
|
|
|
switch (size) {
|
|
case 1:
|
|
asm volatile("// __xchg1\n"
|
|
"1: ldxrb %w0, %2\n"
|
|
" stlxrb %w1, %w3, %2\n"
|
|
" cbnz %w1, 1b\n"
|
|
: "=&r" (ret), "=&r" (tmp), "+Q" (*(u8 *)ptr)
|
|
: "r" (x)
|
|
: "memory");
|
|
break;
|
|
case 2:
|
|
asm volatile("// __xchg2\n"
|
|
"1: ldxrh %w0, %2\n"
|
|
" stlxrh %w1, %w3, %2\n"
|
|
" cbnz %w1, 1b\n"
|
|
: "=&r" (ret), "=&r" (tmp), "+Q" (*(u16 *)ptr)
|
|
: "r" (x)
|
|
: "memory");
|
|
break;
|
|
case 4:
|
|
asm volatile("// __xchg4\n"
|
|
"1: ldxr %w0, %2\n"
|
|
" stlxr %w1, %w3, %2\n"
|
|
" cbnz %w1, 1b\n"
|
|
: "=&r" (ret), "=&r" (tmp), "+Q" (*(u32 *)ptr)
|
|
: "r" (x)
|
|
: "memory");
|
|
break;
|
|
case 8:
|
|
asm volatile("// __xchg8\n"
|
|
"1: ldxr %0, %2\n"
|
|
" stlxr %w1, %3, %2\n"
|
|
" cbnz %w1, 1b\n"
|
|
: "=&r" (ret), "=&r" (tmp), "+Q" (*(u64 *)ptr)
|
|
: "r" (x)
|
|
: "memory");
|
|
break;
|
|
default:
|
|
BUILD_BUG();
|
|
}
|
|
|
|
smp_mb();
|
|
return ret;
|
|
}
|
|
|
|
#define xchg(ptr,x) \
|
|
({ \
|
|
__typeof__(*(ptr)) __ret; \
|
|
__ret = (__typeof__(*(ptr))) \
|
|
__xchg((unsigned long)(x), (ptr), sizeof(*(ptr))); \
|
|
__ret; \
|
|
})
|
|
|
|
static inline unsigned long __cmpxchg(volatile void *ptr, unsigned long old,
|
|
unsigned long new, int size)
|
|
{
|
|
unsigned long oldval = 0, res;
|
|
|
|
switch (size) {
|
|
case 1:
|
|
do {
|
|
asm volatile("// __cmpxchg1\n"
|
|
" ldxrb %w1, %2\n"
|
|
" mov %w0, #0\n"
|
|
" cmp %w1, %w3\n"
|
|
" b.ne 1f\n"
|
|
" stxrb %w0, %w4, %2\n"
|
|
"1:\n"
|
|
: "=&r" (res), "=&r" (oldval), "+Q" (*(u8 *)ptr)
|
|
: "Ir" (old), "r" (new)
|
|
: "cc");
|
|
} while (res);
|
|
break;
|
|
|
|
case 2:
|
|
do {
|
|
asm volatile("// __cmpxchg2\n"
|
|
" ldxrh %w1, %2\n"
|
|
" mov %w0, #0\n"
|
|
" cmp %w1, %w3\n"
|
|
" b.ne 1f\n"
|
|
" stxrh %w0, %w4, %2\n"
|
|
"1:\n"
|
|
: "=&r" (res), "=&r" (oldval), "+Q" (*(u16 *)ptr)
|
|
: "Ir" (old), "r" (new)
|
|
: "cc");
|
|
} while (res);
|
|
break;
|
|
|
|
case 4:
|
|
do {
|
|
asm volatile("// __cmpxchg4\n"
|
|
" ldxr %w1, %2\n"
|
|
" mov %w0, #0\n"
|
|
" cmp %w1, %w3\n"
|
|
" b.ne 1f\n"
|
|
" stxr %w0, %w4, %2\n"
|
|
"1:\n"
|
|
: "=&r" (res), "=&r" (oldval), "+Q" (*(u32 *)ptr)
|
|
: "Ir" (old), "r" (new)
|
|
: "cc");
|
|
} while (res);
|
|
break;
|
|
|
|
case 8:
|
|
do {
|
|
asm volatile("// __cmpxchg8\n"
|
|
" ldxr %1, %2\n"
|
|
" mov %w0, #0\n"
|
|
" cmp %1, %3\n"
|
|
" b.ne 1f\n"
|
|
" stxr %w0, %4, %2\n"
|
|
"1:\n"
|
|
: "=&r" (res), "=&r" (oldval), "+Q" (*(u64 *)ptr)
|
|
: "Ir" (old), "r" (new)
|
|
: "cc");
|
|
} while (res);
|
|
break;
|
|
|
|
default:
|
|
BUILD_BUG();
|
|
}
|
|
|
|
return oldval;
|
|
}
|
|
|
|
static inline unsigned long __cmpxchg_mb(volatile void *ptr, unsigned long old,
|
|
unsigned long new, int size)
|
|
{
|
|
unsigned long ret;
|
|
|
|
smp_mb();
|
|
ret = __cmpxchg(ptr, old, new, size);
|
|
smp_mb();
|
|
|
|
return ret;
|
|
}
|
|
|
|
#define cmpxchg(ptr, o, n) \
|
|
({ \
|
|
__typeof__(*(ptr)) __ret; \
|
|
__ret = (__typeof__(*(ptr))) \
|
|
__cmpxchg_mb((ptr), (unsigned long)(o), (unsigned long)(n), \
|
|
sizeof(*(ptr))); \
|
|
__ret; \
|
|
})
|
|
|
|
#define cmpxchg_local(ptr, o, n) \
|
|
({ \
|
|
__typeof__(*(ptr)) __ret; \
|
|
__ret = (__typeof__(*(ptr))) \
|
|
__cmpxchg((ptr), (unsigned long)(o), \
|
|
(unsigned long)(n), sizeof(*(ptr))); \
|
|
__ret; \
|
|
})
|
|
|
|
#define cmpxchg64(ptr,o,n) cmpxchg((ptr),(o),(n))
|
|
#define cmpxchg64_local(ptr,o,n) cmpxchg_local((ptr),(o),(n))
|
|
|
|
#define cmpxchg64_relaxed(ptr,o,n) cmpxchg_local((ptr),(o),(n))
|
|
|
|
#endif /* __ASM_CMPXCHG_H */
|