leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
de810f490db7ed4c1db2bbfa458b2e27681d2ccb
linux/fs
History
Shuriyc Chu 5704a06810 fs/file.c: initialize init_files.resize_wait 
(Taken from https://bugzilla.kernel.org/show_bug.cgi?id=200647)

'get_unused_fd_flags' in kthread cause kernel crash.  It works fine on
4.1, but causes crash after get 64 fds.  It also cause crash on
ubuntu1404/1604/1804, centos7.5, and the crash messages are almost the
same.

The crash message on centos7.5 shows below:

  start fd 61
  start fd 62
  start fd 63
  BUG: unable to handle kernel NULL pointer dereference at           (null)
  IP: __wake_up_common+0x2e/0x90
  PGD 0
  Oops: 0000 [#1] SMP
  Modules linked in: test(OE) xt_CHECKSUM iptable_mangle ipt_MASQUERADE nf_nat_masquerade_ipv4 iptable_nat nf_nat_ipv4 nf_nat nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ipt_REJECT nf_reject_ipv4 tun bridge stp llc ebtable_filter ebtables ip6table_filter ip6_tables iptable_filter devlink sunrpc kvm_intel kvm irqbypass crc32_pclmul ghash_clmulni_intel aesni_intel lrw gf128mul glue_helper ablk_helper cryptd sg ppdev pcspkr virtio_balloon parport_pc parport i2c_piix4 joydev ip_tables xfs libcrc32c sr_mod cdrom sd_mod crc_t10dif crct10dif_generic ata_generic pata_acpi virtio_scsi virtio_console virtio_net cirrus drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops ttm crct10dif_pclmul crct10dif_common crc32c_intel drm ata_piix serio_raw libata virtio_pci virtio_ring i2c_core
   virtio floppy dm_mirror dm_region_hash dm_log dm_mod
  CPU: 2 PID: 1820 Comm: test_fd Kdump: loaded Tainted: G           OE  ------------   3.10.0-862.3.3.el7.x86_64 #1
  Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.10.2-0-g5f4c7b1-prebuilt.qemu-project.org 04/01/2014
  task: ffff8e92b9431fa0 ti: ffff8e94247a0000 task.ti: ffff8e94247a0000
  RIP: 0010:__wake_up_common+0x2e/0x90
  RSP: 0018:ffff8e94247a2d18  EFLAGS: 00010086
  RAX: 0000000000000000 RBX: ffffffff9d09daa0 RCX: 0000000000000000
  RDX: 0000000000000000 RSI: 0000000000000003 RDI: ffffffff9d09daa0
  RBP: ffff8e94247a2d50 R08: 0000000000000000 R09: ffff8e92b95dfda8
  R10: 0000000000000000 R11: 0000000000000000 R12: ffffffff9d09daa8
  R13: 0000000000000003 R14: 0000000000000000 R15: 0000000000000003
  FS:  0000000000000000(0000) GS:ffff8e9434e80000(0000) knlGS:0000000000000000
  CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  CR2: 0000000000000000 CR3: 000000017c686000 CR4: 00000000000207e0
  Call Trace:
    __wake_up+0x39/0x50
    expand_files+0x131/0x250
    __alloc_fd+0x47/0x170
    get_unused_fd_flags+0x30/0x40
    test_fd+0x12a/0x1c0 [test]
    kthread+0xd1/0xe0
    ret_from_fork_nospec_begin+0x21/0x21
  Code: 66 90 55 48 89 e5 41 57 41 89 f7 41 56 41 89 ce 41 55 41 54 49 89 fc 49 83 c4 08 53 48 83 ec 10 48 8b 47 08 89 55 cc 4c 89 45 d0 <48> 8b 08 49 39 c4 48 8d 78 e8 4c 8d 69 e8 75 08 eb 3b 4c 89 ef
  RIP   __wake_up_common+0x2e/0x90
   RSP <ffff8e94247a2d18>
  CR2: 0000000000000000

This issue exists since CentOS 7.5 3.10.0-862 and CentOS 7.4
(3.10.0-693.21.1 ) is ok.  Root cause: the item 'resize_wait' is not
initialized before being used.

Reported-by: Richard Zhang <zhang.zijian@h3c.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2019-03-05 21:07:14 -08:00
..
9p
Merge branch 'work.afs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2018-11-01 19:58:52 -07:00
adfs
adfs: use timespec64 for time conversion
2018-08-22 10:52:51 -07:00
affs
affs: fix potential memory leak when parsing option 'prefix'
2018-05-28 12:36:41 +02:00
afs
afs: Fix manually set volume location server list
2019-02-25 11:59:07 -08:00
autofs
autofs: fix error return in autofs_fill_super()
2019-02-01 15:46:24 -08:00
befs
fix a series of Documentation/ broken file name references
2018-06-15 18:10:01 -03:00
bfs
bfs: extra sanity checking and static inode bitmap
2019-01-04 13:13:47 -08:00
btrfs
Merge tag 'for-5.0-rc4-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux
2019-02-03 08:48:33 -08:00
cachefiles
fscache, cachefiles: remove redundant variable 'cache'
2018-11-30 16:00:58 +00:00
ceph
ceph: avoid repeatedly adding inode to mdsc->snap_flush_list
2019-02-18 18:08:29 +01:00
cifs
cifs: update internal module version number
2019-01-31 07:05:06 -06:00
coda
vfs: change inode times to use struct timespec64
2018-06-05 16:57:31 -07:00
configfs
configfs: fix registered group removal
2018-07-17 06:14:07 -07:00
cramfs
Merge tag 'cramfs_fixes' of git://git.linaro.org/people/nicolas.pitre/linux
2018-10-30 12:46:25 -07:00
crypto
crypto: clarify name of WEAK_KEY request flag
2019-01-25 18:41:52 +08:00
debugfs
debugfs: debugfs_lookup() should return NULL if not found
2019-01-30 12:39:49 +01:00
devpts
devpts: Convert to new IDA API
2018-08-21 23:54:17 -04:00
dlm
socket: Rename SO_RCVTIMEO/ SO_SNDTIMEO with _OLD suffixes
2019-02-03 11:17:31 -08:00
ecryptfs
crypto: clarify name of WEAK_KEY request flag
2019-01-25 18:41:52 +08:00
efivarfs
efivars: Call guid_parse() against guid_t type of variable
2018-07-22 14:13:44 +02:00
efs
…
exofs
exofs_mount(): fix leaks on failure exits
2018-12-17 18:36:33 -05:00
exportfs
exportfs: do not read dentry after free
2018-11-23 09:08:17 -05:00
ext2
Merge tag 'fs_for_4.21-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
2018-12-27 17:00:35 -08:00
ext4
Revert "ext4: use ext4_write_inode() when fsyncing w/o a journal"
2019-01-31 23:41:11 -05:00
f2fs
Merge tag 'f2fs-for-4.21' of git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs
2018-12-31 09:41:37 -08:00
fat
Merge branch 'akpm' (patches from Andrew)
2019-01-05 09:16:18 -08:00
freevxfs
freevxfs_lookup(): use d_splice_alias()
2018-05-22 14:27:51 -04:00
fscache
fscache: fix race between enablement and dropping of object
2018-11-30 15:57:31 +00:00
fuse
fuse: decrement NR_WRITEBACK_TEMP on the right page
2019-01-16 10:27:59 +01:00
gfs2
Revert "gfs2: read journal in large chunks to locate the head"
2019-02-14 09:52:51 -08:00
hfs
hfs: do not free node before using
2018-11-30 14:56:14 -08:00
hfsplus
hfsplus: return file attributes on statx
2019-01-04 13:13:47 -08:00
hostfs
vfs: discard ATTR_ATTR_FLAG
2018-08-17 16:20:28 -07:00
hpfs
hpfs: remove unnecessary checks on the value of r when assigning error code
2018-08-25 12:42:33 -07:00
hugetlbfs
hugetlbfs: fix races and page leaks during migration
2019-03-01 09:02:33 -08:00
isofs
Update email address
2018-09-29 22:47:48 -04:00
jbd2
jbd2: clean up indentation issue, replace spaces with tab
2018-12-04 00:20:10 -05:00
jffs2
jffs2: Fix use of uninitialized delayed_work, lockdep breakage
2018-12-02 09:20:34 +01:00
jfs
jfs: remove redundant dquot_initialize() in jfs_evict_inode()
2018-09-20 09:28:49 -05:00
kernfs
fix cgroup_do_mount() handling of failure exits
2019-01-17 11:52:49 -05:00
lockd
Merge tag 'nfs-for-4.21-1' of git://git.linux-nfs.org/projects/anna/linux-nfs
2019-01-02 16:35:23 -08:00
minix
minix_lookup: use d_splice_alias()
2018-05-22 14:27:52 -04:00
nfs
Merge branch 'fixes-v5.1-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security
2019-02-20 09:09:33 -08:00
nfs_common
…
nfsd
Revert "nfsd4: return default lease period"
2019-02-14 12:33:19 -05:00
nilfs2
nilfs2: Use xa_erase_irq
2018-11-05 14:57:05 -05:00
nls
…
notify
inotify: Fix fd refcount leak in inotify_add_watch().
2019-01-02 18:28:37 +01:00
ntfs
mm: convert totalram_pages and totalhigh_pages variables to atomic
2018-12-28 12:11:47 -08:00
ocfs2
ocfs2: Use zero-sized array and struct_size() in kzalloc()
2019-03-05 21:07:13 -08:00
omfs
omfs_lookup(): report IO errors, use d_splice_alias()
2018-05-22 14:27:58 -04:00
openpromfs
fs/openpromfs: Use of_node_name_eq for node name comparisons
2018-11-18 13:35:19 -08:00
orangefs
orangefs: remove two un-needed BUG_ONs...
2019-02-20 15:12:52 -05:00
overlayfs
Revert "ovl: relax permission checking on underlying layers"
2018-12-04 11:31:30 +01:00
proc
proc, oom: do not report alien mms when setting oom_score_adj
2019-02-21 09:01:00 -08:00
pstore
pstore/ram: Avoid allocation and leak of platform data
2019-01-20 14:44:52 -08:00
qnx4
qnx4_lookup: use d_splice_alias()
2018-05-22 14:27:52 -04:00
qnx6
qnx6_lookup: switch to d_splice_alias()
2018-05-22 14:27:54 -04:00
quota
quota: Lock s_umount in exclusive mode for Q_XQUOTA{ON,OFF} quotactls.
2018-12-18 18:29:15 +01:00
ramfs
…
reiserfs
reiserfs: remove workaround code for GCC 3.x
2018-10-31 08:54:14 -07:00
romfs
romfs_lookup: switch to d_splice_alias()
2018-05-22 14:27:55 -04:00
squashfs
Squashfs: Compute expected length from inode size rather than block length
2018-08-02 09:34:02 -07:00
sysfs
sysfs: convert BUG_ON to WARN_ON
2019-01-07 08:53:32 +01:00
sysv
sysv: return 'err' instead of 0 in __sysv_write_inode
2018-11-10 08:02:40 -05:00
tracefs
tracefs: Annotate tracefs_ops with __ro_after_init
2018-07-31 11:32:44 -04:00
ubifs
mm: migrate: drop unused argument of migrate_page_move_mapping()
2018-12-28 12:11:51 -08:00
udf
Merge tag 'fs_for_4.21-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
2018-12-27 17:00:35 -08:00
ufs
fs/ufs: use ktime_get_real_seconds for sb and cg timestamps
2018-08-17 16:20:27 -07:00
xfs
xfs: set buffer ops when repair probes for btree type
2019-02-03 14:03:59 -08:00
aio.c
Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2019-03-04 13:24:27 -08:00
anon_inodes.c
anon_inode_getfile(): switch to alloc_file_pseudo()
2018-07-12 10:04:27 -04:00
attr.c
fs: Fix attr.c kernel-doc
2018-07-03 16:44:45 -04:00
bad_inode.c
get rid of 'opened' argument of ->atomic_open() - part 3
2018-07-12 10:04:20 -04:00
binfmt_aout.c
a.out: remove core dumping support
2019-03-05 10:00:35 -08:00
binfmt_elf_fdpic.c
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
binfmt_elf.c
signal: Distinguish between kernel_siginfo and siginfo
2018-10-03 16:47:43 +02:00
binfmt_em86.c
…
binfmt_flat.c
…
binfmt_misc.c
turn filp_clone_open() into inline wrapper for dentry_open()
2018-07-10 23:29:03 -04:00
binfmt_script.c
exec: load_script: Do not exec truncated interpreter path
2019-02-18 16:49:36 -08:00
block_dev.c
blockdev: Fix livelocks on loop device
2019-01-15 07:30:56 -07:00
buffer.c
fs: ratelimit __find_get_block_slow() failure message.
2019-02-06 12:58:56 -07:00
char_dev.c
…
compat_binfmt_elf.c
y2038: globally rename compat_time to old_time32
2018-08-27 14:48:48 +02:00
compat_ioctl.c
Merge tag 'media/v4.20-1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media
2018-10-29 14:29:58 -07:00
compat.c
ncpfs: remove compat functionality
2018-06-05 19:23:26 +02:00
coredump.c
signal: Distinguish between kernel_siginfo and siginfo
2018-10-03 16:47:43 +02:00
d_path.c
…
dax.c
Merge tag 'dax-fix-4.21' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm
2018-12-31 09:46:39 -08:00
dcache.c
fs/dcache: Track & report number of negative dentries
2019-01-30 11:02:11 -08:00
dcookies.c
…
direct-io.c
direct-io: allow direct writes to empty inodes
2019-01-22 08:26:44 -07:00
drop_caches.c
fs/drop_caches.c: avoid softlockups in drop_pagecache_sb()
2019-02-01 15:46:24 -08:00
eventfd.c
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
eventpoll.c
Merge branch 'akpm' (patches from Andrew)
2019-01-05 09:16:18 -08:00
exec.c
exec: Fix mem leak in kernel_read_file
2019-02-18 21:26:24 -05:00
fcntl.c
signal: Distinguish between kernel_siginfo and siginfo
2018-10-03 16:47:43 +02:00
fhandle.c
…
file_table.c
mm: convert totalram_pages and totalhigh_pages variables to atomic
2018-12-28 12:11:47 -08:00
file.c
fs/file.c: initialize init_files.resize_wait
2019-03-05 21:07:14 -08:00
filesystems.c
…
fs_pin.c
…
fs_struct.c
…
fs-writeback.c
writeback: synchronize sync(2) against cgroup writeback membership switches
2019-01-22 14:39:38 -07:00
inode.c
fs/inode.c: inode_set_flags(): replace opencoded set_mask_bits()
2019-03-05 21:07:13 -08:00
internal.h
Merge tag 'ovl-update-4.19' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs
2018-08-21 18:19:09 -07:00
ioctl.c
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
iomap.c
iomap: fix a use after free in iomap_dio_rw
2019-01-27 08:47:42 -08:00
Kconfig
autofs: remove left-over autofs4 stubs
2018-06-11 08:22:34 -07:00
Kconfig.binfmt
kconfig: move the "Executable file formats" menu to fs/Kconfig.binfmt
2018-08-02 08:06:55 +09:00
libfs.c
…
locks.c
locks: fix error in locks_move_blocks()
2019-01-02 20:14:50 -05:00
Makefile
autofs: remove left-over autofs4 stubs
2018-06-11 08:22:34 -07:00
mbcache.c
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
mount.h
…
mpage.c
mpage: mpage_readpages() should submit IO as read-ahead
2018-08-17 16:20:29 -07:00
namei.c
Revert "vfs: Allow userns root to call mknod on owned filesystems."
2018-12-22 14:18:34 -08:00
namespace.c
Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2019-03-04 13:24:27 -08:00
no-block.c
…
nsfs.c
…
open.c
Merge tag 'ovl-update-4.19' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs
2018-08-21 18:19:09 -07:00
pipe.c
Merge branch 'work.open3' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2018-08-13 19:58:36 -07:00
pnode.c
vfs: Suppress MS_* flag defs within the kernel unless explicitly enabled
2018-12-20 16:32:56 +00:00
pnode.h
…
posix_acl.c
…
proc_namespace.c
…
read_write.c
get rid of legacy 'get_ds()' function
2019-03-04 10:50:14 -08:00
readdir.c
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
select.c
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
seq_file.c
fs/seq_file.c: simplify seq_file iteration code and interface
2018-08-17 16:20:28 -07:00
signalfd.c
signal: Distinguish between kernel_siginfo and siginfo
2018-10-03 16:47:43 +02:00
splice.c
fs: Make splice() and tee() take into account O_NONBLOCK flag on pipes
2019-03-04 16:10:17 -08:00
stack.c
…
stat.c
y2038: Remove newstat family from default syscall set
2018-08-29 15:42:20 +02:00
statfs.c
kernel: add kcompat_sys_{f,}statfs64()
2018-07-12 14:49:48 +01:00
super.c
mount_fs: suppress MAC on MS_SUBMOUNT as well as MS_KERNMOUNT
2018-12-21 11:51:23 -05:00
sync.c
…
timerfd.c
y2038: globally rename compat_time to old_time32
2018-08-27 14:48:48 +02:00
userfaultfd.c
userfaultfd: clear flag if remap event not enabled
2018-12-28 12:11:51 -08:00
utimes.c
y2038: utimes: Rework #ifdef guards for compat syscalls
2018-08-29 15:42:23 +02:00
xattr.c
sysfs: Do not return POSIX ACL xattrs via listxattr
2018-09-18 07:30:48 -04:00