Tejun Heo db4aad209b kernfs: associate a new kernfs_node with its parent on creation ... Once created, a kernfs_node is always destroyed by kernfs_put(). Since ba7443bc65 ("sysfs, kernfs: implement kernfs_create/destroy_root()"), kernfs_put() depends on kernfs_root() to locate the ino_ida. kernfs_root() in turn depends on kernfs_node->parent being set for !dir nodes. This means that kernfs_put() of a !dir node requires its ->parent to be initialized. This leads to oops when a newly created !dir node is destroyed without going through kernfs_add_one() or after failing kernfs_add_one() before ->parent is set. kernfs_root() invoked from kernfs_put() will try to dereference NULL parent. Fix it by moving parent association to kernfs_new_node() from kernfs_add_one(). kernfs_new_node() now takes @parent instead of @root and determines the root from the parent and also sets the new node's parent properly. @parent parameter is removed from kernfs_add_one(). As there's no parent when creating the root node, __kernfs_new_node() which takes @root as before and doesn't set the parent is used in that case. This ensures that a kernfs_node in any stage in its life has its parent associated and thus can be put. Signed-off-by: Tejun Heo <tj@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2014-01-17 11:50:07 -08:00
..
dir.c	kernfs: associate a new kernfs_node with its parent on creation	2014-01-17 11:50:07 -08:00
file.c	kernfs: associate a new kernfs_node with its parent on creation	2014-01-17 11:50:07 -08:00
inode.c	kernfs: s/sysfs/kernfs/ in internal functions and whatever is left	2013-12-11 17:39:20 -08:00
kernfs-internal.h	kernfs: associate a new kernfs_node with its parent on creation	2014-01-17 11:50:07 -08:00
Makefile	sysfs, kernfs: add skeletons for kernfs	2013-11-27 13:28:24 -08:00
mount.c	kernfs: s/sysfs/kernfs/ in internal functions and whatever is left	2013-12-11 17:39:20 -08:00
symlink.c	kernfs: associate a new kernfs_node with its parent on creation	2014-01-17 11:50:07 -08:00