forked from Minki/linux
db1ac4964f
With the current ARG_PTR_TO_MEM/ARG_PTR_TO_UNINIT_MEM semantics, an helper argument can be NULL when the next argument type is ARG_CONST_SIZE_OR_ZERO and the verifier can prove the value of this next argument is 0. However, most helpers are just interested in handling <!NULL, 0>, so forcing them to deal with <NULL, 0> makes the implementation of those helpers more complicated for no apparent benefits, requiring them to explicitly handle those corner cases with checks that bpf programs could start relying upon, preventing the possibility of removing them later. Solve this by making ARG_PTR_TO_MEM/ARG_PTR_TO_UNINIT_MEM never accept NULL even when ARG_CONST_SIZE_OR_ZERO is set, and introduce a new argument type ARG_PTR_TO_MEM_OR_NULL to explicitly deal with the NULL case. Currently, the only helper that needs this is bpf_csum_diff_proto(), so change arg1 and arg3 to this new type as well. Also add a new battery of tests that explicitly test the !ARG_PTR_TO_MEM_OR_NULL combination: all the current ones testing the various <NULL, 0> variations are focused on bpf_csum_diff, so cover also other helpers. Signed-off-by: Gianluca Borello <g.borello@gmail.com> Acked-by: Alexei Starovoitov <ast@kernel.org> Acked-by: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> |
||
|---|---|---|
| .. | ||
| gnu | ||
| include/uapi/linux | ||
| .gitignore | ||
| bpf_endian.h | ||
| bpf_helpers.h | ||
| bpf_util.h | ||
| cgroup_helpers.c | ||
| cgroup_helpers.h | ||
| config | ||
| dev_cgroup.c | ||
| Makefile | ||
| sockmap_parse_prog.c | ||
| sockmap_verdict_prog.c | ||
| test_align.c | ||
| test_dev_cgroup.c | ||
| test_iptunnel_common.h | ||
| test_kmod.sh | ||
| test_l4lb.c | ||
| test_lpm_map.c | ||
| test_lru_map.c | ||
| test_maps.c | ||
| test_obj_id.c | ||
| test_pkt_access.c | ||
| test_pkt_md_access.c | ||
| test_progs.c | ||
| test_tag.c | ||
| test_tcp_estats.c | ||
| test_verifier_log.c | ||
| test_verifier.c | ||
| test_xdp_meta.c | ||
| test_xdp_meta.sh | ||
| test_xdp_redirect.c | ||
| test_xdp_redirect.sh | ||
| test_xdp.c | ||