linux/drivers/gpu/drm/amd/display
Nicholas Kazlauskas d82b3266ef drm/amd/display: Don't lock connection_mutex for DMUB HPD
[Why]
Per DRM spec we only need to hold that lock when touching
connector->state - which we do not do in that handler.

Taking this locking introduces unnecessary dependencies with other
threads which is bad for performance and opens up the potential for
a deadlock since there are multiple locks being held at once.

[How]
Remove the connection_mutex lock/unlock routine and just iterate over
the drm connectors normally. The iter helpers implicitly lock the
connection list so this is safe to do.

DC link access also does not need to be guarded since the link
table is static at creation - we don't dynamically add or remove links,
just streams.

Fixes: e27c41d5b0 ("drm/amd/display: Support for DMUB HPD interrupt handling")

Reviewed-by: Jude Shih <shenshih@amd.com>
Acked-by: Anson Jacob <Anson.Jacob@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2021-11-09 17:08:00 -05:00
..
amdgpu_dm drm/amd/display: Don't lock connection_mutex for DMUB HPD 2021-11-09 17:08:00 -05:00
dc drm/amd/display: Add comment where CONFIG_DRM_AMD_DC_DCN macro ends 2021-11-09 17:08:00 -05:00
dmub drm/amd/display: [FW Promotion] Release 0.0.91 2021-11-03 12:32:34 -04:00
include drm/amd/display: add two lane settings training options 2021-10-28 14:26:17 -04:00
modules drm/amd/display: Fix deadlock when falling back to v2 from v3 2021-10-28 14:26:51 -04:00
Kconfig drm/amdgpu/display: fix dependencies for DRM_AMD_DC_SI 2021-10-05 10:55:41 -04:00
Makefile drm/amd/display: Drop CONFIG_DRM_AMD_DC_DMUB guards 2019-11-13 15:29:42 -05:00
TODO