leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity
d806afa495
linux/sound/pci
History
Linus Torvalds 70b20dd7f8 ALSA: update dell-wmi mic-mute registration to new world order 
Commit c647f806b8 ("ALSA: hda - Allow multiple ADCs for mic mute LED
controls") changed the return value of the snd_hda_gen_add_micmute_led()
without actually updating the callers.

Admittedly, almost no callers actually cared about the return value.
But one call site very much did: the Dell wmi code.  It would see the
registration return zero, which _used_ to mean "failed" but now means
"success", and clear the dell_micmute_led_set_func pointer.

End result: the successful registration would end up calling the Dell
code that thought it had all failed, and call through a NULL pointer.

To make matters worse, it ends up being a tail-call, and with the
retpoline sequence you don't even see the caller (dell_micmute_update())
in the stack trace, so the error ended up way less obvious than it
should have been.

Fixes: c647f806b8 "ALSA: hda - Allow multiple ADCs for mic mute LED controls"
Cc: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-08-15 19:08:10 -07:00
..
ac97 ALSA: pci: Remove empty init and exit 2018-08-03 16:11:48 +02:00
ali5451 ALSA: ali5451: remove redundant pointer 'codec' 2018-07-16 14:30:33 +02:00
asihpi ALSA: asihpi: remove redundant variable max_streams 2018-08-01 13:59:12 +02:00
au88x0 ALSA: au88x0: Fix sparse warning wrt PCM format type 2018-07-27 09:05:28 +02:00
aw2 ALSA: aw2: make snd_pcm_hardware const 2017-08-12 23:31:39 +02:00
ca0106 sound: Use octal not symbolic permissions 2018-05-28 11:27:20 +02:00
cs46xx ALSA: cs46xx: remove redundant pointer 'ins' 2018-07-16 14:30:46 +02:00
cs5535audio ALSA: cs5535audio: remove redundant pointer 'dma' 2018-08-01 13:59:29 +02:00
ctxfi ALSA: ctxfi: cthw20k2: Replace mdelay() with msleep() and usleep_range() 2018-07-27 11:49:16 +02:00
echoaudio ALSA: echoaudio: Mark expected switch fall-throughs 2018-08-06 09:33:45 +02:00
emu10k1 ALSA: emu10k1: Mark expected switch fall-throughs 2018-08-06 09:33:43 +02:00
hda ALSA: update dell-wmi mic-mute registration to new world order 2018-08-15 19:08:10 -07:00
ice1712 ALSA: pci: Remove empty init and exit 2018-08-03 16:11:48 +02:00
korg1212 ALSA: korg1212: Add __force annotation to cast in user-copy callbacks 2018-07-26 08:33:08 +02:00
lola ALSA: lola: Proper endian notations 2018-07-27 09:06:05 +02:00
lx6464es ALSA: lx6464es: Missing error code in snd_lx6464es_create() 2018-06-21 11:04:42 +02:00
mixart ALSA: mixart: Mark expected switch fall-through 2018-08-09 08:52:04 +02:00
nm256 License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
oxygen ALSA: oxygen: use match_string() helper 2018-05-31 19:42:48 +02:00
pcxhr sound: Use octal not symbolic permissions 2018-05-28 11:27:20 +02:00
riptide ALSA: riptide: Properly endian notations 2018-07-27 09:06:02 +02:00
rme9652 ALSA: rme9652: Hardening for potential Spectre v1 2018-04-25 10:37:48 +02:00
trident ALSA: trident: Proper endian notations 2018-07-27 09:06:00 +02:00
vx222 ALSA: vx222: Fix invalid endian conversions 2018-07-26 08:23:28 +02:00
ymfpci ALSA: ymfpci: Proper endian notations 2018-07-27 09:05:58 +02:00
ad1889.c ALSA: ad1889: Replace mdelay with usleep_range in snd_ad1889_ac97_ready 2018-04-16 13:49:09 +02:00
ad1889.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
ak4531_codec.c
als300.c ALSA: pci: make snd_pcm_hardware const 2017-08-12 23:31:58 +02:00
als4000.c ALSA: pci: make snd_pcm_hardware const 2017-08-12 23:31:58 +02:00
atiixp_modem.c ALSA: atiixp_modem: Proper endian notations 2018-07-27 09:06:13 +02:00
atiixp.c ALSA: atiixp: Proper endian notations 2018-07-27 09:06:12 +02:00
azt3328.c ALSA: azt3328: Constify hw_constraints 2017-06-09 10:42:49 +02:00
azt3328.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
bt87x.c ALSA: bt87x: Proper endian notations 2018-07-27 09:06:11 +02:00
cmipci.c ALSA: cmipci: Allocate with GFP_KERNEL instead of GFP_ATOMIC 2018-04-16 14:01:31 +02:00
cs4281.c ALSA: pci: make snd_pcm_hardware const 2017-08-12 23:31:58 +02:00
cs5530.c
ens1370.c ALSA: ens137x: remove redundant array pcm_devs 2018-08-01 13:59:58 +02:00
ens1371.c
es1938.c ALSA: pci: make snd_pcm_hardware const 2017-08-12 23:31:58 +02:00
es1968.c ALSA: pci: make snd_pcm_hardware const 2017-08-12 23:31:58 +02:00
fm801.c ALSA: fm801: add error handling for snd_ctl_add 2018-06-11 15:21:19 +02:00
intel8x0.c ALSA: intel8x0: Proper endian notations 2018-07-27 09:06:06 +02:00
intel8x0m.c ALSA: intel8x0m: Proper endian notations 2018-07-27 09:06:07 +02:00
Kconfig docs: Fix some broken references 2018-06-15 18:10:01 -03:00
maestro3.c ALSA: maestro3: Proper endian notations 2018-07-27 09:06:08 +02:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
rme32.c ALSA: pci: make snd_pcm_hardware const 2017-08-12 23:31:58 +02:00
rme96.c ALSA: pci: make snd_pcm_hardware const 2017-08-12 23:31:58 +02:00
sis7019.c ALSA: pci: make snd_pcm_hardware const 2017-08-12 23:31:58 +02:00
sis7019.h
sonicvibes.c ALSA: sonicvibes: remove redundant pointer 'dir' 2018-08-01 14:00:13 +02:00
via82xx_modem.c treewide: kmalloc() -> kmalloc_array() 2018-06-12 16:19:22 -07:00
via82xx.c treewide: kmalloc() -> kmalloc_array() 2018-06-12 16:19:22 -07:00