linux

mainlining shenanigans

Go to file

Jiaxin Yu d7bffbe9cb ASoC: mediatek: mt8186: remove unnecessary judgments The afe_priv->dai_priv[] is allocated when platform driver probe(), if it failed, the ASoC platform driver probe() will return fail first. Therefore, this is excessive judgment, and the condition will never be established. Bug report: https://www.spinics.net/lists/alsa-devel/msg145609.html This is a semi-automatic email about new static checker warnings. The patch `ae92dcbee8`: "ASoC: mediatek: mt8186: support tdm in platform driver" from May 23, 2022, leads to the following Smatch complaint: sound/soc/mediatek/mt8186/mt8186-dai-tdm.c:424 mtk_dai_tdm_hw_params() warn: variable dereferenced before check 'tdm_priv' (see line 406) sound/soc/mediatek/mt8186/mt8186-dai-tdm.c 405 struct mtk_afe_tdm_priv *tdm_priv = afe_priv->dai_priv[tdm_id]; 406 unsigned int tdm_mode = tdm_priv->tdm_mode; ^^^^^^^^^^^^^^^^^^^ Lot's of dereferences 407 unsigned int data_mode = tdm_priv->data_mode; 408 unsigned int rate = params_rate(params); 409 unsigned int channels = params_channels(params); 410 snd_pcm_format_t format = params_format(params); 411 unsigned int bit_width = 412 snd_pcm_format_physical_width(format); 413 unsigned int tdm_channels = (data_mode == TDM_DATA_ONE_PIN) ? 414 get_tdm_ch_per_sdata(tdm_mode, channels) : 2; 415 unsigned int lrck_width = 416 get_tdm_lrck_width(format, tdm_mode); 417 unsigned int tdm_con = 0; 418 bool slave_mode = tdm_priv->slave_mode; 419 bool lrck_inv = tdm_priv->lck_invert; 420 bool bck_inv = tdm_priv->bck_invert; 421 unsigned int tran_rate; 422 unsigned int tran_relatch_rate; 423 424 if (!tdm_priv) { ^^^^^^^^^ Checked too late 425 dev_err(afe->dev, "%s(), tdm_priv == NULL", __func__); 426 return -EINVAL; Fixes: `ae92dcbee8` ("ASoC: mediatek: mt8186: support tdm in platform driver") Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com> Link: https://lore.kernel.org/r/20220726154220.28141-1-jiaxin.yu@mediatek.com Signed-off-by: Mark Brown <broonie@kernel.org>		2022-07-27 13:14:44 +01:00
arch	Hot fixes for 5.19-rc1.	2022-06-05 17:05:38 -07:00
block	for-5.19/drivers-2022-06-02	2022-06-03 10:25:56 -07:00
certs	Kbuild updates for v5.19	2022-05-26 12:09:50 -07:00
crypto	This update includes the following changes:	2022-05-27 18:06:49 -07:00
Documentation	ASoC: dt-bindings: tas2780: remove tas2780 and will merge it to tas27xx	2022-07-26 16:13:03 +01:00
drivers	firmware: cs_dsp: Add memory chunk helpers	2022-07-22 13:40:00 +01:00
fs	fix for breakage in #work.fd this window	2022-06-05 17:14:03 -07:00
include	ASoC: SOF: dai-intel: add SOF_DAI_INTEL_SSP_CLKCTRL_MCLK_AON bit	2022-07-25 22:37:02 +01:00
init	This set of changes updates init and user mode helper tasks to be	2022-06-03 16:03:05 -07:00
ipc	These changes update the ipc sysctls so that they are fundamentally	2022-06-03 15:54:57 -07:00
kernel	A single featurelet for delay accounting. Delayed a bit	2022-06-05 16:58:27 -07:00
lib	Bitmap patches for 5.19-rc1	2022-06-04 14:04:27 -07:00
LICENSES
mm	Hot fixes for 5.19-rc1.	2022-06-05 17:05:38 -07:00
net	bluetooth: don't use bitmaps for random flag accesses	2022-06-05 16:28:41 -07:00
samples	drm for 5.19-rc1	2022-05-25 16:18:27 -07:00
scripts	A set of objtool fixes:	2022-06-05 09:45:27 -07:00
security	Cleanups (and one fix) around struct mount handling.	2022-06-04 19:00:05 -07:00
sound	ASoC: mediatek: mt8186: remove unnecessary judgments	2022-07-27 13:14:44 +01:00
tools	A single featurelet for delay accounting. Delayed a bit	2022-06-05 16:58:27 -07:00
usr	Not a lot of material this cycle. Many singleton patches against various	2022-05-27 11:22:03 -07:00
virt	VFIO updates for v5.19-rc1	2022-06-01 13:49:15 -07:00
.clang-format
.cocciconfig
.get_maintainer.ignore
.gitattributes
.gitignore
.mailmap	Hot fixes for 5.19-rc1.	2022-06-05 17:05:38 -07:00
COPYING
CREDITS
Kbuild
Kconfig
MAINTAINERS	ASoC: dt-bindings: Add bindings for WCD9335 DAIs	2022-06-29 18:11:27 +01:00
Makefile	Linux 5.19-rc1	2022-06-05 17:18:54 -07:00
README

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.