linux/drivers/gpu/drm/amd/display
David Francis 9bbf6a5341 drm/amd/display: Flatten unnecessary i2c functions
[Why]
The dce_i2c_hw code contained four funtcions that were only
called in one place and did not have a clearly delineated
purpose.

[How]
Inline these functions, keeping the same functionality.

This is not a functional change.

The functions disable_i2c_hw_engine and release_engine_dce_hw were
pulled into their respective callers.

The most interesting part of this change is the acquire functions.
dce_i2c_hw_engine_acquire_engine was pulled into
dce_i2c_engine_acquire_hw, and dce_i2c_engine_acquire_hw was pulled
into acquire_i2c_hw_engine.

Some notes to show that this change is not functional:
-Failure conditions in any function resulted in a cascade of calls that
ended in a 'return NULL'.
Those are replaced with a direct 'return NULL'.

-The variable result is the one from dce_i2c_hw_engine_acquire_engine.
The boolean result used as part of return logic was removed.

-As the second half of dce_i2c_hw_engine_acquire_engine is only executed
if that function is returning true and therefore exiting the do-while
loop in dce_i2c_engine_acquire_hw, those lines were moved outside
of the loop.

Signed-off-by: David Francis <David.Francis@amd.com>
Acked-by: Leo Li <sunpeng.li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2018-08-27 15:21:11 -05:00
..
amdgpu_dm drm/amd/display: Support reading hw state from debugfs file 2018-08-27 15:20:49 -05:00
dc drm/amd/display: Flatten unnecessary i2c functions 2018-08-27 15:21:11 -05:00
include drm/amd/display: Support reading hw state from debugfs file 2018-08-27 15:20:49 -05:00
modules drm/amd/display: Enable Stereo in Dal3 2018-08-27 11:10:57 -05:00
Kconfig drm/amd/display: Don't build DCN1 when kcov is enabled 2018-08-21 14:33:59 -05:00
Makefile drm/amd/display: Enable Stereo in Dal3 2018-08-27 11:10:57 -05:00
TODO drm/amd/display: Convert remaining loggers off dc_logger 2018-07-13 14:48:42 -05:00