Leon Romanovsky d086a1c65a net: sched: Fix suspicious RCU usage while accessing tcf_tunnel_info ... The access of tcf_tunnel_info() produces the following splat, so fix it by dereferencing the tcf_tunnel_key_params pointer with marker that internal tcfa_liock is held. ============================= WARNING: suspicious RCU usage 5.9.0+ #1 Not tainted ----------------------------- include/net/tc_act/tc_tunnel_key.h:59 suspicious rcu_dereference_protected() usage! other info that might help us debug this: rcu_scheduler_active = 2, debug_locks = 1 1 lock held by tc/34839: #0: ffff88828572c2a0 (&p->tcfa_lock){+...}-{2:2}, at: tc_setup_flow_action+0xb3/0x48b5 stack backtrace: CPU: 1 PID: 34839 Comm: tc Not tainted 5.9.0+ #1 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.12.1-0-ga5cab58e9a3f-prebuilt.qemu.org 04/01/2014 Call Trace: dump_stack+0x9a/0xd0 tc_setup_flow_action+0x14cb/0x48b5 fl_hw_replace_filter+0x347/0x690 [cls_flower] fl_change+0x2bad/0x4875 [cls_flower] tc_new_tfilter+0xf6f/0x1ba0 rtnetlink_rcv_msg+0x5f2/0x870 netlink_rcv_skb+0x124/0x350 netlink_unicast+0x433/0x700 netlink_sendmsg+0x6f1/0xbd0 sock_sendmsg+0xb0/0xe0 ____sys_sendmsg+0x4fa/0x6d0 ___sys_sendmsg+0x12e/0x1b0 __sys_sendmsg+0xa4/0x120 do_syscall_64+0x2d/0x40 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x7f1f8cd4fe57 Code: 0c 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f 1f 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 2e 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 51 c3 48 83 ec 28 89 54 24 1c 48 89 74 24 10 RSP: 002b:00007ffdc1e193b8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f1f8cd4fe57 RDX: 0000000000000000 RSI: 00007ffdc1e19420 RDI: 0000000000000003 RBP: 000000005f85aafa R08: 0000000000000001 R09: 00007ffdc1e1936c R10: 000000000040522d R11: 0000000000000246 R12: 0000000000000001 R13: 0000000000000000 R14: 00007ffdc1e1d6f0 R15: 0000000000482420 Fixes: 3ebaf6da07 ("net: sched: Do not assume RTNL is held in tunnel key action helpers") Fixes: 7a47281439 ("net: sched: lock action when translating it to flow_action infra") Signed-off-by: Leon Romanovsky <leonro@nvidia.com> Acked-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2020-10-15 09:10:11 -07:00
..
acpi	ACPI updates for 5.9-rc1	2020-08-03 20:37:22 -07:00
asm-generic	bpf: Prevent .BTF section elimination	2020-09-21 21:50:44 +02:00
clocksource	include/: replace HTTP links with HTTPS ones	2020-08-12 10:57:59 -07:00
crypto	mm, treewide: rename kzfree() to kfree_sensitive()	2020-08-07 11:33:22 -07:00
drm	drm-misc-fixes for v5.9:	2020-10-06 12:38:28 +10:00
dt-bindings	Here's some more updates that missed the last pull request because I	2020-08-12 12:19:49 -07:00
keys	It's been a busy cycle for documentation - hopefully the busiest for a	2020-08-04 22:47:54 -07:00
kunit
kvm
linux	drm fixes for 5.9 final	2020-10-06 11:05:44 -07:00
math-emu	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
media	media: media/v4l2: remove V4L2_FLAG_MEMORY_NON_CONSISTENT flag	2020-09-14 15:28:06 +02:00
memory
misc
net	net: sched: Fix suspicious RCU usage while accessing tcf_tunnel_info	2020-10-15 09:10:11 -07:00
pcmcia
ras
rdma	RDMA 5.9 merge window pull request	2020-08-06 16:43:36 -07:00
scsi
soc	net: mscc: ocelot: fix fields offset in SG_CONFIG_REG_3	2020-09-24 20:00:40 -07:00
sound	ASoC: core: Do not cleanup uninitialized dais on soc_pcm_open failure	2020-09-07 12:40:24 +01:00
target	scsi: target: Make iscsit_register_transport() return void	2020-08-04 20:56:56 -04:00
trace	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-09-03 18:50:48 -07:00
uapi	rxrpc fixes	2020-10-06 06:18:20 -07:00
vdso	lib/vdso: Allow to add architecture-specific vdso data	2020-08-06 10:57:30 +02:00
video
xen	arm/arm64: xen: Fix to convert percpu address to gfn correctly	2020-10-07 07:08:43 +02:00