linux/drivers/net/wireless/atmel
Gustavo A. R. Silva b0c4058816 atmel: at76c50x: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200319225133.GA29672@embeddedor.com
2020-03-23 19:17:11 +02:00
..
at76c50x-usb.c at76c50x-usb: fix endpoint debug message 2019-12-18 21:06:02 +02:00
at76c50x-usb.h atmel: at76c50x: Replace zero-length array with flexible-array member 2020-03-23 19:17:11 +02:00
atmel_cs.c atmel: remove set but not used variable 'dev' 2019-10-24 08:48:31 +03:00
atmel_pci.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 106 2019-05-24 17:39:01 +02:00
atmel.c atmel: Replace mdelay() with msleep() in probe_atmel_card() 2018-07-31 10:25:33 +03:00
atmel.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 106 2019-05-24 17:39:01 +02:00
Kconfig drivers: net: Fix Kconfig indentation, continued 2019-11-21 11:54:09 -08:00
Makefile treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00