Florian Westphal cefa31a9d4
netfilter: nft_log: perform module load from nf_tables ...
modprobe calls from the nf_logger_find_get() API causes deadlock in very
special cases because they occur with the nf_tables transaction mutex held.
In the specific case of nf_log, deadlock is via:
A nf_tables -> transaction mutex -> nft_log -> modprobe -> nf_log_syslog \
-> pernet_ops rwsem -> wait for C
B netlink event -> rtnl_mutex -> nf_tables transaction mutex -> wait for A
C close() -> ip6mr_sk_done -> rtnl_mutex -> wait for B
Earlier patch added NFLOG/xt_LOG module softdeps to avoid the need to load
the backend module during a transaction.
For nft_log we would have to add a softdep for both nfnetlink_log or
nf_log_syslog, since we do not know in advance which of the two backends
are going to be configured.
This defers the modprobe op until after the transaction mutex is released.
Tested-by: Phil Sutter <phil@nwl.cc >
Signed-off-by: Florian Westphal <fw@strlen.de >
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org >
2021-03-31 22:34:11 +02:00
2020-11-19 17:21:34 +01:00
2021-02-01 17:04:17 +01:00
2020-09-29 14:02:53 -07:00
2021-01-28 20:36:21 -08:00
2021-03-31 22:34:11 +02:00
2021-03-30 13:29:39 -07:00
2020-12-04 17:47:35 -08:00
2019-06-05 17:37:07 +02:00
2020-11-05 14:27:30 -08:00
2021-03-13 14:18:09 -08:00
2020-02-28 14:51:30 +01:00
2021-02-16 17:51:13 -08:00
2020-08-18 15:58:53 -07:00
2019-05-30 11:26:41 -07:00
2020-08-20 18:21:28 +01:00
2020-02-28 12:12:53 -08:00
2019-12-11 15:01:23 -08:00
2019-11-06 16:14:48 -08:00
2019-01-23 11:18:00 -08:00
2019-06-19 17:09:55 +02:00
2020-07-21 18:30:47 -07:00
2019-05-24 17:37:53 +02:00
2020-05-01 12:15:37 -07:00
2019-07-04 12:30:48 -07:00
2021-01-18 20:48:40 -08:00
2020-11-12 18:39:28 -08:00
2020-12-01 15:51:19 +01:00
2019-05-21 11:28:45 +02:00
2019-06-19 17:09:55 +02:00
2021-02-12 09:33:34 +01:00
2020-02-29 14:39:08 +01:00
2020-08-20 15:45:15 -04:00
2020-07-15 07:45:24 -07:00
2020-03-27 19:40:38 -07:00
2020-11-23 13:31:54 -08:00
2019-05-30 11:29:52 -07:00
2019-05-30 11:29:52 -07:00
2021-02-11 13:04:49 -08:00
2020-02-29 21:52:20 -08:00
2019-05-21 11:52:39 +02:00
2019-05-21 11:52:39 +02:00
2021-03-18 16:24:06 -07:00
2019-12-16 16:09:44 -08:00
2020-05-08 21:33:33 -07:00
2021-03-10 12:24:18 -08:00
2020-05-05 13:23:29 -07:00
2020-02-19 13:52:32 +01:00
2020-04-20 07:34:16 +02:00
2019-06-19 17:09:55 +02:00
2019-12-24 22:37:30 -08:00
2020-07-28 17:42:31 -07:00
2021-03-14 14:46:32 -07:00
2021-03-24 12:48:39 -07:00
2020-11-23 18:36:21 -05:00
2021-01-21 13:33:45 +01:00
2021-01-21 13:33:45 +01:00
2019-12-09 10:36:44 -08:00
2019-11-05 18:20:55 -08:00
2021-02-12 16:31:46 -08:00
2019-03-22 12:09:31 -07:00
2021-01-29 20:39:14 -08:00
2021-03-18 19:51:12 -07:00
2020-06-22 21:12:44 -07:00
2019-10-25 16:24:32 -07:00
2021-02-23 11:29:52 -08:00
2020-11-06 11:01:01 +01:00
2019-05-30 11:26:41 -07:00
2021-03-26 15:14:56 -07:00
2019-04-22 21:50:53 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2020-03-30 13:45:04 -07:00
2021-01-27 18:18:15 -08:00
2021-03-15 14:34:29 -07:00
2020-12-14 18:38:58 -08:00
2020-12-12 15:08:54 -08:00
2020-11-23 16:32:33 -08:00
2020-08-26 07:33:19 -07:00
2019-09-27 12:05:02 +02:00
2019-02-08 21:50:15 -08:00
2020-06-20 17:47:53 -07:00
2021-02-08 16:47:03 -08:00
2021-01-26 18:39:45 -08:00
2019-06-18 20:48:45 -04:00
2021-02-08 16:47:03 -08:00
2020-11-19 19:08:46 -08:00
2021-02-04 18:37:57 -08:00
2020-11-10 17:56:54 -08:00
2020-11-19 10:49:50 -08:00
2021-03-30 13:29:39 -07:00
2021-03-11 16:09:21 -08:00
2020-02-05 14:28:09 +01:00
2019-06-19 17:09:55 +02:00
2020-06-20 17:22:22 -07:00
2021-03-23 14:14:50 -07:00
2019-10-08 13:23:05 -07:00
2020-03-29 22:30:57 -07:00
2021-01-26 11:55:50 +01:00
2019-05-30 11:26:41 -07:00
2020-03-26 20:17:36 -07:00
2020-03-02 11:16:27 -08:00
2021-03-26 15:14:56 -07:00
2020-02-28 12:08:37 -08:00
2020-05-29 21:20:20 -07:00
2021-03-12 17:47:45 -08:00
2019-12-09 10:36:44 -08:00
2020-08-24 06:40:07 -07:00
2020-11-13 14:24:39 -08:00
2021-02-11 14:10:07 -08:00
2019-05-21 11:28:45 +02:00
2020-11-16 08:08:54 -08:00
2019-11-12 08:18:03 -08:00
2019-04-11 13:59:49 -07:00
2021-03-28 17:53:39 -07:00
2020-11-14 02:29:00 +01:00
2020-03-04 13:25:55 -08:00
2019-05-30 11:26:32 -07:00
2021-01-22 20:41:29 -08:00
2021-03-10 12:45:16 -08:00
2019-05-30 11:26:32 -07:00
2021-03-14 15:00:43 -07:00
2019-05-30 11:26:32 -07:00
2021-03-19 11:51:03 -07:00
2020-07-31 09:24:23 +02:00
2020-08-24 14:35:00 -07:00
2020-11-23 18:36:21 -05:00
2020-06-23 20:27:09 -07:00
2021-03-16 08:40:04 +01:00
2019-04-22 21:47:25 -07:00
2021-03-13 14:18:09 -08:00
2020-07-13 11:03:44 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2020-06-04 15:39:32 -07:00
2020-09-28 15:19:03 -07:00
2019-10-05 16:29:00 -07:00
2020-02-29 21:52:19 -08:00
2021-03-12 12:27:14 -08:00
2019-06-19 17:09:55 +02:00
2021-03-23 14:49:05 -07:00
2019-05-30 11:26:32 -07:00
2021-02-26 12:28:03 -08:00
2019-05-30 11:26:32 -07:00
2019-10-04 14:07:07 -07:00
2020-11-27 18:25:27 -08:00
2020-06-23 20:10:15 -07:00
2020-06-18 20:46:23 -07:00
2021-02-04 18:37:14 -08:00
2021-02-26 12:28:03 -08:00
2019-11-14 18:12:17 -08:00
2020-09-14 16:49:39 -07:00
2019-12-09 10:28:43 -08:00
2019-11-16 12:39:10 -08:00
2020-11-17 22:07:40 +01:00
2021-03-10 01:06:34 +01:00
2021-02-04 01:00:07 +01:00
2020-10-05 18:40:01 -07:00
2020-12-18 16:10:21 +01:00
cefa31a9d4