linux/drivers/s390/block
Jan Höppner cd68c48ea1 s390/dasd: Fix read for ESE with blksize < 4k
When reading unformatted tracks on ESE devices, the corresponding memory
areas are simply set to zero for each segment. This is done incorrectly
for blocksizes < 4096.

There are two problems. First, the increment of dst is done using the
counter of the loop (off), which is increased by blksize every
iteration. This leads to a much bigger increment for dst as actually
intended. Second, the increment of dst is done before the memory area
is set to 0, skipping a significant amount of bytes of memory.

This leads to illegal overwriting of memory and ultimately to a kernel
panic.

This is not a problem with 4k blocksize because
blk_queue_max_segment_size is set to PAGE_SIZE, always resulting in a
single iteration for the inner segment loop (bv.bv_len == blksize). The
incorrectly used 'off' value to increment dst is 0 and the correct
memory area is used.

In order to fix this for blksize < 4k, increment dst correctly using the
blksize and only do it at the end of the loop.

Fixes: 5e2b17e712 ("s390/dasd: Add dynamic formatting support for ESE volumes")
Cc: stable@vger.kernel.org # v5.3+
Signed-off-by: Jan Höppner <hoeppner@linux.ibm.com>
Reviewed-by: Stefan Haberland <sth@linux.ibm.com>
Link: https://lore.kernel.org/r/20220505141733.1989450-4-sth@linux.ibm.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2022-05-05 20:08:27 -06:00
..
dasd_3990_erp.c s390/dasd: handle request magic consistently as unsigned int 2021-10-20 08:10:41 -06:00
dasd_alias.c s390/dasd: fix list corruption of lcu list 2020-12-17 13:41:30 -07:00
dasd_devmap.c s390/dasd: use default_groups in kobj_type 2022-01-08 17:44:05 +01:00
dasd_diag.c s390/extable: move EX_TABLE define to asm-extable.h 2022-03-08 00:33:00 +01:00
dasd_diag.h
dasd_eckd.c s390/dasd: Fix read for ESE with blksize < 4k 2022-05-05 20:08:27 -06:00
dasd_eckd.h s390/dasd: summarize dasd configuration data in a separate structure 2021-10-20 08:10:42 -06:00
dasd_eer.c
dasd_erp.c s390/dasd: handle request magic consistently as unsigned int 2021-10-20 08:10:41 -06:00
dasd_fba.c dasd: use bvec_virt 2021-08-16 10:50:33 -06:00
dasd_fba.h
dasd_genhd.c s390 updates for the 5.16 merge window 2021-11-06 14:48:06 -07:00
dasd_int.h s390/dasd: prevent double format of tracks for ESE devices 2022-05-05 20:08:27 -06:00
dasd_ioctl.c s390/dasd: fix kernel doc comment 2021-10-20 08:10:41 -06:00
dasd_proc.c
dasd.c s390/dasd: prevent double format of tracks for ESE devices 2022-05-05 20:08:27 -06:00
dcssblk.c dax: remove the copy_from_iter and copy_to_iter methods 2021-12-18 08:04:53 -08:00
Kconfig dax: remove CONFIG_DAX_DRIVER 2021-12-04 08:58:51 -08:00
Makefile s390: remove xpram device driver 2021-09-07 13:38:42 +02:00
scm_blk.c block: remove genhd.h 2022-02-02 07:49:59 -07:00
scm_blk.h block: remove genhd.h 2022-02-02 07:49:59 -07:00
scm_drv.c s390/scm: Make struct scm_driver::remove return void 2021-07-21 11:53:42 +02:00