leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity
cd56a51413
linux/drivers/media/pci/cx18
History
Nathan Chancellor eb1ca9a428 media: cx18: Don't check for address of video_dev 
Clang warns that the address of a pointer will always evaluated as true
in a boolean context.

drivers/media/pci/cx18/cx18-driver.c:1255:23: warning: address of
'cx->streams[i].video_dev' will always evaluate to 'true'
[-Wpointer-bool-conversion]
                if (&cx->streams[i].video_dev)
                ~~   ~~~~~~~~~~~~~~~^~~~~~~~~
1 warning generated.

Check whether v4l2_dev is null, not the address, so that the statement
doesn't fire all the time. This check has been present since 2009,
introduced by commit 21a278b85d ("V4L/DVB (11619): cx18: Simplify the
work handler for outgoing mailbox commands")

Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
2018-10-08 12:02:08 -04:00
..
cx18-alsa-main.c media: use strscpy() instead of strlcpy() 2018-09-11 13:32:17 -04:00
cx18-alsa-pcm.c media: use strscpy() instead of strlcpy() 2018-09-11 13:32:17 -04:00
cx18-alsa-pcm.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-alsa.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-audio.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-audio.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-av-audio.c media: replace all <spaces><tab> occurrences 2018-01-04 13:15:05 -05:00
cx18-av-core.c media: replace all <spaces><tab> occurrences 2018-01-04 13:15:05 -05:00
cx18-av-core.h media: replace all <spaces><tab> occurrences 2018-01-04 13:15:05 -05:00
cx18-av-firmware.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-av-vbi.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-cards.c media: use strscpy() instead of strlcpy() 2018-09-11 13:32:17 -04:00
cx18-cards.h media: replace all <spaces><tab> occurrences 2018-01-04 13:15:05 -05:00
cx18-controls.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-controls.h [media] cx231xx: constify cx2341x_handler_ops structures 2015-12-03 11:27:08 -02:00
cx18-driver.c media: cx18: Don't check for address of video_dev 2018-10-08 12:02:08 -04:00
cx18-driver.h media: replace all <spaces><tab> occurrences 2018-01-04 13:15:05 -05:00
cx18-dvb.c media: dvb: fix location of get_dvb_firmware script 2018-06-15 18:10:01 -03:00
cx18-dvb.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-fileops.c vfs: do bulk POLL* -> EPOLL* replacement 2018-02-11 14:34:03 -08:00
cx18-fileops.h media: annotate ->poll() instances 2017-11-27 16:20:06 -05:00
cx18-firmware.c media: replace all <spaces><tab> occurrences 2018-01-04 13:15:05 -05:00
cx18-firmware.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-gpio.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-gpio.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-i2c.c media: use strscpy() instead of strlcpy() 2018-09-11 13:32:17 -04:00
cx18-i2c.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-io.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-io.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-ioctl.c media: use strscpy() instead of strlcpy() 2018-09-11 13:32:17 -04:00
cx18-ioctl.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-irq.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-irq.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-mailbox.c media: replace all <spaces><tab> occurrences 2018-01-04 13:15:05 -05:00
cx18-mailbox.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-queue.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-queue.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-scb.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-scb.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-streams.c media: v4l: fix broken video4linux docs locations 2018-06-15 18:10:01 -03:00
cx18-streams.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-vbi.c media: replace all <spaces><tab> occurrences 2018-01-04 13:15:05 -05:00
cx18-vbi.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-version.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-video.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx18-video.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cx23418.h media: replace all <spaces><tab> occurrences 2018-01-04 13:15:05 -05:00
Kconfig
Makefile media: move dvb kAPI headers to include/media 2017-12-28 13:16:01 -05:00