leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
cd2b0389dc
linux/drivers/net/ethernet/broadcom/bnx2x
History
Joe Perches cd2b0389dc bnx2x: Remove hidden flow control goto from BNX2X_ALLOC macros 
BNX2X_ALLOC macros use "goto alloc_mem_err"
so these labels appear unused in some functions.

Expand these macros in-place via coccinelle and
some typing.

Update the macros to use statement expressions
and remove the BNX2X_ALLOC macro.

This adds some > 80 char lines.

$ cat bnx2x_pci_alloc.cocci
@@
expression e1;
expression e2;
expression e3;
@@
-	BNX2X_PCI_ALLOC(e1, e2, e3);
+	e1 = BNX2X_PCI_ALLOC(e2, e3); if (!e1) goto alloc_mem_err;

@@
expression e1;
expression e2;
expression e3;
@@
-	BNX2X_PCI_FALLOC(e1, e2, e3);
+	e1 = BNX2X_PCI_FALLOC(e2, e3); if (!e1) goto alloc_mem_err;

@@
expression e1;
expression e2;
@@
-	BNX2X_ALLOC(e1, e2);
+	e1 = kzalloc(e2, GFP_KERNEL); if (!e1) goto alloc_mem_err;

@@
expression e1;
expression e2;
expression e3;
@@
-	kzalloc(sizeof(e1) * e2, e3)
+	kcalloc(e2, sizeof(e1), e3)

@@
expression e1;
expression e2;
expression e3;
@@
-	kzalloc(e1 * sizeof(e2), e3)
+	kcalloc(e1, sizeof(e2), e3)

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-02-25 17:36:35 -05:00
..
bnx2x_cmn.c bnx2x: Remove hidden flow control goto from BNX2X_ALLOC macros 2014-02-25 17:36:35 -05:00
bnx2x_cmn.h bnx2x: Remove hidden flow control goto from BNX2X_ALLOC macros 2014-02-25 17:36:35 -05:00
bnx2x_dcb.c bnx2x: (semantic) revise scheduling of sp_rtnl 2014-02-12 19:15:42 -05:00
bnx2x_dcb.h bnx2x: Change DCB context handling 2013-08-20 00:21:47 -07:00
bnx2x_dump.h bnx2x: Revise comments and alignment 2013-06-02 21:36:47 -07:00
bnx2x_ethtool.c bnx2x: Fix generic option settings 2014-01-28 18:08:57 -08:00
bnx2x_fw_defs.h bnx2x: Remove unnecessary internal mem config 2014-02-12 19:15:41 -05:00
bnx2x_fw_file_hdr.h bnx2x: Introduce 2013 and advance version to 1.78.02 2013-01-15 15:07:59 -05:00
bnx2x_hsi.h bnx2x: utilize FW 7.8.19 2014-02-12 19:15:42 -05:00
bnx2x_init_ops.h bnx2x: Remove many sparse warnings 2013-01-23 13:58:29 -05:00
bnx2x_init.h bnx2x: Don't pretend during register dump 2013-10-21 18:31:36 -04:00
bnx2x_link.c bnx2x: fix sparse warning 2014-01-15 15:06:47 -08:00
bnx2x_link.h bnx2x: namespace and dead code cleanups 2014-01-13 11:59:47 -08:00
bnx2x_main.c bnx2x: Remove hidden flow control goto from BNX2X_ALLOC macros 2014-02-25 17:36:35 -05:00
bnx2x_mfw_req.h bnx2x: Introduce 2013 and advance version to 1.78.02 2013-01-15 15:07:59 -05:00
bnx2x_reg.h Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2014-01-06 17:37:45 -05:00
bnx2x_sp.c bnx2x: Revise IOV vlan/mac validation 2014-02-12 19:15:42 -05:00
bnx2x_sp.h bnx2x: Revise IOV vlan/mac validation 2014-02-12 19:15:42 -05:00
bnx2x_sriov.c bnx2x: Remove hidden flow control goto from BNX2X_ALLOC macros 2014-02-25 17:36:35 -05:00
bnx2x_sriov.h bnx2x: Revise IOV vlan/mac validation 2014-02-12 19:15:42 -05:00
bnx2x_stats.c bnx2x: Lock DMAE when used by statistic flow 2013-10-21 18:31:35 -04:00
bnx2x_stats.h bnx2x: Fix VF stats sync 2013-08-27 22:03:04 -04:00
bnx2x_vfpf.c bnx2x: Revise IOV vlan/mac validation 2014-02-12 19:15:42 -05:00
bnx2x_vfpf.h bnx2x: Add support in PF driver for RSC 2014-02-12 19:15:41 -05:00
bnx2x.h bnx2x: utilize FW 7.8.19 2014-02-12 19:15:42 -05:00
Makefile bnx2x: Segregate SR-IOV code 2013-01-07 19:49:14 -08:00