c7302f2044
As we need to acquire a mutex to serialise the final intel_wakeref_put, we need to ensure that we are in process context at that time. However, we want to allow operation on the intel_wakeref from inside timer and other hardirq context, which means that need to defer that final put to a workqueue. Inside the final wakeref puts, we are safe to operate in any context, as we are simply marking up the HW and state tracking for the potential sleep. It's only the serialisation with the potential sleeping getting that requires careful wait avoidance. This allows us to retain the immediate processing as before (we only need to sleep over the same races as the current mutex_lock). v2: Add a selftest to ensure we exercise the code while lockdep watches. v3: That test was extremely loud and complained about many things! v4: Not a whale! Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111295 References: https://bugs.freedesktop.org/show_bug.cgi?id=111245 References: https://bugs.freedesktop.org/show_bug.cgi?id=111256 Fixes:18398904ca
("drm/i915: Only recover active engines") Fixes:51fbd8de87
("drm/i915/pmu: Atomically acquire the gt_pm wakeref") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190808202758.10453-1-chris@chris-wilson.co.uk
175 lines
4.0 KiB
C
175 lines
4.0 KiB
C
/*
|
|
* SPDX-License-Identifier: MIT
|
|
*
|
|
* Copyright © 2019 Intel Corporation
|
|
*/
|
|
|
|
#include "i915_drv.h"
|
|
#include "i915_params.h"
|
|
#include "intel_engine_pm.h"
|
|
#include "intel_gt.h"
|
|
#include "intel_gt_pm.h"
|
|
#include "intel_pm.h"
|
|
#include "intel_wakeref.h"
|
|
|
|
static void pm_notify(struct drm_i915_private *i915, int state)
|
|
{
|
|
blocking_notifier_call_chain(&i915->gt.pm_notifications, state, i915);
|
|
}
|
|
|
|
static int __gt_unpark(struct intel_wakeref *wf)
|
|
{
|
|
struct intel_gt *gt = container_of(wf, typeof(*gt), wakeref);
|
|
struct drm_i915_private *i915 = gt->i915;
|
|
|
|
GEM_TRACE("\n");
|
|
|
|
/*
|
|
* It seems that the DMC likes to transition between the DC states a lot
|
|
* when there are no connected displays (no active power domains) during
|
|
* command submission.
|
|
*
|
|
* This activity has negative impact on the performance of the chip with
|
|
* huge latencies observed in the interrupt handler and elsewhere.
|
|
*
|
|
* Work around it by grabbing a GT IRQ power domain whilst there is any
|
|
* GT activity, preventing any DC state transitions.
|
|
*/
|
|
gt->awake = intel_display_power_get(i915, POWER_DOMAIN_GT_IRQ);
|
|
GEM_BUG_ON(!gt->awake);
|
|
|
|
intel_enable_gt_powersave(i915);
|
|
|
|
i915_update_gfx_val(i915);
|
|
if (INTEL_GEN(i915) >= 6)
|
|
gen6_rps_busy(i915);
|
|
|
|
i915_pmu_gt_unparked(i915);
|
|
|
|
intel_gt_queue_hangcheck(gt);
|
|
|
|
pm_notify(i915, INTEL_GT_UNPARK);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int __gt_park(struct intel_wakeref *wf)
|
|
{
|
|
struct drm_i915_private *i915 =
|
|
container_of(wf, typeof(*i915), gt.wakeref);
|
|
intel_wakeref_t wakeref = fetch_and_zero(&i915->gt.awake);
|
|
|
|
GEM_TRACE("\n");
|
|
|
|
pm_notify(i915, INTEL_GT_PARK);
|
|
|
|
i915_pmu_gt_parked(i915);
|
|
if (INTEL_GEN(i915) >= 6)
|
|
gen6_rps_idle(i915);
|
|
|
|
/* Everything switched off, flush any residual interrupt just in case */
|
|
intel_synchronize_irq(i915);
|
|
|
|
GEM_BUG_ON(!wakeref);
|
|
intel_display_power_put(i915, POWER_DOMAIN_GT_IRQ, wakeref);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct intel_wakeref_ops wf_ops = {
|
|
.get = __gt_unpark,
|
|
.put = __gt_park,
|
|
.flags = INTEL_WAKEREF_PUT_ASYNC,
|
|
};
|
|
|
|
void intel_gt_pm_init_early(struct intel_gt *gt)
|
|
{
|
|
intel_wakeref_init(>->wakeref, >->i915->runtime_pm, &wf_ops);
|
|
|
|
BLOCKING_INIT_NOTIFIER_HEAD(>->pm_notifications);
|
|
}
|
|
|
|
static bool reset_engines(struct intel_gt *gt)
|
|
{
|
|
if (INTEL_INFO(gt->i915)->gpu_reset_clobbers_display)
|
|
return false;
|
|
|
|
return __intel_gt_reset(gt, ALL_ENGINES) == 0;
|
|
}
|
|
|
|
/**
|
|
* intel_gt_sanitize: called after the GPU has lost power
|
|
* @gt: the i915 GT container
|
|
* @force: ignore a failed reset and sanitize engine state anyway
|
|
*
|
|
* Anytime we reset the GPU, either with an explicit GPU reset or through a
|
|
* PCI power cycle, the GPU loses state and we must reset our state tracking
|
|
* to match. Note that calling intel_gt_sanitize() if the GPU has not
|
|
* been reset results in much confusion!
|
|
*/
|
|
void intel_gt_sanitize(struct intel_gt *gt, bool force)
|
|
{
|
|
struct intel_engine_cs *engine;
|
|
enum intel_engine_id id;
|
|
|
|
GEM_TRACE("\n");
|
|
|
|
intel_uc_sanitize(>->uc);
|
|
|
|
if (!reset_engines(gt) && !force)
|
|
return;
|
|
|
|
for_each_engine(engine, gt->i915, id)
|
|
__intel_engine_reset(engine, false);
|
|
}
|
|
|
|
int intel_gt_resume(struct intel_gt *gt)
|
|
{
|
|
struct intel_engine_cs *engine;
|
|
enum intel_engine_id id;
|
|
int err = 0;
|
|
|
|
/*
|
|
* After resume, we may need to poke into the pinned kernel
|
|
* contexts to paper over any damage caused by the sudden suspend.
|
|
* Only the kernel contexts should remain pinned over suspend,
|
|
* allowing us to fixup the user contexts on their first pin.
|
|
*/
|
|
intel_gt_pm_get(gt);
|
|
for_each_engine(engine, gt->i915, id) {
|
|
struct intel_context *ce;
|
|
|
|
intel_engine_pm_get(engine);
|
|
|
|
ce = engine->kernel_context;
|
|
if (ce)
|
|
ce->ops->reset(ce);
|
|
|
|
engine->serial++; /* kernel context lost */
|
|
err = engine->resume(engine);
|
|
|
|
intel_engine_pm_put(engine);
|
|
if (err) {
|
|
dev_err(gt->i915->drm.dev,
|
|
"Failed to restart %s (%d)\n",
|
|
engine->name, err);
|
|
break;
|
|
}
|
|
}
|
|
intel_gt_pm_put(gt);
|
|
|
|
return err;
|
|
}
|
|
|
|
void intel_gt_runtime_suspend(struct intel_gt *gt)
|
|
{
|
|
intel_uc_runtime_suspend(>->uc);
|
|
}
|
|
|
|
int intel_gt_runtime_resume(struct intel_gt *gt)
|
|
{
|
|
intel_gt_init_swizzling(gt);
|
|
|
|
return intel_uc_runtime_resume(>->uc);
|
|
}
|