hsr_link_ops implements ->newlink() but not ->dellink(), which leads that resources not released after removing the device, particularly the entries in self_node_db and node_db. So add ->dellink() implementation to replace the priv_destructor. This also makes the code slightly easier to understand. Reported-by: syzbot+c6167ec3de7def23d1e8@syzkaller.appspotmail.com Cc: Arvid Brodin <arvid.brodin@alten.se> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
		
			
				
	
	
		
			65 lines
		
	
	
		
			2.0 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			65 lines
		
	
	
		
			2.0 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /* SPDX-License-Identifier: GPL-2.0 */
 | |
| /* Copyright 2011-2014 Autronica Fire and Security AS
 | |
|  *
 | |
|  * Author(s):
 | |
|  *	2011-2014 Arvid Brodin, arvid.brodin@alten.se
 | |
|  */
 | |
| 
 | |
| #ifndef __HSR_FRAMEREG_H
 | |
| #define __HSR_FRAMEREG_H
 | |
| 
 | |
| #include "hsr_main.h"
 | |
| 
 | |
| struct hsr_node;
 | |
| 
 | |
| void hsr_del_self_node(struct list_head *self_node_db);
 | |
| void hsr_del_nodes(struct list_head *node_db);
 | |
| struct hsr_node *hsr_add_node(struct list_head *node_db, unsigned char addr[],
 | |
| 			      u16 seq_out);
 | |
| struct hsr_node *hsr_get_node(struct hsr_port *port, struct sk_buff *skb,
 | |
| 			      bool is_sup);
 | |
| void hsr_handle_sup_frame(struct sk_buff *skb, struct hsr_node *node_curr,
 | |
| 			  struct hsr_port *port);
 | |
| bool hsr_addr_is_self(struct hsr_priv *hsr, unsigned char *addr);
 | |
| 
 | |
| void hsr_addr_subst_source(struct hsr_node *node, struct sk_buff *skb);
 | |
| void hsr_addr_subst_dest(struct hsr_node *node_src, struct sk_buff *skb,
 | |
| 			 struct hsr_port *port);
 | |
| 
 | |
| void hsr_register_frame_in(struct hsr_node *node, struct hsr_port *port,
 | |
| 			   u16 sequence_nr);
 | |
| int hsr_register_frame_out(struct hsr_port *port, struct hsr_node *node,
 | |
| 			   u16 sequence_nr);
 | |
| 
 | |
| void hsr_prune_nodes(struct timer_list *t);
 | |
| 
 | |
| int hsr_create_self_node(struct list_head *self_node_db,
 | |
| 			 unsigned char addr_a[ETH_ALEN],
 | |
| 			 unsigned char addr_b[ETH_ALEN]);
 | |
| 
 | |
| void *hsr_get_next_node(struct hsr_priv *hsr, void *_pos,
 | |
| 			unsigned char addr[ETH_ALEN]);
 | |
| 
 | |
| int hsr_get_node_data(struct hsr_priv *hsr,
 | |
| 		      const unsigned char *addr,
 | |
| 		      unsigned char addr_b[ETH_ALEN],
 | |
| 		      unsigned int *addr_b_ifindex,
 | |
| 		      int *if1_age,
 | |
| 		      u16 *if1_seq,
 | |
| 		      int *if2_age,
 | |
| 		      u16 *if2_seq);
 | |
| 
 | |
| struct hsr_node {
 | |
| 	struct list_head	mac_list;
 | |
| 	unsigned char		macaddress_A[ETH_ALEN];
 | |
| 	unsigned char		macaddress_B[ETH_ALEN];
 | |
| 	/* Local slave through which AddrB frames are received from this node */
 | |
| 	enum hsr_port_type	addr_B_port;
 | |
| 	unsigned long		time_in[HSR_PT_PORTS];
 | |
| 	bool			time_in_stale[HSR_PT_PORTS];
 | |
| 	u16			seq_out[HSR_PT_PORTS];
 | |
| 	struct rcu_head		rcu_head;
 | |
| };
 | |
| 
 | |
| #endif /* __HSR_FRAMEREG_H */
 |