leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
c9438092cae4a5bdbd146ca1385e85dcd6e847f8
linux/arch/powerpc/kvm
History
Paul Mackerras c9438092ca KVM: PPC: Book3S HV: Take SRCU read lock around kvm_read_guest() call 
Running a kernel with CONFIG_PROVE_RCU=y yields the following diagnostic:

===============================
[ INFO: suspicious RCU usage. ]
3.12.0-rc5-kvm+ #9 Not tainted
-------------------------------

include/linux/kvm_host.h:473 suspicious rcu_dereference_check() usage!

other info that might help us debug this:

rcu_scheduler_active = 1, debug_locks = 0
1 lock held by qemu-system-ppc/4831:

stack backtrace:
CPU: 28 PID: 4831 Comm: qemu-system-ppc Not tainted 3.12.0-rc5-kvm+ #9
Call Trace:
[c000000be462b2a0] [c00000000001644c] .show_stack+0x7c/0x1f0 (unreliable)
[c000000be462b370] [c000000000ad57c0] .dump_stack+0x88/0xb4
[c000000be462b3f0] [c0000000001315e8] .lockdep_rcu_suspicious+0x138/0x180
[c000000be462b480] [c00000000007862c] .gfn_to_memslot+0x13c/0x170
[c000000be462b510] [c00000000007d384] .gfn_to_hva_prot+0x24/0x90
[c000000be462b5a0] [c00000000007d420] .kvm_read_guest_page+0x30/0xd0
[c000000be462b630] [c00000000007d528] .kvm_read_guest+0x68/0x110
[c000000be462b6e0] [c000000000084594] .kvmppc_rtas_hcall+0x34/0x180
[c000000be462b7d0] [c000000000097934] .kvmppc_pseries_do_hcall+0x74/0x830
[c000000be462b880] [c0000000000990e8] .kvmppc_vcpu_run_hv+0xff8/0x15a0
[c000000be462b9e0] [c0000000000839cc] .kvmppc_vcpu_run+0x2c/0x40
[c000000be462ba50] [c0000000000810b4] .kvm_arch_vcpu_ioctl_run+0x54/0x1b0
[c000000be462bae0] [c00000000007b508] .kvm_vcpu_ioctl+0x478/0x730
[c000000be462bca0] [c00000000025532c] .do_vfs_ioctl+0x4dc/0x7a0
[c000000be462bd80] [c0000000002556b4] .SyS_ioctl+0xc4/0xe0
[c000000be462be30] [c000000000009ee4] syscall_exit+0x0/0x98

To fix this, we take the SRCU read lock around the kvmppc_rtas_hcall()
call.

Signed-off-by: Paul Mackerras <paulus@samba.org>
Signed-off-by: Alexander Graf <agraf@suse.de>
2013-11-18 22:41:20 +01:00
..
44x_emulate.c
kvm: powerpc: Add kvmppc_ops callback
2013-10-17 15:24:26 +02:00
44x_tlb.c
kvm: powerpc: Add kvmppc_ops callback
2013-10-17 15:24:26 +02:00
44x_tlb.h
KVM: ppc: rename 44x MMU functions used in booke.c
2009-03-24 11:02:56 +02:00
44x.c
kvm: powerpc: book3s: Allow the HV and PR selection per virtual machine
2013-10-17 18:42:36 +02:00
book3s_32_mmu_host.c
kvm: powerpc: Add kvmppc_ops callback
2013-10-17 15:24:26 +02:00
book3s_32_mmu.c
KVM: PPC: Book3S PR: Better handling of host-side read-only pages
2013-10-17 14:49:35 +02:00
book3s_32_sr.S
KVM: PPC: book3s_pr: Simplify transitions between virtual and real mode
2011-09-25 19:52:29 +03:00
book3s_64_mmu_host.c
kvm: powerpc: book3s: pr: move PR related tracepoints to a separate header
2013-10-17 15:36:22 +02:00
book3s_64_mmu_hv.c
KVM: PPC: Book3S HV: Fix physical address calculations
2013-11-18 22:36:09 +01:00
book3s_64_mmu.c
KVM: PPC: Book3S PR: Better handling of host-side read-only pages
2013-10-17 14:49:35 +02:00
book3s_64_slb.S
powerpc: Fix little endian lppaca, slb_shadow and dtl_entry
2013-08-14 15:33:35 +10:00
book3s_64_vio_hv.c
kvm: powerpc: book3s: move book3s_64_vio_hv.c into the main kernel binary
2013-10-17 15:17:25 +02:00
book3s_64_vio.c
ppc: kvm: use anon_inode_getfd() with O_CLOEXEC flag
2013-08-26 13:19:56 +03:00
book3s_emulate.c
kvm: powerpc: book3s: Support building HV and PR KVM as module
2013-10-17 15:45:35 +02:00
book3s_exports.c
kvm: powerpc: book3s: Add a new config variable CONFIG_KVM_BOOK3S_HV_POSSIBLE
2013-10-17 15:18:28 +02:00
book3s_hv_builtin.c
powerpc/kvm: Contiguous memory allocator based RMA allocation
2013-07-08 16:20:20 +02:00
book3s_hv_cma.c
powerpc/kvm: Use 256K chunk to track both RMA and hash page table allocation.
2013-07-08 16:21:13 +02:00
book3s_hv_cma.h
powerpc/kvm: Use 256K chunk to track both RMA and hash page table allocation.
2013-07-08 16:21:13 +02:00
book3s_hv_interrupts.S
kvm: powerpc: book3s: remove kvmppc_handler_highmem label
2013-10-17 15:15:56 +02:00
book3s_hv_ras.c
KVM: PPC: Book3S HV: Fix compilation without CONFIG_PPC_POWERNV
2013-01-06 14:02:00 +01:00
book3s_hv_rm_mmu.c
KVM: PPC: Book3S HV: Fix physical address calculations
2013-11-18 22:36:09 +01:00
book3s_hv_rm_xics.c
KVM: PPC: Book3S HV: Add support for real mode ICP in XICS emulation
2013-04-26 20:27:32 +02:00
book3s_hv_rmhandlers.S
KVM: PPC: Book3S HV: Refine barriers in guest entry/exit
2013-11-18 22:38:30 +01:00
book3s_hv.c
KVM: PPC: Book3S HV: Take SRCU read lock around kvm_read_guest() call
2013-11-18 22:41:20 +01:00
book3s_interrupts.S
kvm: powerpc: Add kvmppc_ops callback
2013-10-17 15:24:26 +02:00
book3s_mmu_hpte.c
kvm: powerpc: book3s: pr: move PR related tracepoints to a separate header
2013-10-17 15:36:22 +02:00
book3s_paired_singles.c
powerpc/kvm: Fallout from system.h disintegration
2012-04-02 14:00:04 +10:00
book3s_pr_papr.c
KVM: PPC: Book3S PR: Make HPT accesses and updates SMP-safe
2013-10-17 14:45:04 +02:00
book3s_pr.c
Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm
2013-11-15 13:51:36 +09:00
book3s_rmhandlers.S
KVM: PPC: Book3S: Move skip-interrupt handlers to common code
2013-10-17 14:49:35 +02:00
book3s_rtas.c
kvm: powerpc: book3s: Support building HV and PR KVM as module
2013-10-17 15:45:35 +02:00
book3s_segment.S
kvm: powerpc: book3s: Cleanup interrupt handling code
2013-10-17 15:26:31 +02:00
book3s_xics.c
kvm: powerpc: book3s: drop is_hv_enabled
2013-10-17 18:43:34 +02:00
book3s_xics.h
KVM: PPC: Book3S: Add API for in-kernel XICS emulation
2013-05-02 15:28:36 +02:00
book3s.c
kvm: powerpc: book3s: drop is_hv_enabled
2013-10-17 18:43:34 +02:00
book3s.h
kvm: powerpc: book3s: Allow the HV and PR selection per virtual machine
2013-10-17 18:42:36 +02:00
booke_emulate.c
KVM: PPC: BookE: Emulate mfspr on EPR
2013-01-10 13:42:30 +01:00
booke_interrupts.S
KVM: PPC: booke: Added debug handler
2013-03-22 01:21:09 +01:00
booke.c
Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm
2013-11-15 13:51:36 +09:00
booke.h
kvm: powerpc: Add kvmppc_ops callback
2013-10-17 15:24:26 +02:00
bookehv_interrupts.S
KVM: PPC: bookehv64: Add support for interrupt handling
2012-12-06 01:34:11 +01:00
e500_emulate.c
kvm: powerpc: Add kvmppc_ops callback
2013-10-17 15:24:26 +02:00
e500_mmu_host.c
Merge branch 'kvm-ppc-queue' of git://github.com/agraf/linux-2.6 into queue
2013-11-04 10:20:57 +02:00
e500_mmu_host.h
KVM: PPC: E500: Make clear_tlb_refs and clear_tlb1_bitmap static
2013-01-24 19:23:33 +01:00
e500_mmu.c
kvm: powerpc: booke: Move booke related tracepoints to separate header
2013-10-17 15:37:16 +02:00
e500.c
kvm: powerpc: book3s: Allow the HV and PR selection per virtual machine
2013-10-17 18:42:36 +02:00
e500.h
kvm: powerpc: allow guest control "G" attribute in mas2
2013-10-17 14:49:37 +02:00
e500mc.c
kvm: powerpc: book3s: Allow the HV and PR selection per virtual machine
2013-10-17 18:42:36 +02:00
emulate.c
kvm: powerpc: book3s: Allow the HV and PR selection per virtual machine
2013-10-17 18:42:36 +02:00
fpu.S
powerpc: Remove fpscr use from [kvm_]cvt_{fd,df}
2010-09-02 14:07:32 +10:00
irq.h
KVM: PPC: Book3S: Add API for in-kernel XICS emulation
2013-05-02 15:28:36 +02:00
Kconfig
Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm
2013-11-15 13:51:36 +09:00
Makefile
kvm: powerpc: book3s: Support building HV and PR KVM as module
2013-10-17 15:45:35 +02:00
mpic.c
kvm/ppc/mpic: fix missing unlock in set_base_addr()
2013-05-02 15:28:35 +02:00
powerpc.c
kvm: powerpc: book3s: drop is_hv_enabled
2013-10-17 18:43:34 +02:00
timing.c
KVM: PPC: fix partial application of "exit timing in ticks"
2011-07-12 13:16:28 +03:00
timing.h
KVM: PPC: booke: category E.HV (GS-mode) support
2012-04-08 12:51:19 +03:00
trace_booke.h
kvm: powerpc: booke: Move booke related tracepoints to separate header
2013-10-17 15:37:16 +02:00
trace_pr.h
kvm: powerpc: book3s: pr: move PR related tracepoints to a separate header
2013-10-17 15:36:22 +02:00
trace.h
kvm: powerpc: booke: Move booke related tracepoints to separate header
2013-10-17 15:37:16 +02:00