Huazhong Tan c8a8045b2d net: hns3: Fix NULL deref when unloading driver ... When the driver is unloading, if there is a calling of ndo_open occurs between phy_disconnect() and unregister_netdev(), it will end up causing the kernel to eventually hit a NULL deref: [14942.417828] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000048 [14942.529878] Mem abort info: [14942.551166] ESR = 0x96000006 [14942.567070] Exception class = DABT (current EL), IL = 32 bits [14942.623081] SET = 0, FnV = 0 [14942.639112] EA = 0, S1PTW = 0 [14942.643628] Data abort info: [14942.659227] ISV = 0, ISS = 0x00000006 [14942.674870] CM = 0, WnR = 0 [14942.679449] user pgtable: 4k pages, 48-bit VAs, pgdp = 00000000224ad6ad [14942.695595] [0000000000000048] pgd=00000021e6673003, pud=00000021dbf01003, pmd=0000000000000000 [14942.723163] Internal error: Oops: 96000006 [#1] PREEMPT SMP [14942.729358] Modules linked in: hns3(O) hclge(O) pv680_mii(O) hnae3(O) [last unloaded: hclge] [14942.738907] CPU: 1 PID: 26629 Comm: kworker/u4:13 Tainted: G O 4.18.0-rc1-12928-ga960791-dirty #145 [14942.749491] Hardware name: Huawei Technologies Co., Ltd. D05/D05, BIOS Hi1620 FPGA TB BOOT BIOS B763 08/17/2018 [14942.760392] Workqueue: events_power_efficient phy_state_machine [14942.766644] pstate: 80c00009 (Nzcv daif +PAN +UAO) [14942.771918] pc : test_and_set_bit+0x18/0x38 [14942.776589] lr : netif_carrier_off+0x24/0x70 [14942.781033] sp : ffff0000121abd20 [14942.784518] x29: ffff0000121abd20 x28: 0000000000000000 [14942.790208] x27: ffff0000164d3cd8 x26: ffff8021da68b7b8 [14942.795832] x25: 0000000000000000 x24: ffff8021eb407800 [14942.801445] x23: 0000000000000000 x22: 0000000000000000 [14942.807046] x21: 0000000000000001 x20: 0000000000000000 [14942.812672] x19: 0000000000000000 x18: ffff000009781708 [14942.818284] x17: 00000000004970e8 x16: ffff00000816ad48 [14942.823900] x15: 0000000000000000 x14: 0000000000000008 [14942.829528] x13: 0000000000000000 x12: 0000000000000f65 [14942.835149] x11: 0000000000000001 x10: 00000000000009d0 [14942.840753] x9 : ffff0000121abaa0 x8 : 0000000000000000 [14942.846360] x7 : ffff000009781708 x6 : 0000000000000003 [14942.851970] x5 : 0000000000000020 x4 : 0000000000000004 [14942.857575] x3 : 0000000000000002 x2 : 0000000000000001 [14942.863180] x1 : 0000000000000048 x0 : 0000000000000000 [14942.868875] Process kworker/u4:13 (pid: 26629, stack limit = 0x00000000c909dbf3) [14942.876464] Call trace: [14942.879200] test_and_set_bit+0x18/0x38 [14942.883376] phy_link_change+0x38/0x78 [14942.887378] phy_state_machine+0x3dc/0x4f8 [14942.891968] process_one_work+0x158/0x470 [14942.896223] worker_thread+0x50/0x470 [14942.900219] kthread+0x104/0x130 [14942.903905] ret_from_fork+0x10/0x1c [14942.907755] Code: d2800022 8b400c21 f9800031 9ac32044 (c85f7c22) [14942.914185] ---[ end trace 968c9e12eb740b23 ]--- So this patch fixes it by modifying the timing to do phy_connect_direct() and phy_disconnect(). Fixes: 256727da73 ("net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC") Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com> Signed-off-by: Peng Li <lipeng321@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-01-30 14:50:03 -08:00
..
accessibility
acpi	acpi/nfit: Fix command-supported detection	2019-01-21 09:58:31 -08:00
amba
android	binderfs: switch from d_add() to d_instantiate()	2019-01-22 12:25:54 +01:00
ata	SCSI fixes on 20190125	2019-01-26 15:03:43 -08:00
atm	atm: he: fix sign-extension overflow on large shift	2019-01-17 11:27:00 -08:00
auxdisplay	auxdisplay: charlcd: fix x/y command parsing	2018-12-21 21:27:21 +01:00
base	regmap: Fixes for v5.0	2019-01-19 07:17:19 +12:00
bcma
block	for-linus-20190118	2019-01-20 09:12:50 +12:00
bluetooth	Bluetooth: hci_bcm: Handle specific unknown packets after firmware loading	2018-12-19 13:43:42 +01:00
bus	ARM: SoC driver updates	2018-12-31 17:32:35 -08:00
cdrom	gdrom: fix a memory leak bug	2018-12-29 08:20:44 -07:00
char	Char/Misc driver fixes for 5.0-rc4	2019-01-25 13:03:34 -10:00
clk	clk: socfpga: stratix10: fix naming convention for the fixed-clocks	2019-01-15 12:58:38 -08:00
clocksource	arch/csky patches for 4.21-rc1	2019-01-05 09:50:07 -08:00
connector
cpufreq	Merge branches 'pm-cpuidle', 'pm-cpufreq' and 'pm-sleep'	2019-01-11 10:09:51 +01:00
cpuidle	powerpc updates for 4.21	2018-12-27 10:43:24 -08:00
crypto	net/tls: free ctx in sock destruct	2019-01-22 11:30:54 -08:00
dax	mm, devm_memremap_pages: fix shutdown handling	2018-12-28 12:11:47 -08:00
dca
devfreq
dio
dma	cross-tree: phase out dma_zalloc_coherent()	2019-01-08 07:58:37 -05:00
dma-buf	drivers/dma-buf/udmabuf.c: convert to use vm_fault_t	2019-01-04 13:13:46 -08:00
edac	EDAC, altera: Fix S10 persistent register offset	2019-01-24 17:13:59 +01:00
eisa
extcon
firewire	scsi: communicate max segment size to the DMA mapping code	2019-01-22 20:40:59 -05:00
firmware	arm64 fixes for -rc1	2019-01-05 11:28:39 -08:00
fmc
fpga	Remove 'type' argument from access_ok() function	2019-01-03 18:57:57 -08:00
fsi
gnss
gpio	gpio: pca953x: Make symbol 'pca953x_i2c_regmap' static	2019-01-11 09:16:40 +01:00
gpu	Merge tag 'drm-msm-fixes-2019-01-24' of git://people.freedesktop.org/~robclark/linux into drm-fixes	2019-01-25 07:45:00 +10:00
hid	HID: core: simplify active collection tracking	2019-01-16 14:29:48 +01:00
hsi
hv	vmbus: fix subchannel removal	2019-01-09 19:20:31 -05:00
hwmon	hwmon: (tmp421) Correct the misspelling of the tmp442 compatible attribute in OF device ID table	2019-01-17 12:54:52 -08:00
hwspinlock	hwspinlock: fix return value check in stm32_hwspinlock_probe()	2019-01-03 11:42:10 -08:00
hwtracing	intel_th: msu: Fix an off-by-one in attribute store	2018-12-19 20:21:06 +01:00
i2c	i2c: tegra: Fix Maximum transfer size	2019-01-11 00:15:04 +01:00
i3c	i3c: master: Fix an error checking typo in 'cdns_i3c_master_probe()'	2019-01-22 13:56:37 +01:00
ide	ide: fix a typo in the settings proc file name	2019-01-22 15:08:12 +13:00
idle
iio	- New Device Support	2019-01-15 06:24:36 +12:00
infiniband	First 5.0 rc pull request	2019-01-18 17:17:20 +12:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2019-01-27 09:07:03 -08:00
iommu	IOMMU Fix for Linux v5.0-rc3	2019-01-22 07:27:17 +13:00
ipack
irqchip	irqchip updates for 5.0-rc3	2019-01-18 23:32:29 +01:00
isdn	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-01-21 14:41:32 -08:00
leds	leds: lp5523: fix a missing check of return value of lp55xx_read	2019-01-17 22:27:39 +01:00
lightnvm	lightnvm: pblk: fix use-after-free bug	2018-12-22 14:45:35 -07:00
macintosh	Remove 'type' argument from access_ok() function	2019-01-03 18:57:57 -08:00
mailbox	mailbox: tegra-hsp: Use device-managed registration API	2018-12-21 22:31:26 -06:00
mcb
md	- Fix DM crypt's parsing of extended IV arguments.	2019-01-25 09:07:18 +13:00
media	media: vim2m: only cancel work if it is for right context	2019-01-16 11:13:25 -05:00
memory	ARM: SoC: late updates	2019-01-05 11:30:37 -08:00
memstick	MMC core:	2018-12-28 16:52:18 -08:00
message	scsi: flip the default on use_clustering	2018-12-18 23:13:12 -05:00
mfd	- New Device Support	2019-01-15 06:24:36 +12:00
misc	Char/Misc driver fixes for 5.0-rc4	2019-01-25 13:03:34 -10:00
mmc	MMC host:	2019-01-25 13:07:03 -10:00
mtd	mtd: rawnand: denali: get ->setup_data_interface() working again	2019-01-18 10:27:01 +01:00
mux
net	net: hns3: Fix NULL deref when unloading driver	2019-01-30 14:50:03 -08:00
nfc
ntb	cross-tree: phase out dma_zalloc_coherent()	2019-01-08 07:58:37 -05:00
nubus
nvdimm	libnvdimm/security: Require nvdimm_security_setup_events() to succeed	2019-01-21 09:57:43 -08:00
nvme	for-linus-20190125	2019-01-26 12:42:41 -08:00
nvmem
of	OF: properties: add missing of_node_put	2019-01-16 12:49:53 -06:00
opp	cpufreq: scpi/scmi: Fix freeing of dynamic OPPs	2019-01-04 12:19:40 +01:00
oprofile
parisc	Kconfig file consolidation for v4.21	2018-12-29 13:40:29 -08:00
parport
pci	pci-v5.0-fixes-2	2019-01-19 07:26:16 +12:00
pcmcia	Included in this update:	2019-01-05 11:23:17 -08:00
perf	drivers/perf: hisi: Fixup one DDRC PMU register offset	2019-01-04 10:13:27 +00:00
phy	USB/PHY fixes for 5.0-rc4	2019-01-25 12:57:09 -10:00
pinctrl	Pin control bulk changes for the v4.21 kernel cycle:	2019-01-01 13:19:16 -08:00
platform	platform/x86: apple-gmux: Make PCI dependency explicit	2019-01-15 23:17:16 +01:00
pnp	Remove 'type' argument from access_ok() function	2019-01-03 18:57:57 -08:00
power	power supply and reset changes for the v4.21 series	2018-12-28 20:22:45 -08:00
powercap
pps	Kconfig updates for v4.21	2018-12-29 13:03:29 -08:00
ps3
ptp	ptp: fix debugfs_simple_attr.cocci warnings	2019-01-25 22:05:23 -08:00
pwm	pwm: imx: Add ipg clock operation	2018-12-24 12:06:56 +01:00
rapidio	cross-tree: phase out dma_zalloc_coherent()	2019-01-08 07:58:37 -05:00
ras	treewide: surround Kconfig file paths with double quotes	2018-12-22 00:25:54 +09:00
regulator	Merge remote-tracking branch 'regulator/topic/coupled' into regulator-next	2018-12-21 13:43:35 +00:00
remoteproc	virtio: don't allocate vqs when names[i] = NULL	2019-01-14 20:15:19 -05:00
reset	reset: uniphier-glue: Add AHCI reset control support in glue layer	2019-01-07 16:38:51 +01:00
rpmsg
rtc	RTC for 4.21	2019-01-01 13:24:31 -08:00
s390	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-01-27 10:43:17 -08:00
sbus	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc-next	2018-12-26 10:32:18 -08:00
scsi	SCSI fixes on 20190125	2019-01-26 15:03:43 -08:00
sfi
sh
siox
slimbus
sn
soc	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-01-16 05:13:36 +12:00
soundwire
spi	cross-tree: phase out dma_zalloc_coherent()	2019-01-08 07:58:37 -05:00
spmi
ssb
staging	staging: android: ion: Support cpu access during dma_buf_detach	2019-01-22 11:38:09 +01:00
target	scsi: tcmu: fix use after free	2019-01-22 20:54:00 -05:00
tc
tee	OP-TEE dynamic shm log message	2018-12-31 13:06:30 -08:00
thermal	Merge branch 'for-rc' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux	2019-01-23 16:23:41 +13:00
thunderbolt
tty	serial: fsl_lpuart: fix maximum acceptable baud rate with over-sampling	2019-01-22 09:32:08 +01:00
uio	Char/Misc driver patches for 4.21-rc1	2018-12-28 20:54:57 -08:00
usb	USB-serial fixes for 5.0-rc3	2019-01-18 12:58:20 +01:00
uwb
vfio	vfio-pci/nvlink2: Fix ancient gcc warnings	2019-01-23 08:20:43 -07:00
vhost	vhost: fix OOB in get_rx_bufs()	2019-01-28 22:53:09 -08:00
video	TTY/Serial driver fixes for 5.0-rc4	2019-01-25 12:58:40 -10:00
virt
virtio	virtio-balloon: tweak config_changed implementation	2019-01-14 20:15:20 -05:00
visorbus
vlynq
vme
w1	treewide: surround Kconfig file paths with double quotes	2018-12-22 00:25:54 +09:00
watchdog	watchdog: tqmx86: Fix a couple IS_ERR() vs NULL bugs	2019-01-07 10:10:35 +01:00
xen	arm64/xen: fix xen-swiotlb cache flushing	2019-01-23 22:14:56 +01:00
zorro
Kconfig	Kconfig file consolidation for v4.21	2018-12-29 13:40:29 -08:00
Makefile