linux/drivers/tty/serial/8250
Valmer Huhn c6b9e95dde serial: 8250_exar: Fix number of ports for Commtech PCIe cards
The following in 8250_exar.c line 589 is used to determine the number
of ports for each Exar board:

nr_ports = board->num_ports ? board->num_ports : pcidev->device & 0x0f;

If the number of ports a card has is not explicitly specified, it defaults
to the rightmost 4 bits of the PCI device ID. This is prone to error since
not all PCI device IDs contain a number which corresponds to the number of
ports that card provides.

This particular case involves COMMTECH_4222PCIE, COMMTECH_4224PCIE and
COMMTECH_4228PCIE cards with device IDs 0x0022, 0x0020 and 0x0021.
Currently the multiport cards receive 2, 0 and 1 port instead of 2, 4 and
8 ports respectively.

To fix this, each Commtech Fastcom PCIe card is given a struct where the
number of ports is explicitly specified. This ensures 'board->num_ports'
is used instead of the default 'pcidev->device & 0x0f'.

Fixes: d0aeaa83f0 ("serial: exar: split out the exar code from 8250_pci")
Signed-off-by: Valmer Huhn <valmer.huhn@concurrent-rt.com>
Tested-by: Valmer Huhn <valmer.huhn@concurrent-rt.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200813165255.GC345440@icarus.concurrent-rt.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-08-18 13:27:26 +02:00
..
8250_accent.c tty: serial: Remove redundant license text 2017-11-08 13:08:12 +01:00
8250_acorn.c tty: serial: Remove redundant license text 2017-11-08 13:08:12 +01:00
8250_aspeed_vuart.c serial: 8250: Check UPF_IRQ_SHARED in advance 2020-02-12 11:56:44 -08:00
8250_bcm2835aux.c serial: 8250_bcm2835aux: Support rs485 software emulation 2020-03-07 09:52:02 +01:00
8250_boca.c tty: serial: Remove redundant license text 2017-11-08 13:08:12 +01:00
8250_core.c serial: 8250: fix null-ptr-deref in serial8250_start_tx() 2020-07-21 21:23:18 +02:00
8250_dma.c serial: 8250: factor out serial8250_{set,clear}_THRI() helpers 2019-06-18 09:36:55 +02:00
8250_dw.c serial: 8250_dw: Fix common clocks usage race condition 2020-07-29 17:14:39 +02:00
8250_dwlib.c serial: 8250_dw: split Synopsys DesignWare 8250 common functions 2019-09-04 12:43:52 +02:00
8250_dwlib.h tty: serial: Use the correct style for SPDX License Identifier 2020-03-07 09:52:01 +01:00
8250_early.c serial: 8250_early: Support kgdboc_earlycon 2020-06-02 15:15:46 +01:00
8250_em.c serial: 8250_em: Switch to use platform_get_irq() 2020-06-27 16:12:45 +02:00
8250_exar_st16c554.c tty: serial: Remove redundant license text 2017-11-08 13:08:12 +01:00
8250_exar.c serial: 8250_exar: Fix number of ports for Commtech PCIe cards 2020-08-18 13:27:26 +02:00
8250_fintek.c serial: 8250_fintek: Add F81966 Support 2020-05-29 13:00:54 +02:00
8250_fourport.c tty: serial: Remove redundant license text 2017-11-08 13:08:12 +01:00
8250_fsl.c tty/serial: Migrate 8250_fsl to use has_sysrq 2019-12-18 15:04:42 +01:00
8250_gsc.c remove ioremap_nocache and devm_ioremap_nocache 2020-01-06 09:45:59 +01:00
8250_hp300.c tty: add SPDX identifiers to all remaining files in drivers/tty/ 2017-11-08 13:08:12 +01:00
8250_hub6.c tty: serial: Remove redundant license text 2017-11-08 13:08:12 +01:00
8250_ingenic.c serial: 8250_ingenic: Switch to use platform_get_irq() 2020-06-27 16:12:56 +02:00
8250_ioc3.c Fix up remaining devm_ioremap_nocache() in SGI IOC3 8250 UART driver 2020-02-08 14:19:39 -08:00
8250_lpc18xx.c tty: Remove dev_err() usage after platform_get_irq() 2019-09-04 12:43:49 +02:00
8250_lpss.c serial: 8250_lpss: Add ->setup() for Elkhart Lake ports 2020-03-06 13:31:19 +01:00
8250_men_mcb.c 8250-men-mcb: fix signed/unsigned confusion 2020-06-27 16:12:45 +02:00
8250_mid.c tty: serial: Remove redundant license text 2017-11-08 13:08:12 +01:00
8250_mtk.c Linux 5.8-rc7 2020-07-27 12:40:56 +02:00
8250_of.c serial: 8250: Generalize rs485 software emulation 2020-03-07 09:52:02 +01:00
8250_omap.c serial: 8250_omap: Switch to use platform_get_irq() 2020-06-27 16:12:45 +02:00
8250_pci.c serial: 8250_pci: Move Pericom IDs to pci_ids.h 2020-05-08 16:54:09 -05:00
8250_pnp.c serial: 8250_pnp: Move to struct dev_pm_ops 2019-09-04 12:43:46 +02:00
8250_port.c Revert "serial: 8250: Let serial core initialise spin lock" 2020-08-02 13:24:30 +02:00
8250_pxa.c serial: 8250_pxa: Switch to use platform_get_irq() 2020-06-27 16:12:56 +02:00
8250_tegra.c serial: 8250_tegra: Create Tegra specific 8250 driver 2020-02-10 12:34:44 -08:00
8250_uniphier.c tty: Remove dev_err() usage after platform_get_irq() 2019-09-04 12:43:49 +02:00
8250.h serial: 8250: Generalize rs485 software emulation 2020-03-07 09:52:02 +01:00
Kconfig tty: serial: Replace HTTP links with HTTPS ones 2020-07-21 20:04:54 +02:00
Makefile serial: 8250_tegra: Create Tegra specific 8250 driver 2020-02-10 12:34:44 -08:00
serial_cs.c drivers/tty: remove redundant assignment to variable i and rename it to ret 2020-04-16 16:12:34 +02:00