linux/fs/ecryptfs
Michael Halcrow c59c2eb53f eCryptfs: remove unnecessary BUG_ON
Andrew Morton wrote:
> > +     mutex_lock(&mount_crypt_stat->global_auth_tok_list_mutex);
> > +     BUG_ON(mount_crypt_stat->num_global_auth_toks == 0);
> > +     mutex_unlock(&mount_crypt_stat->global_auth_tok_list_mutex);
>
> That's odd-looking.  If it was a bug for num_global_auth_toks to be
> zero, and if that mutex protects num_global_auth_toks then as soon
> as the lock gets dropped, another thread can make
> num_global_auth_toks zero, hence the bug is present.  Perhaps?

That was serving as an internal sanity check that should not have made
it into the final patch set in the first place. This patch removes it.

Signed-off-by: Michael Halcrow <mhalcrow@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-10-16 09:43:11 -07:00
..
crypto.c eCryptfs: remove unnecessary BUG_ON 2007-10-16 09:43:11 -07:00
debug.c eCryptfs: update comment and debug statement 2007-10-16 09:43:11 -07:00
dentry.c [PATCH] eCryptfs: fix possible NULL ptr deref in ecryptfs_d_release() 2007-03-16 19:25:05 -07:00
ecryptfs_kernel.h eCryptfs: add key list structure; search keyring 2007-10-16 09:43:10 -07:00
file.c sendfile: remove .sendfile from filesystems that use generic_file_sendfile() 2007-07-10 08:04:13 +02:00
inode.c revert "eCryptfs: fix lookup error for special files" 2007-08-31 01:42:22 -07:00
keystore.c ecryptfs: printk warning fixes 2007-10-16 09:43:11 -07:00
main.c ecryptfs: printk warning fixes 2007-10-16 09:43:11 -07:00
Makefile [PATCH] eCryptfs: Public key; packet management 2007-02-12 09:48:36 -08:00
messaging.c Detach sched.h from mm.h 2007-05-21 09:18:19 -07:00
mmap.c fs: remove some AOP_TRUNCATED_PAGE 2007-10-16 09:42:58 -07:00
netlink.c [NET]: make netlink user -> kernel interface synchronious 2007-10-10 21:15:29 -07:00
super.c [PATCH] Mark struct super_operations const 2007-02-12 09:48:47 -08:00