Chao Yu c2a080aefa f2fs: fix to set superblock dirty correctly ... tests/generic/251 of fstest suit complains us with below message: ------------[ cut here ]------------ invalid opcode: 0000 [#1] PREEMPT SMP CPU: 2 PID: 7698 Comm: fstrim Tainted: G O 4.7.0+ #21 task: e9f4e000 task.stack: e7262000 EIP: 0060:[<f89fcefe>] EFLAGS: 00010202 CPU: 2 EIP is at write_checkpoint+0xfde/0x1020 [f2fs] EAX: f33eb300 EBX: eecac310 ECX: 00000001 EDX: ffff0001 ESI: eecac000 EDI: eecac5f0 EBP: e7263dec ESP: e7263d18 DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068 CR0: 80050033 CR2: b76ab01c CR3: 2eb89de0 CR4: 000406f0 Stack: 00000001 a220fb7b e9f4e000 00000002 419ff2d3 b3a05151 00000002 e9f4e5d8 e9f4e000 419ff2d3 b3a05151 eecac310 c10b8154 b3a05151 419ff2d3 c10b78bd e9f4e000 e9f4e000 e9f4e5d8 00000001 e9f4e000 ec409000 eecac2cc eecac288 Call Trace: [<c10b8154>] ? __lock_acquire+0x3c4/0x760 [<c10b78bd>] ? mark_held_locks+0x5d/0x80 [<f8a10632>] f2fs_trim_fs+0x1c2/0x2e0 [f2fs] [<f89e9f56>] f2fs_ioctl+0x6b6/0x10b0 [f2fs] [<c13d51df>] ? __this_cpu_preempt_check+0xf/0x20 [<c10b4281>] ? trace_hardirqs_off_caller+0x91/0x120 [<f89e98a0>] ? __exchange_data_block+0xd30/0xd30 [f2fs] [<c120b2e1>] do_vfs_ioctl+0x81/0x7f0 [<c11d57c5>] ? kmem_cache_free+0x245/0x2e0 [<c1217840>] ? get_unused_fd_flags+0x40/0x40 [<c1206eec>] ? putname+0x4c/0x50 [<c11f631e>] ? do_sys_open+0x16e/0x1d0 [<c1001990>] ? do_fast_syscall_32+0x30/0x1c0 [<c13d51df>] ? __this_cpu_preempt_check+0xf/0x20 [<c120baa8>] SyS_ioctl+0x58/0x80 [<c1001a01>] do_fast_syscall_32+0xa1/0x1c0 [<c178cc54>] sysenter_past_esp+0x45/0x74 EIP: [<f89fcefe>] write_checkpoint+0xfde/0x1020 [f2fs] SS:ESP 0068:e7263d18 ---[ end trace 4de95d7e6b3aa7c6 ]--- The reason is: with below call stack, we will encounter BUG_ON during doing fstrim. Thread A Thread B - write_checkpoint - do_checkpoint - f2fs_write_inode - update_inode_page - update_inode - set_page_dirty - f2fs_set_node_page_dirty - inc_page_count - percpu_counter_inc - set_sbi_flag(SBI_IS_DIRTY) - clear_sbi_flag(SBI_IS_DIRTY) Thread C Thread D - f2fs_write_node_page - set_node_addr - __set_nat_cache_dirty - nm_i->dirty_nat_cnt++ - do_vfs_ioctl - f2fs_ioctl - f2fs_trim_fs - write_checkpoint - f2fs_bug_on(nm_i->dirty_nat_cnt) Fix it by setting superblock dirty correctly in do_checkpoint and f2fs_write_node_page. Signed-off-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>		2016-09-07 18:53:47 -07:00
..
acl.c	f2fs: avoid mark_inode_dirty	2016-07-08 10:34:09 -07:00
acl.h	f2fs: clean up coding style and redundancy	2016-07-25 12:58:12 -07:00
checkpoint.c	f2fs: fix to set superblock dirty correctly	2016-09-07 18:53:47 -07:00
data.c	f2fs: fix to preallocate block only aligned to 4K	2016-08-29 18:31:15 -07:00
debug.c	f2fs: add discard info to sys entry of f2fs status	2016-08-29 18:31:06 -07:00
dir.c	f2fs: add roll-forward recovery process for encrypted dentry	2016-09-07 17:27:40 -07:00
extent_cache.c	f2fs: disable extent_cache for fcollapse/finsert inodes	2016-07-15 15:21:20 -07:00
f2fs.h	f2fs: add roll-forward recovery process for encrypted dentry	2016-09-07 17:27:40 -07:00
file.c	f2fs: add roll-forward recovery process for encrypted dentry	2016-09-07 17:27:40 -07:00
gc.c	f2fs: do in batch synchronously readahead during GC	2016-09-07 17:27:34 -07:00
gc.h	f2fs: detect idle time depending on user behavior	2016-01-11 15:56:37 -08:00
hash.c	f2fs: introduce dot and dotdot name check	2015-05-28 15:41:34 -07:00
inline.c	f2fs: set encryption name flag in add inline entry path	2016-09-07 17:27:37 -07:00
inode.c	f2fs: avoid mark_inode_dirty	2016-07-08 10:34:09 -07:00
Kconfig	f2fs: add mount option to select fault injection ratio	2016-05-07 10:32:22 -07:00
Makefile	fs crypto: move per-file encryption from f2fs tree to fs/crypto	2016-03-17 21:19:33 -07:00
namei.c	f2fs: fix to report error number of f2fs_find_entry	2016-07-20 14:53:19 -07:00
node.c	f2fs: remove redundant judgement condition in available_free_memory	2016-08-29 18:31:12 -07:00
node.h	f2fs: produce more nids and reduce readahead nats	2016-07-06 10:44:08 -07:00
recovery.c	f2fs: add roll-forward recovery process for encrypted dentry	2016-09-07 17:27:40 -07:00
segment.c	f2fs: support async discard	2016-09-07 17:27:38 -07:00
segment.h	f2fs: not allow to write illegal blkaddr	2016-08-24 10:16:14 -07:00
shrinker.c	f2fs: produce more nids and reduce readahead nats	2016-07-06 10:44:08 -07:00
super.c	f2fs: enable inline_dentry by default and add noinline_dentry option	2016-08-29 18:31:17 -07:00
trace.c	f2fs: use bio op accessors	2016-06-07 13:41:38 -06:00
trace.h	f2fs: add sbi and page pointer in f2fs_io_info	2015-05-28 15:41:32 -07:00
xattr.c	f2fs: fix lost xattrs of directories	2016-09-07 17:27:39 -07:00
xattr.h	f2fs: add missing argument to f2fs_setxattr stub	2016-03-17 21:19:47 -07:00