This was simply making templates of functions and mostly causing a lot of code duplication in the classifier action modules. We solve this more cleanly by having a common "struct tcf_common" that hash worker functions contained once in act_api.c can work with. Callers work with real action objects that have the common struct plus their module specific struct members. You go from a common object to the higher level one using a "to_foo()" macro which makes use of container_of() to do the dirty work. This also kills off act_generic.h which was only used by act_simple.c and keeping it around was more work than the it's value. Signed-off-by: David S. Miller <davem@davemloft.net>
		
			
				
	
	
		
			16 lines
		
	
	
		
			307 B
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			16 lines
		
	
	
		
			307 B
		
	
	
	
		
			C
		
	
	
	
	
	
| #ifndef __NET_TC_PED_H
 | |
| #define __NET_TC_PED_H
 | |
| 
 | |
| #include <net/act_api.h>
 | |
| 
 | |
| struct tcf_pedit {
 | |
| 	struct tcf_common	common;
 | |
| 	unsigned char		tcfp_nkeys;
 | |
| 	unsigned char		tcfp_flags;
 | |
| 	struct tc_pedit_key	*tcfp_keys;
 | |
| };
 | |
| #define to_pedit(pc) \
 | |
| 	container_of(pc, struct tcf_pedit, common)
 | |
| 
 | |
| #endif /* __NET_TC_PED_H */
 |