linux/drivers/gpu/drm/msm
John Stultz bc8bd54ffd drm/msm: Fix 0xfffflub in "Refactor address space initialization"
This week I started seeing GPU crashes on my DragonBoard 845c
which I narrowed down to being caused by commit ccac7ce373
("drm/msm: Refactor address space initialization").

Looking through the patch, Jordan and I couldn't find anything
obviously wrong, so I ended up breaking that change up into a
number of smaller logical steps so I could figure out which part
was causing the trouble.

Ends up, visually counting 'f's is hard, esp across a number
of lines:
  0xfffffff != 0xffffffff

This patch corrects the end value we pass in to
msm_gem_address_space_create() in
adreno_iommu_create_address_space() so that it matches the value
used before the problematic patch landed.

With this change, I no longer see the GPU crashes that were
affecting me.

Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Jordan Crouse <jcrouse@codeaurora.org>
Cc: freedreno@lists.freedesktop.org
Fixes: ccac7ce373 ("drm/msm: Refactor address space initialization")
Signed-off-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
2020-06-12 21:59:11 -07:00
..
adreno drm/msm: Fix 0xfffflub in "Refactor address space initialization" 2020-06-12 21:59:11 -07:00
disp drm/msm/dpu: allow initialization of encoder locks during encoder init 2020-06-11 20:09:21 -07:00
dsi Linux 5.6-rc5 2020-03-11 07:27:21 +10:00
edp Merge tag 'drm-msm-next-2020-03-22' of https://gitlab.freedesktop.org/drm/msm into drm-next 2020-03-31 16:34:55 +10:00
hdmi Merge tag 'drm-msm-next-2020-03-22' of https://gitlab.freedesktop.org/drm/msm into drm-next 2020-03-31 16:34:55 +10:00
Kconfig drm/msm/gpu: add ocmem init/cleanup functions 2019-10-07 08:17:39 -07:00
Makefile drm/msm/dpu: add support for color processing blocks in dpu driver 2020-05-18 09:26:32 -07:00
msm_atomic_trace.h drm/msm: add atomic traces 2019-09-03 16:17:02 -07:00
msm_atomic_tracepoints.c drm/msm: add atomic traces 2019-09-03 16:17:02 -07:00
msm_atomic.c drm/msm: add atomic traces 2019-09-03 16:17:02 -07:00
msm_debugfs.c drm/msm: fix memleak on release 2019-11-13 15:34:15 -05:00
msm_debugfs.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234 2019-06-19 17:09:07 +02:00
msm_drv.c drm/msm: Add syncobj support. 2020-05-18 09:26:32 -07:00
msm_drv.h drm/msm: Refactor address space initialization 2020-05-23 13:38:16 -07:00
msm_fb.c drm/msm: drop use of drmP.h 2019-09-03 16:16:57 -07:00
msm_fbdev.c drm: Remove drm_fb_helper add, add all and remove connector calls 2020-03-06 14:19:58 +01:00
msm_fence.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234 2019-06-19 17:09:07 +02:00
msm_fence.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234 2019-06-19 17:09:07 +02:00
msm_gem_prime.c drm/msm: drop use of drmP.h 2019-09-03 16:16:57 -07:00
msm_gem_shrinker.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234 2019-06-19 17:09:07 +02:00
msm_gem_submit.c drm/msm: Add syncobj support. 2020-05-18 09:26:32 -07:00
msm_gem_vma.c drm/msm: Refactor address space initialization 2020-05-23 13:38:16 -07:00
msm_gem.c drm/msm: add internal MSM_BO_MAP_PRIV flag 2020-05-18 09:26:33 -07:00
msm_gem.h drm/msm: add internal MSM_BO_MAP_PRIV flag 2020-05-18 09:26:33 -07:00
msm_gpu_trace.h drm/msm: add atomic traces 2019-09-03 16:17:02 -07:00
msm_gpu_tracepoints.c drm/msm/gpu: Add trace events for tracking GPU submissions 2018-12-11 13:05:28 -05:00
msm_gpu.c drm/msm: Refactor address space initialization 2020-05-23 13:38:16 -07:00
msm_gpu.h drm/msm: Refactor address space initialization 2020-05-23 13:38:16 -07:00
msm_gpummu.c drm/msm: Update the MMU helper function APIs 2020-05-23 13:38:16 -07:00
msm_iommu.c drm/msm: Update the MMU helper function APIs 2020-05-23 13:38:16 -07:00
msm_kms.h drm/msm/dpu: async commit support 2019-09-03 16:17:01 -07:00
msm_mmu.h drm/msm: Update the MMU helper function APIs 2020-05-23 13:38:16 -07:00
msm_perf.c drm/msm: drop use of drmP.h 2019-09-03 16:16:57 -07:00
msm_rd.c drm/msm: Fix undefined "rd_full" link error 2020-05-18 09:26:32 -07:00
msm_ringbuffer.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234 2019-06-19 17:09:07 +02:00
msm_ringbuffer.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234 2019-06-19 17:09:07 +02:00
msm_submitqueue.c drm/msm: fix potential memleak in error branch 2020-06-11 20:06:12 -07:00
NOTES