Enric Balletbo i Serra ca01e79874 PCI: rockchip: Fix IO outbound ATU register number ... Since 62240a8800 ("PCI: rockchip: Drop storing driver private outbound resource data), the offset calculation is wrong to access the register number to program the IO outbound ATU. Fix this by computing the ATU IO register number based on the number of MEM registers, not the size of the IO region. This causes 'synchronous external aborts' like the following: mwifiex_pcie 0000:01:00.0: enabling device (0000 -> 0002) mwifiex_pcie: PCI memory map Virt0: 00000000a573ad00 PCI memory map Virt2: 00000000783126c4 Internal error: synchronous external abort: 96000210 [#1] PREEMPT SMP Modules linked in: mwifiex_pcie(+) mwifiex uvcvideo cfg80211 atmel_mxt_ts videobuf2_vmalloc ... CPU: 2 PID: 269 Comm: systemd-udevd Not tainted 5.4.0+ #327 Hardware name: Google Kevin (DT) pstate: 60000005 (nZCv daif -PAN -UAO) pc : mwifiex_register_dev+0x264/0x3f8 [mwifiex_pcie] lr : mwifiex_register_dev+0x150/0x3f8 [mwifiex_pcie] sp : ffff800012073860 x29: ffff800012073860 x28: ffff8000100a2e28 x27: ffff8000118b6210 x26: ffff800008f57458 x25: ffff0000ecfda000 x24: 0000000000000001 x23: ffff0000e9905080 x22: ffff800008f5d000 x21: ffff0000eecea078 x20: ffff0000e9905080 x19: ffff0000eecea000 x18: 0000000000000001 x17: 0000000000000000 x16: 0000000000000000 x15: ffffffffffffffff x14: ffff8000118998c8 x13: ffff000000000000 x12: 0000000000000008 x11: 0101010101010101 x10: ffff7f7fffff7fff x9 : 0000000000000000 x8 : ffff0000e3c24240 x7 : 0000000000000000 x6 : ffff0000e3c24148 x5 : ffff0000e3c24148 x4 : ffff0000e7975ec8 x3 : 0000000000000001 x2 : 0000000000002b42 x1 : ffff800012c00008 x0 : ffff0000e9905080 Call trace: mwifiex_register_dev+0x264/0x3f8 [mwifiex_pcie] mwifiex_add_card+0x2f8/0x430 [mwifiex] mwifiex_pcie_probe+0x98/0x148 [mwifiex_pcie] pci_device_probe+0x110/0x1a8 ... Code: a8c67bfd d65f03c0 f942ac01 91002021 (b9400021) Suggested-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Fixes: 62240a8800 ("PCI: rockchip: Drop storing driver private outbound resource data) Link: https://lore.kernel.org/r/20191211093450.7481-1-enric.balletbo@collabora.com Reported-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Reported-by: Vicente Bergas <vicencb@gmail.com> Tested-by: Vicente Bergas <vicencb@gmail.com> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Acked-by: Andrew Murray <andrew.murray@arm.com>		2019-12-12 15:25:37 -06:00
..
controller	PCI: rockchip: Fix IO outbound ATU register number	2019-12-12 15:25:37 -06:00
endpoint	Merge branch 'remotes/lorenzo/pci/endpoint'	2019-11-28 08:54:42 -06:00
hotplug	pci-v5.5-changes	2019-12-03 13:58:22 -08:00
pcie	Merge branch 'pci/misc'	2019-11-28 08:54:32 -06:00
switch	pci-v5.5-changes	2019-12-03 13:58:22 -08:00
access.c
ats.c
bus.c
ecam.c
host-bridge.c
iov.c	Merge branch 'pci/trivial'	2019-11-28 08:54:55 -06:00
irq.c
Kconfig	Merge branch 'pci/trivial'	2019-11-28 08:54:55 -06:00
Makefile	PCI: Allow building PCIe things without PCIEPORTBUS	2019-11-21 07:52:33 -06:00
mmap.c
msi.c	PCI/MSI: Fix incorrect MSI-X masking on resume	2019-11-26 13:10:29 -06:00
of.c	PCI: Make devm_of_pci_get_host_bridge_resources() static	2019-11-20 17:00:14 +00:00
p2pdma.c
pci-acpi.c
pci-bridge-emul.c
pci-bridge-emul.h
pci-driver.c	PCI/PM: Add missing link delays required by the PCIe spec	2019-11-20 17:37:24 -06:00
pci-label.c
pci-mid.c
pci-pf-stub.c
pci-stub.c
pci-sysfs.c	Merge branch 'pci/resource'	2019-11-28 08:54:36 -06:00
pci.c	pci-v5.5-changes	2019-12-03 13:58:22 -08:00
pci.h	Merge branch 'remotes/lorenzo/pci/mmio-dma-ranges'	2019-11-28 08:54:53 -06:00
probe.c	Merge branch 'pci/trivial'	2019-11-28 08:54:55 -06:00
proc.c
quirks.c	Merge branch 'pci/trivial'	2019-11-28 08:54:55 -06:00
remove.c
rom.c
search.c
setup-bus.c
setup-irq.c
setup-res.c
slot.c
syscall.c
vc.c
vpd.c
xen-pcifront.c