e5f3155267
The 'imply' keyword does not do what most people think it does, it only
politely asks Kconfig to turn on another symbol, but does not prevent
it from being disabled manually or built as a loadable module when the
user is built-in. In the ICE driver, the latter now causes a link failure:
aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_eth_ioctl':
ice_main.c:(.text+0x13b0): undefined reference to `ice_ptp_get_ts_config'
ice_main.c:(.text+0x13b0): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_get_ts_config'
aarch64-linux-ld: ice_main.c:(.text+0x13bc): undefined reference to `ice_ptp_set_ts_config'
ice_main.c:(.text+0x13bc): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_set_ts_config'
aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_prepare_for_reset':
ice_main.c:(.text+0x31fc): undefined reference to `ice_ptp_release'
ice_main.c:(.text+0x31fc): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_release'
aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_rebuild':
This is a recurring problem in many drivers, and we have discussed
it several times befores, without reaching a consensus. I'm providing
a link to the previous email thread for reference, which discusses
some related problems.
To solve the dependency issue better than the 'imply' keyword, introduce a
separate Kconfig symbol "CONFIG_PTP_1588_CLOCK_OPTIONAL" that any driver
can depend on if it is able to use PTP support when available, but works
fine without it. Whenever CONFIG_PTP_1588_CLOCK=m, those drivers are
then prevented from being built-in, the same way as with a 'depends on
PTP_1588_CLOCK || !PTP_1588_CLOCK' dependency that does the same trick,
but that can be rather confusing when you first see it.
Since this should cover the dependencies correctly, the IS_REACHABLE()
hack in the header is no longer needed now, and can be turned back
into a normal IS_ENABLED() check. Any driver that gets the dependency
wrong will now cause a link time failure rather than being unable to use
PTP support when that is in a loadable module.
However, the two recently added ptp_get_vclocks_index() and
ptp_convert_timestamp() interfaces are only called from builtin code with
ethtool and socket timestamps, so keep the current behavior by stubbing
those out completely when PTP is in a loadable module. This should be
addressed properly in a follow-up.
As Richard suggested, we may want to actually turn PTP support into a
'bool' option later on, preventing it from being a loadable module
altogether, which would be one way to solve the problem with the ethtool
interface.
Fixes: 06c16d89d2 ("ice: register 1588 PTP clock device object for E810 devices")
Link: https://lore.kernel.org/netdev/20210804121318.337276-1-arnd@kernel.org/
Link: https://lore.kernel.org/netdev/CAK8P3a06enZOf=XyZ+zcAwBczv41UuCTz+=0FMf2gBz1_cOnZQ@mail.gmail.com/
Link: https://lore.kernel.org/netdev/CAK8P3a3=eOxE-K25754+fB_-i_0BZzf9a9RfPTX3ppSwu9WZXw@mail.gmail.com/
Link: https://lore.kernel.org/netdev/20210726084540.3282344-1-arnd@kernel.org/
Acked-by: Shannon Nelson <snelson@pensando.io>
Acked-by: Jacob Keller <jacob.e.keller@intel.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20210812183509.1362782-1-arnd@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
200 lines
5.5 KiB
Plaintext
200 lines
5.5 KiB
Plaintext
# SPDX-License-Identifier: GPL-2.0-only
|
|
#
|
|
# AMD network device configuration
|
|
#
|
|
|
|
config NET_VENDOR_AMD
|
|
bool "AMD devices"
|
|
default y
|
|
depends on DIO || MACH_DECSTATION || MVME147 || ATARI || SUN3 || \
|
|
SUN3X || SBUS || PCI || ZORRO || (ISA && ISA_DMA_API) || \
|
|
ISA || EISA || PCMCIA || ARM64
|
|
help
|
|
If you have a network (Ethernet) chipset belonging to this class,
|
|
say Y.
|
|
|
|
Note that the answer to this question does not directly affect
|
|
the kernel: saying N will just cause the configurator to skip all
|
|
the questions regarding AMD chipsets. If you say Y, you will be asked
|
|
for your specific chipset/driver in the following questions.
|
|
|
|
if NET_VENDOR_AMD
|
|
|
|
config A2065
|
|
tristate "A2065 support"
|
|
depends on ZORRO
|
|
select CRC32
|
|
help
|
|
If you have a Commodore A2065 Ethernet adapter, say Y. Otherwise,
|
|
say N.
|
|
|
|
To compile this driver as a module, choose M here: the module
|
|
will be called a2065.
|
|
|
|
config AMD8111_ETH
|
|
tristate "AMD 8111 (new PCI LANCE) support"
|
|
depends on PCI
|
|
select CRC32
|
|
select MII
|
|
help
|
|
If you have an AMD 8111-based PCI LANCE ethernet card,
|
|
answer Y here.
|
|
|
|
To compile this driver as a module, choose M here. The module
|
|
will be called amd8111e.
|
|
|
|
config LANCE
|
|
tristate "AMD LANCE and PCnet (AT1500 and NE2100) support"
|
|
depends on ISA && ISA_DMA_API && !ARM && !PPC32
|
|
select NETDEV_LEGACY_INIT
|
|
help
|
|
If you have a network (Ethernet) card of this type, say Y here.
|
|
Some LinkSys cards are of this type.
|
|
|
|
To compile this driver as a module, choose M here: the module
|
|
will be called lance. This is recommended.
|
|
|
|
config PCNET32
|
|
tristate "AMD PCnet32 PCI support"
|
|
depends on PCI
|
|
select CRC32
|
|
select MII
|
|
help
|
|
If you have a PCnet32 or PCnetPCI based network (Ethernet) card,
|
|
answer Y here.
|
|
|
|
To compile this driver as a module, choose M here. The module
|
|
will be called pcnet32.
|
|
|
|
config ARIADNE
|
|
tristate "Ariadne support"
|
|
depends on ZORRO
|
|
help
|
|
If you have a Village Tronic Ariadne Ethernet adapter, say Y.
|
|
Otherwise, say N.
|
|
|
|
To compile this driver as a module, choose M here: the module
|
|
will be called ariadne.
|
|
|
|
config ATARILANCE
|
|
tristate "Atari LANCE support"
|
|
depends on ATARI
|
|
help
|
|
Say Y to include support for several Atari Ethernet adapters based
|
|
on the AMD LANCE chipset: RieblCard (with or without battery), or
|
|
PAMCard VME (also the version by Rhotron, with different addresses).
|
|
|
|
config DECLANCE
|
|
tristate "DEC LANCE ethernet controller support"
|
|
depends on MACH_DECSTATION
|
|
select CRC32
|
|
help
|
|
This driver is for the series of Ethernet controllers produced by
|
|
DEC (now Compaq) based on the AMD LANCE chipset, including the
|
|
DEPCA series. (This chipset is better known via the NE2100 cards.)
|
|
|
|
config HPLANCE
|
|
tristate "HP on-board LANCE support"
|
|
depends on DIO
|
|
select CRC32
|
|
help
|
|
If you want to use the builtin "LANCE" Ethernet controller on an
|
|
HP300 machine, say Y here.
|
|
|
|
config MIPS_AU1X00_ENET
|
|
tristate "MIPS AU1000 Ethernet support"
|
|
depends on MIPS_ALCHEMY
|
|
select PHYLIB
|
|
select CRC32
|
|
help
|
|
If you have an Alchemy Semi AU1X00 based system
|
|
say Y. Otherwise, say N.
|
|
|
|
config MVME147_NET
|
|
tristate "MVME147 (LANCE) Ethernet support"
|
|
depends on MVME147
|
|
select CRC32
|
|
help
|
|
Support for the on-board Ethernet interface on the Motorola MVME147
|
|
single-board computer. Say Y here to include the
|
|
driver for this chip in your kernel.
|
|
To compile this driver as a module, choose M here.
|
|
|
|
config PCMCIA_NMCLAN
|
|
tristate "New Media PCMCIA support"
|
|
depends on PCMCIA
|
|
help
|
|
Say Y here if you intend to attach a New Media Ethernet or LiveWire
|
|
PCMCIA (PC-card) Ethernet card to your computer.
|
|
|
|
To compile this driver as a module, choose M here: the module will be
|
|
called nmclan_cs. If unsure, say N.
|
|
|
|
config NI65
|
|
tristate "NI6510 support"
|
|
depends on ISA && ISA_DMA_API && !ARM && !PPC32
|
|
select NETDEV_LEGACY_INIT
|
|
help
|
|
If you have a network (Ethernet) card of this type, say Y here.
|
|
|
|
To compile this driver as a module, choose M here. The module
|
|
will be called ni65.
|
|
|
|
config SUN3LANCE
|
|
tristate "Sun3/Sun3x on-board LANCE support"
|
|
depends on (SUN3 || SUN3X)
|
|
help
|
|
Most Sun3 and Sun3x motherboards (including the 3/50, 3/60 and 3/80)
|
|
featured an AMD LANCE 10Mbit Ethernet controller on board; say Y
|
|
here to compile in the Linux driver for this and enable Ethernet.
|
|
General Linux information on the Sun 3 and 3x series (now
|
|
discontinued) is at
|
|
<http://www.angelfire.com/ca2/tech68k/sun3.html>.
|
|
|
|
If you're not building a kernel for a Sun 3, say N.
|
|
|
|
config SUNLANCE
|
|
tristate "Sun LANCE support"
|
|
depends on SBUS
|
|
select CRC32
|
|
help
|
|
This driver supports the "le" interface present on all 32-bit Sparc
|
|
systems, on some older Ultra systems and as an Sbus option. These
|
|
cards are based on the AMD LANCE chipset, which is better known
|
|
via the NE2100 cards.
|
|
|
|
To compile this driver as a module, choose M here: the module
|
|
will be called sunlance.
|
|
|
|
config AMD_XGBE
|
|
tristate "AMD 10GbE Ethernet driver"
|
|
depends on ((OF_NET && OF_ADDRESS) || ACPI || PCI) && HAS_IOMEM
|
|
depends on X86 || ARM64 || COMPILE_TEST
|
|
depends on PTP_1588_CLOCK_OPTIONAL
|
|
select BITREVERSE
|
|
select CRC32
|
|
select PHYLIB
|
|
select AMD_XGBE_HAVE_ECC if X86
|
|
help
|
|
This driver supports the AMD 10GbE Ethernet device found on an
|
|
AMD SoC.
|
|
|
|
To compile this driver as a module, choose M here: the module
|
|
will be called amd-xgbe.
|
|
|
|
config AMD_XGBE_DCB
|
|
bool "Data Center Bridging (DCB) support"
|
|
default n
|
|
depends on AMD_XGBE && DCB
|
|
help
|
|
Say Y here to enable Data Center Bridging (DCB) support in the
|
|
driver.
|
|
|
|
If unsure, say N.
|
|
|
|
config AMD_XGBE_HAVE_ECC
|
|
bool
|
|
default n
|
|
|
|
endif # NET_VENDOR_AMD
|