forked from Minki/linux
1bf6ad622b
If we restrict this helper to only kms drivers (which is the case) we can look up the correct mode easily ourselves. But it's a bit tricky: - All legacy drivers look at crtc->hwmode. But that is updated already at the beginning of the modeset helper, which means when we disable a pipe. Hence the final timestamps might be a bit off. But since this is an existing bug I'm not going to change it, but just try to be bug-for-bug compatible with the current code. This only applies to radeon&amdgpu. - i915 tries to get it perfect by updating crtc->hwmode when the pipe is off (i.e. vblank->enabled = false). - All other atomic drivers look at crtc->state->adjusted_mode. Those that look at state->requested_mode simply don't adjust their mode, so it's the same. That has two problems: Accessing crtc->state from interrupt handling code is unsafe, and it's updated before we shut down the pipe. For nonblocking modesets it's even worse. For atomic drivers try to implement what i915 does. To do that we add a new hwmode field to the vblank structure, and update it from drm_calc_timestamping_constants(). For atomic drivers that's called from the right spot by the helper library already, so all fine. But for safety let's enforce that. For legacy driver this function is only called at the end (oh the fun), which is broken, so again let's not bother and just stay bug-for-bug compatible. The benefit is that we can use drm_calc_vbltimestamp_from_scanoutpos directly to implement ->get_vblank_timestamp in every driver, deleting a lot of code. v2: Completely new approach, trying to mimick the i915 solution. v3: Fixup kerneldoc. v4: Drop the WARN_ON to check that the vblank is off, atomic helpers currently unconditionally call this. Recomputing the same stuff should be harmless. v5: Fix typos and move misplaced hunks to the right patches (Neil). v6: Undo hunk movement (kbuild). Cc: Mario Kleiner <mario.kleiner@tuebingen.mpg.de> Cc: Eric Anholt <eric@anholt.net> Cc: Rob Clark <robdclark@gmail.com> Cc: linux-arm-msm@vger.kernel.org Cc: freedreno@lists.freedesktop.org Cc: Alex Deucher <alexander.deucher@amd.com> Cc: Christian König <christian.koenig@amd.com> Cc: Ben Skeggs <bskeggs@redhat.com> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/20170509140329.24114-4-daniel.vetter@ffwll.ch
118 lines
3.3 KiB
C
118 lines
3.3 KiB
C
#ifndef __NOUVEAU_DISPLAY_H__
|
|
#define __NOUVEAU_DISPLAY_H__
|
|
|
|
#include <subdev/mmu.h>
|
|
|
|
#include "nouveau_drv.h"
|
|
|
|
struct nouveau_framebuffer {
|
|
struct drm_framebuffer base;
|
|
struct nouveau_bo *nvbo;
|
|
struct nvkm_vma vma;
|
|
u32 r_handle;
|
|
u32 r_format;
|
|
u32 r_pitch;
|
|
struct nvif_object h_base[4];
|
|
struct nvif_object h_core;
|
|
};
|
|
|
|
static inline struct nouveau_framebuffer *
|
|
nouveau_framebuffer(struct drm_framebuffer *fb)
|
|
{
|
|
return container_of(fb, struct nouveau_framebuffer, base);
|
|
}
|
|
|
|
int nouveau_framebuffer_new(struct drm_device *,
|
|
const struct drm_mode_fb_cmd2 *,
|
|
struct nouveau_bo *, struct nouveau_framebuffer **);
|
|
|
|
struct nouveau_page_flip_state {
|
|
struct list_head head;
|
|
struct drm_pending_vblank_event *event;
|
|
struct drm_crtc *crtc;
|
|
int bpp, pitch;
|
|
u64 offset;
|
|
};
|
|
|
|
struct nouveau_display {
|
|
void *priv;
|
|
void (*dtor)(struct drm_device *);
|
|
int (*init)(struct drm_device *);
|
|
void (*fini)(struct drm_device *);
|
|
|
|
struct nvif_object disp;
|
|
|
|
struct drm_property *dithering_mode;
|
|
struct drm_property *dithering_depth;
|
|
struct drm_property *underscan_property;
|
|
struct drm_property *underscan_hborder_property;
|
|
struct drm_property *underscan_vborder_property;
|
|
/* not really hue and saturation: */
|
|
struct drm_property *vibrant_hue_property;
|
|
struct drm_property *color_vibrance_property;
|
|
|
|
struct drm_atomic_state *suspend;
|
|
};
|
|
|
|
static inline struct nouveau_display *
|
|
nouveau_display(struct drm_device *dev)
|
|
{
|
|
return nouveau_drm(dev)->display;
|
|
}
|
|
|
|
int nouveau_display_create(struct drm_device *dev);
|
|
void nouveau_display_destroy(struct drm_device *dev);
|
|
int nouveau_display_init(struct drm_device *dev);
|
|
void nouveau_display_fini(struct drm_device *dev, bool suspend);
|
|
int nouveau_display_suspend(struct drm_device *dev, bool runtime);
|
|
void nouveau_display_resume(struct drm_device *dev, bool runtime);
|
|
int nouveau_display_vblank_enable(struct drm_device *, unsigned int);
|
|
void nouveau_display_vblank_disable(struct drm_device *, unsigned int);
|
|
bool nouveau_display_scanoutpos(struct drm_device *, unsigned int,
|
|
bool, int *, int *, ktime_t *,
|
|
ktime_t *, const struct drm_display_mode *);
|
|
|
|
int nouveau_crtc_page_flip(struct drm_crtc *crtc, struct drm_framebuffer *fb,
|
|
struct drm_pending_vblank_event *event,
|
|
uint32_t page_flip_flags,
|
|
struct drm_modeset_acquire_ctx *ctx);
|
|
int nouveau_finish_page_flip(struct nouveau_channel *,
|
|
struct nouveau_page_flip_state *);
|
|
|
|
int nouveau_display_dumb_create(struct drm_file *, struct drm_device *,
|
|
struct drm_mode_create_dumb *args);
|
|
int nouveau_display_dumb_map_offset(struct drm_file *, struct drm_device *,
|
|
u32 handle, u64 *offset);
|
|
|
|
void nouveau_hdmi_mode_set(struct drm_encoder *, struct drm_display_mode *);
|
|
|
|
#ifdef CONFIG_DRM_NOUVEAU_BACKLIGHT
|
|
extern int nouveau_backlight_init(struct drm_device *);
|
|
extern void nouveau_backlight_exit(struct drm_device *);
|
|
extern void nouveau_backlight_ctor(void);
|
|
extern void nouveau_backlight_dtor(void);
|
|
#else
|
|
static inline int
|
|
nouveau_backlight_init(struct drm_device *dev)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline void
|
|
nouveau_backlight_exit(struct drm_device *dev) {
|
|
}
|
|
|
|
static inline void
|
|
nouveau_backlight_ctor(void) {
|
|
}
|
|
|
|
static inline void
|
|
nouveau_backlight_dtor(void) {
|
|
}
|
|
#endif
|
|
|
|
struct drm_framebuffer *
|
|
nouveau_user_framebuffer_create(struct drm_device *, struct drm_file *,
|
|
const struct drm_mode_fb_cmd2 *);
|
|
#endif
|