Christoph Paasch b709323d24 igb: Unset IGB_FLAG_HAS_MSIX-flag when falling back to msi-only ... Prior to cd14ef54d2 (igb: Change to use statically allocated array for MSIx entries), having msix_entries different from NULL was an indicator that MSIX is enabled. In igb_set_interrupt_capabiliy we may fall back to MSI-only. Prior to the above patch msix_entries was set to NULL by igb_reset_interrupt_capability. However, now we are checking the flag for IGB_FLAG_HAS_MSIX and so the stack gets completly confused: [ 42.659791] ------------[ cut here ]------------ [ 42.715032] WARNING: CPU: 7 PID: 0 at net/sched/sch_generic.c:264 dev_watchdog+0x15c/0x1fb() [ 42.848263] NETDEV WATCHDOG: eth0 (igb): transmit queue 0 timed out [ 42.923253] Modules linked in: [ 42.959875] CPU: 7 PID: 0 Comm: swapper/7 Not tainted 3.14.0-rc2-mptcp #437 [ 43.043184] Hardware name: HP ProLiant DL165 G7, BIOS O37 01/26/2011 [ 43.119215] 0000000000000108 ffff88023fdc3da8 ffffffff81487847 0000000000000108 [ 43.208165] ffff88023fdc3df8 ffff88023fdc3de8 ffffffff81034e7d ffff88023fdc3dd8 [ 43.297120] ffffffff813fff10 ffff880236018000 ffff880236b178c0 0000000000000008 [ 43.386071] Call Trace: [ 43.415303] <IRQ> [<ffffffff81487847>] dump_stack+0x49/0x62 [ 43.484174] [<ffffffff81034e7d>] warn_slowpath_common+0x77/0x91 [ 43.556049] [<ffffffff813fff10>] ? dev_watchdog+0x15c/0x1fb [ 43.623759] [<ffffffff81034f2b>] warn_slowpath_fmt+0x41/0x43 [ 43.692511] [<ffffffff813fff10>] dev_watchdog+0x15c/0x1fb [ 43.758141] [<ffffffff813ffdb4>] ? __netdev_watchdog_up+0x64/0x64 [ 43.832091] [<ffffffff8103cd04>] call_timer_fn+0x17/0x6f [ 43.896682] [<ffffffff8103cebe>] run_timer_softirq+0x162/0x1a2 [ 43.967511] [<ffffffff81038520>] __do_softirq+0xcd/0x1cc [ 44.032104] [<ffffffff81038689>] irq_exit+0x3a/0x48 [ 44.091492] [<ffffffff81026d43>] smp_apic_timer_interrupt+0x43/0x50 [ 44.167525] [<ffffffff8148c24a>] apic_timer_interrupt+0x6a/0x70 [ 44.239392] <EOI> [<ffffffff8100992c>] ? default_idle+0x6/0x8 [ 44.310343] [<ffffffff81009b31>] arch_cpu_idle+0x13/0x18 [ 44.374934] [<ffffffff81066126>] cpu_startup_entry+0xa7/0x101 [ 44.444724] [<ffffffff81025660>] start_secondary+0x1b2/0x1b7 [ 44.513472] ---[ end trace a5a075fd4e7f854f ]--- [ 44.568753] igb 0000:04:00.0 eth0: Reset adapter [ 46.206945] random: nonblocking pool is initialized [ 46.465670] irq 44: nobody cared (try booting with the "irqpoll" option) [ 46.545862] CPU: 7 PID: 0 Comm: swapper/7 Tainted: G W 3.14.0-rc2-mptcp #437 [ 46.640610] Hardware name: HP ProLiant DL165 G7, BIOS O37 01/26/2011 [ 46.716641] ffff8802363f8c84 ffff88023fdc3e38 ffffffff81487847 00000000a03cdb6d [ 46.805598] ffff8802363f8c00 ffff88023fdc3e68 ffffffff81068489 0000007f81825400 [ 46.894539] ffff8802363f8c00 0000000000000000 0000000000000000 ffff88023fdc3ea8 [ 46.983484] Call Trace: [ 47.012714] <IRQ> [<ffffffff81487847>] dump_stack+0x49/0x62 [ 47.081585] [<ffffffff81068489>] __report_bad_irq+0x35/0xc1 [ 47.149295] [<ffffffff81068683>] note_interrupt+0x16e/0x1ea [ 47.217006] [<ffffffff8106679e>] handle_irq_event_percpu+0x116/0x12e [ 47.294075] [<ffffffff810667e9>] handle_irq_event+0x33/0x4f [ 47.361787] [<ffffffff81068c95>] handle_fasteoi_irq+0x83/0xd1 [ 47.431577] [<ffffffff81003d5b>] handle_irq+0x1f/0x28 [ 47.493047] [<ffffffff81003567>] do_IRQ+0x4e/0xd4 [ 47.550358] [<ffffffff8148b06a>] common_interrupt+0x6a/0x6a [ 47.618066] <EOI> [<ffffffff8100992c>] ? default_idle+0x6/0x8 [ 47.689016] [<ffffffff81009b31>] arch_cpu_idle+0x13/0x18 [ 47.753605] [<ffffffff81066126>] cpu_startup_entry+0xa7/0x101 [ 47.823397] [<ffffffff81025660>] start_secondary+0x1b2/0x1b7 [ 47.892146] handlers: [ 47.919301] [<ffffffff812fbd7d>] igb_intr So, this patch unsets the flag to indicate that we are not using MSIX. This patch does exactly this: Unsetting the flag when falling back to MSI. Fixes: cd14ef54d2 (igb: Change to use statically allocated array for MSIx entries) Cc: Carolyn Wyborny <carolyn.wyborny@intel.com> Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be> Tested-by: Jeff Pieper <jeffrey.e.pieper@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>		2014-03-21 05:05:54 -07:00
..
accessibility
acpi	ACPI / sleep: Add extra checks for HW Reduced ACPI mode sleep states	2014-03-13 22:11:39 +01:00
amba
ata	Merge branch 'for-3.14-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata	2014-03-10 12:56:24 -07:00
atm	atm: nicstar: remove interruptible_sleep_on_timeout	2014-02-27 15:22:46 -05:00
auxdisplay
base	PM / hibernate: Fix restore hang in freeze_processes()	2014-02-26 01:13:15 +01:00
bcma	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2014-01-30 17:20:32 -08:00
block	Merge branch 'for-linus' of git://git.kernel.dk/linux-block	2014-03-07 09:59:44 -08:00
bluetooth	Bluetooth: append new supported device to the list [0b05:17d0]	2014-02-18 09:54:20 -08:00
bus	drivers: bus: fix CCI driver kcalloc call parameters swap	2014-01-31 15:15:13 -08:00
cdrom	Merge branch 'for-3.14/drivers' of git://git.kernel.dk/linux-block	2014-01-30 11:40:10 -08:00
char	Char/Misc fixes for 3.14-rc3	2014-02-14 16:13:00 -08:00
clk	Single fix for a clock driver merged in 3.14-rc1. Without this fix the	2014-03-08 10:51:30 -08:00
clocksource	clocksource: Kona: Print warning rather than panic	2014-02-06 16:01:40 +01:00
connector	connector: remove duplicated code in cn_call_callback()	2014-03-03 15:39:20 -05:00
cpufreq	cpufreq: Skip current frequency initialization for ->setpolicy drivers	2014-03-13 00:37:16 +01:00
cpuidle	powerpc/powernv/cpuidle: Back-end cpuidle driver for powernv platform.	2014-01-29 17:02:24 +11:00
crypto	crypto/nx/nx-842: Fix handling of vmalloc addresses	2014-02-11 11:24:49 +11:00
dca
devfreq	Merge branches 'pm-cpufreq' and 'pm-devfreq'	2014-01-29 11:48:23 +01:00
dio
dma	Merge branch 'fixes' of git://git.infradead.org/users/vkoul/slave-dma	2014-03-01 21:30:43 -06:00
edac	i7300_edac: Fix device reference count	2014-02-25 09:43:13 +01:00
eisa	Revert "EISA: Initialize device before its resources"	2014-01-17 14:57:29 -07:00
extcon	ASoC: dapm: Add locking to snd_soc_dapm_xxxx_pin functions	2014-02-20 18:40:07 +09:00
firewire	Merge branch 'for-3.14-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq	2014-03-08 11:51:13 -08:00
firmware	firmware/google: drop 'select EFI' to avoid recursive dependency	2014-01-27 21:02:40 -08:00
fmc	drivers/fmc/fmc-write-eeprom.c: fix decimal permissions	2014-02-25 15:25:43 -08:00
gpio	gpio: tb10x: GPIO_TB10X needs to select GENERIC_IRQ_CHIP	2014-02-05 11:13:59 +01:00
gpu	Merge tag 'ttm-fixes-3.14-2014-03-12' of git://people.freedesktop.org/~thomash/linux into drm-fixes	2014-03-13 17:31:24 +10:00
hid	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid	2014-02-18 16:29:46 -08:00
hsi
hv	Drivers: hv: vmbus: Don't timeout during the initial connection with host	2014-02-07 08:27:34 -08:00
hwmon	hwmon: (max1668) Fix writing the minimum temperature	2014-02-18 15:53:49 -08:00
hwspinlock
i2c	i2c: Remove usage of orphaned symbol OF_I2C	2014-03-13 22:33:44 +01:00
ide	drivers: ide: Include appropriate header file in ide-pio-blacklist.c	2014-01-28 23:35:09 -08:00
idle	ACPI and power management updates for 3.14-rc1	2014-01-24 15:51:02 -08:00
iio	iio:gyro: bug on L3GD20H gyroscope support	2014-02-18 10:24:49 +00:00
infiniband	net/mlx4: Adapt code for N-Port VF	2014-03-20 16:18:30 -04:00
input	ASoC: dapm: Add locking to snd_soc_dapm_xxxx_pin functions	2014-02-20 18:40:07 +09:00
iommu	drivers/iommu/omap-iommu-debug.c: fix decimal permissions	2014-02-25 15:25:42 -08:00
ipack
irqchip	irq-metag*: stop set_affinity vectoring to offline cpus	2014-02-25 22:35:06 +00:00
isdn	isdn: fix multiple sleep_on races	2014-02-26 16:06:13 -05:00
leds	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds	2014-01-28 18:53:01 -08:00
lguest
macintosh	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc	2014-01-27 21:11:26 -08:00
mailbox	drivers/mailbox/omap: make mbox->irq signed for error handling	2014-01-23 16:36:53 -08:00
md	dm cache: fix access beyond end of origin device	2014-03-12 13:52:00 -04:00
media	[media] adv7842: Composite free-run platfrom-data fix	2014-02-04 06:46:10 -02:00
memory
memstick	drivers/memstick/host/rtsx_pci_ms.c: fix ms card data transfer bug	2014-01-23 16:37:04 -08:00
message	drivers/message/i2o/i2o_config.c: fix deadlock in compat_ioctl(I2OGETIOPS)	2014-02-10 16:01:40 -08:00
mfd	sound fixes for 3.14-rc4	2014-02-21 09:55:32 -08:00
misc	mm: fix GFP_THISNODE callers and clarify	2014-03-10 17:26:19 -07:00
mmc	Fix uses of dma_max_pfn() when converting to a limiting address	2014-02-17 23:08:41 +00:00
mtd	Just a single fix for the UBI module unload path which makes sure we do not	2014-02-27 10:36:50 -08:00
net	igb: Unset IGB_FLAG_HAS_MSIX-flag when falling back to msi-only	2014-03-21 05:05:54 -07:00
nfc
ntb
nubus
of	of_mdio: Allow the DT to specify the phy ID and avoid autoprobing	2014-03-20 17:10:28 -04:00
oprofile
parisc
parport	TTY/Serial driver patches for 3.14-rc1	2014-01-20 16:05:23 -08:00
pci	PCI: Don't check resource_size() in pci_bus_alloc_resource()	2014-03-12 11:19:20 -06:00
pcmcia	PCI changes for the v3.14 merge window:	2014-01-22 16:39:28 -08:00
phy	phy: let phy_provider_register be the last step in registering PHY	2014-02-18 12:13:16 -08:00
pinctrl	ARM: SoC fixes for 3.14-rc	2014-03-09 19:27:31 -07:00
platform	platform/chrome: Cleanups and improvements	2014-01-29 20:06:01 -08:00
pnp	PNP / ACPI: proper handling of ACPI IO/Memory resource parsing failures	2014-03-11 21:22:10 +01:00
power	Few fixes:	2014-02-14 10:32:28 -08:00
powercap
pps
ps3
ptp	ptp_pch: Add dependency on HAS_IOMEM	2014-01-15 14:51:22 -08:00
pwm	pwm: lp3943: Fix potential memory leak during request	2014-02-26 15:45:12 +01:00
rapidio	rapidio/tsi721: fix tasklet termination in dma channel release	2014-03-04 07:55:49 -08:00
regulator	regulator: Fixes for v3.14-rc5	2014-03-04 08:41:42 -08:00
remoteproc
reset
rpmsg
rtc	drivers/rtc/rtc-s3c.c: fix incorrect way of save/restore of S3C2410_TICNT for TYPE_S3C64XX	2014-03-04 07:55:48 -08:00
s390	qeth: Fix IP version detection for VLAN traffic	2014-03-20 00:06:56 -04:00
sbus	Sparc: sparc_cpu_model isn't in asm/system.h any more [ver #2]	2014-02-20 13:34:11 -05:00
scsi	Merge git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending	2014-03-01 21:33:09 -06:00
sfi
sh
sn
spi	Merge remote-tracking branches 'spi/fix/ath79', 'spi/fix/atmel', 'spi/fix/coldfire', 'spi/fix/fsl-dspi', 'spi/fix/imx' and 'spi/fix/topcliff-pch' into spi-linus	2014-03-07 11:08:13 +08:00
ssb	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2014-01-30 17:20:32 -08:00
staging	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2014-03-14 22:31:55 -04:00
target	Target/sbc: Fix sbc_copy_prot for offset scatters	2014-03-06 20:52:11 -08:00
tc
thermal	Thermal: thermal zone governor fix	2014-03-03 23:15:57 +08:00
tty	Revert "tty: Set correct tty name in 'active' sysfs attribute"	2014-02-22 14:31:04 -08:00
uio
usb	Revert "xhci 1.0: Limit arbitrarily-aligned scatter gather."	2014-03-07 11:48:13 -08:00
uwb
vfio	mm: close PageTail race	2014-03-04 07:55:47 -08:00
vhost	Merge git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending	2014-03-01 21:33:09 -06:00
video	video: Kconfig: Allow more broad selection of the imxfb framebuffer driver.	2014-02-14 10:44:52 +02:00
virt
virtio	A few simple fixes. Quiet cycle.	2014-01-22 22:24:35 -08:00
vlynq	drivers/vlynq/vlynq.c: fix another resource size off by 1 error	2014-01-23 16:36:55 -08:00
vme	VME: Correct read/write alignment algorithm	2014-02-07 08:16:14 -08:00
w1	drivers/w1/masters/w1-gpio.c: add strong pullup emulation	2014-01-23 16:37:04 -08:00
watchdog	watchdog: w83697hf_wdt: return ENODEV if no device was found	2014-02-21 20:36:46 +01:00
xen	Bug-fix:	2014-02-12 12:28:05 -08:00
zorro
Kconfig
Makefile